From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_conntrack] examples: check return value of nfct_nlmsg_build()
Date: Sun, 3 Jan 2021 20:04:58 +0100 [thread overview]
Message-ID: <20210103190458.GA17660@salvia> (raw)
In-Reply-To: <20210101090226.3237589-1-eyal.birger@gmail.com>
On Fri, Jan 01, 2021 at 11:02:26AM +0200, Eyal Birger wrote:
> nfct_nlmsg_build() may fail for different reasons, for example if
> insufficient parameters exist in the ct object. The resulting nlh would
> not contain any of the ct attributes.
>
> Some conntrack operations would still operate in such case, for example
> an IPCTNL_MSG_CT_DELETE message would just delete all existing conntrack
> entries.
>
> While the example as it is does supply correct parameters, it's safer
> as reference to validate the return value.
Applied, thanks.
next prev parent reply other threads:[~2021-01-03 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 9:02 [PATCH libnetfilter_conntrack] examples: check return value of nfct_nlmsg_build() Eyal Birger
2021-01-03 19:04 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-01 8:58 Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103190458.GA17660@salvia \
--to=pablo@netfilter.org \
--cc=eyal.birger@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.