All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Henning Colliander <henning.colliander@evidente.se>,
	Christer Beskow <chbe@kvaser.com>,
	Jimmy Assarsson <extja@kvaser.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] can: kvaser_pciefd: select CONFIG_CRC32
Date: Sun,  3 Jan 2021 22:36:19 +0100	[thread overview]
Message-ID: <20210103213645.1994783-3-arnd@kernel.org> (raw)
In-Reply-To: <20210103213645.1994783-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

Without crc32, this driver fails to link:

arm-linux-gnueabi-ld: drivers/net/can/kvaser_pciefd.o: in function `kvaser_pciefd_probe':
kvaser_pciefd.c:(.text+0x2b0): undefined reference to `crc32_be'

Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/can/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 424970939fd4..1c28eade6bec 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -123,6 +123,7 @@ config CAN_JANZ_ICAN3
 config CAN_KVASER_PCIEFD
 	depends on PCI
 	tristate "Kvaser PCIe FD cards"
+	select CRC32
 	  help
 	  This is a driver for the Kvaser PCI Express CAN FD family.
 
-- 
2.29.2


  parent reply	other threads:[~2021-01-03 21:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 21:36 [PATCH 1/7] qed: select CONFIG_CRC32 Arnd Bergmann
2021-01-03 21:36 ` [PATCH 2/7] phy: dp83640: " Arnd Bergmann
2021-01-03 23:09   ` Andrew Lunn
2021-01-04 13:03   ` Richard Cochran
2021-01-03 21:36 ` Arnd Bergmann [this message]
2021-01-04  8:43   ` [PATCH 3/7] can: kvaser_pciefd: " Marc Kleine-Budde
2021-01-03 21:36 ` [PATCH 4/7] wil6210: " Arnd Bergmann
2021-01-11 11:47   ` Kalle Valo
2021-01-14 18:45   ` Kalle Valo
2021-01-03 21:36 ` [PATCH 5/7] cfg80211: " Arnd Bergmann
2021-01-03 21:36 ` [PATCH 6/7] misdn: dsp: select CONFIG_BITREVERSE Arnd Bergmann
2021-01-03 21:36 ` [PATCH 7/7] wan: ds26522: " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210103213645.1994783-3-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=chbe@kvaser.com \
    --cc=davem@davemloft.net \
    --cc=extja@kvaser.com \
    --cc=henning.colliander@evidente.se \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.