From: Arnd Bergmann <arnd@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org
Subject: [PATCH] pldmfw: select CONFIG_CRC32
Date: Sun, 3 Jan 2021 22:43:28 +0100 [thread overview]
Message-ID: <20210103214339.1997223-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Without CRC32, pldmfw fails to link:
arm-linux-gnueabi-ld: lib/pldmfw/pldmfw.o: in function `pldmfw_flash_image':
(.text+0x1028): undefined reference to `crc32_le'
Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig b/lib/Kconfig
index 46806332a8cc..86dc0dcd6e0b 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -691,4 +691,5 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
config PLDMFW
bool
+ select CRC32
default n
--
2.29.2
reply other threads:[~2021-01-03 21:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210103214339.1997223-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.