From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81B5C433DB for ; Mon, 4 Jan 2021 11:16:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 766A8207BC for ; Mon, 4 Jan 2021 11:16:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 766A8207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y50RVLLlQMT4sbBJglrUY0TyzaJvn0zXMMzaA2YafB0=; b=qupYvB7qpeBNtfTEL8nF135F7 E0Q/CqF6HK0RIcKcuAVqB+LH8pNCi2Vd+t4ynUrGqTnuoEJWJqYRa9/mIWx04oEsLlNpTt+V4ZLH6 1Bbn9RqQ7ATmn9atb8vtx6/T+y1frnfXJkTFUot+Z4YgoO/y0IF/SplxdvLW8D1QX1Ms27RTqU5yB t9DC3aTo/CqnxKB9ALXI9xXsSmAtBVCb+3n7Ztd7AxtZyP4pC2ubGK//WuJFs+fyciPhe9hhl8BC1 ik6VNBhTioRQm/FPLV+cLYYUW3MsKrRFusm2mpX2gjdE55vmkP1Thw8DyMKrlb4oGT13YqTz2+Mhq QSVj/VSXg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwNpb-0002tO-RA; Mon, 04 Jan 2021 11:15:23 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwNpZ-0002s7-58 for linux-mtd@lists.infradead.org; Mon, 04 Jan 2021 11:15:22 +0000 Received: from xps13 (lfbn-tou-1-1535-bdcst.w90-89.abo.wanadoo.fr [90.89.98.255]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AE75620000C; Mon, 4 Jan 2021 11:15:17 +0000 (UTC) Date: Mon, 4 Jan 2021 12:15:16 +0100 From: Miquel Raynal To: Sean Nyekjaer Subject: Re: [PATCH] mtd: rawnand: gpmi: fix dst bit offset when extracting raw payload Message-ID: <20210104121516.3d50fb58@xps13> In-Reply-To: <7db4b36e-23a6-6075-132c-214d043e78bd@geanix.com> References: <20210104103558.9035-1-miquel.raynal@bootlin.com> <7db4b36e-23a6-6075-132c-214d043e78bd@geanix.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_061521_297760_A88C7990 X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Martin =?UTF-8?B?SHVuZGViw7hsbA==?= , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mtd@lists.infradead.org, Richard Weinberger , Han Xu Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2VhbiwKClNlYW4gTnlla2phZXIgPHNlYW5AZ2Vhbml4LmNvbT4gd3JvdGUgb24gTW9uLCA0 IEphbiAyMDIxIDExOjUwOjEwICswMTAwOgoKPiBPbiAwNC8wMS8yMDIxIDExLjM1LCBNaXF1ZWwg UmF5bmFsIHdyb3RlOgo+ID4gT24gTW9uLCAyMDIwLTEyLTIxIGF0IDEwOjAwOjEzIFVUQywgU2Vh biBOeWVramFlciB3cm90ZTogIAo+ID4+IFJlLWFkZCB0aGUgbXVsdGlwbHkgYnkgOCB0byAic3Rl cCAqIGVjY3NpemUiIHRvIGNvcnJlY3QgdGhlIGRlc3RpbmF0aW9uIGJpdCBvZmZzZXQKPiA+PiB3 aGVuIGV4dHJhY3RpbmcgdGhlIGRhdGEgcGF5bG9hZCBpbiBncG1pX2VjY19yZWFkX3BhZ2VfcmF3 KCkuCj4gPj4KPiA+PiBGaXhlczogZTVlNTYzMWNjODg5ICgibXRkOiByYXduYW5kOiBncG1pOiBV c2UgbmFuZF9leHRyYWN0X2JpdHMoKSIpCj4gPj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcK PiA+PiBSZXBvcnRlZC1ieTogTWFydGluIEh1bmRlYsO4bGwgPG1hcnRpbkBnZWFuaXguY29tPgo+ ID4+IFNpZ25lZC1vZmYtYnk6IFNlYW4gTnlla2phZXIgPHNlYW5AZ2Vhbml4LmNvbT4gIAo+ID4g QXBwbGllZCB0byBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dp dC9tdGQvbGludXguZ2l0IG5hbmQvbmV4dCwgdGhhbmtzLgo+ID4KPiA+IE1pcXVlbCAgCj4gSGkg TWlxdWVsCj4gCj4gV2lsbCB5b3UgcGxlYXNlIHF1ZXVlIHRoaXMgZm9yIGZpeGVzPyBJdCdzIHF1 aXRlIHJlbGV2YW50IGZvciA1LjEwIExUUyA6KQoKUmlnaHQsIHRoYXQgd2lsbCBiZSBxdWlja2Vy IHRvIGhhdmUgaXQgaW4gTGludXMnIHRyZWUuIEkgbW92ZWQKdGhlIHBhdGNoIHRvIHRoZSBtdGQv bmV4dCBicmFuY2guCgpDaGVlcnMsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5n IGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1t dGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD89C433E6 for ; Mon, 4 Jan 2021 11:16:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8293D21E92 for ; Mon, 4 Jan 2021 11:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbhADLQB convert rfc822-to-8bit (ORCPT ); Mon, 4 Jan 2021 06:16:01 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:38497 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbhADLQB (ORCPT ); Mon, 4 Jan 2021 06:16:01 -0500 Received: from xps13 (lfbn-tou-1-1535-bdcst.w90-89.abo.wanadoo.fr [90.89.98.255]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AE75620000C; Mon, 4 Jan 2021 11:15:17 +0000 (UTC) Date: Mon, 4 Jan 2021 12:15:16 +0100 From: Miquel Raynal To: Sean Nyekjaer Cc: Han Xu , Richard Weinberger , Vignesh Raghavendra , Martin =?UTF-8?B?SHVuZGViw7hsbA==?= , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: gpmi: fix dst bit offset when extracting raw payload Message-ID: <20210104121516.3d50fb58@xps13> In-Reply-To: <7db4b36e-23a6-6075-132c-214d043e78bd@geanix.com> References: <20210104103558.9035-1-miquel.raynal@bootlin.com> <7db4b36e-23a6-6075-132c-214d043e78bd@geanix.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, Sean Nyekjaer wrote on Mon, 4 Jan 2021 11:50:10 +0100: > On 04/01/2021 11.35, Miquel Raynal wrote: > > On Mon, 2020-12-21 at 10:00:13 UTC, Sean Nyekjaer wrote: > >> Re-add the multiply by 8 to "step * eccsize" to correct the destination bit offset > >> when extracting the data payload in gpmi_ecc_read_page_raw(). > >> > >> Fixes: e5e5631cc889 ("mtd: rawnand: gpmi: Use nand_extract_bits()") > >> Cc: stable@vger.kernel.org > >> Reported-by: Martin Hundebøll > >> Signed-off-by: Sean Nyekjaer > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. > > > > Miquel > Hi Miquel > > Will you please queue this for fixes? It's quite relevant for 5.10 LTS :) Right, that will be quicker to have it in Linus' tree. I moved the patch to the mtd/next branch. Cheers, Miquèl