From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6157C433E9 for ; Mon, 4 Jan 2021 18:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98BC82075E for ; Mon, 4 Jan 2021 18:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbhADSTK (ORCPT ); Mon, 4 Jan 2021 13:19:10 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:39292 "EHLO mail-wm1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbhADSTK (ORCPT ); Mon, 4 Jan 2021 13:19:10 -0500 Received: by mail-wm1-f45.google.com with SMTP id 3so127537wmg.4; Mon, 04 Jan 2021 10:18:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y+NTvbLk4IzzMQK1/SZQ7lLpxAYEqAF6MOVXtS7spWg=; b=AsMwAr/K7cyLetQtcPFpqs/NqKQabPftA/pVy0Wiu/KAq4PpwmK4msAZH1aN0QoBXN ZXM7Xj/NFoZISFhjP46zxMksV+YTqZaxappTzgpZFjo+go83E1mEShg4Cy6895gIWdl2 q0kmq81inI8rw9rOPTlQhXEo/PMAs+rIcKr2Ov3a8zyfK5Bg9eY96uV9jdD8WaAm9ORH 9vUsQsAK0htmHmhBHAct6Qbh5DOF6DdHXS9TIlRnBreob3uQafRLMdDYgiI9fXZjTh36 G6EXatwzCzePU5sq+9P7TssECoiW+HrFbpFi7cLPcAfy0YQyLeoQkRTH3HJcNH2qj3iQ +NTQ== X-Gm-Message-State: AOAM533Q57kutc8TeDN7MtU3TUl/n2XCVZDmstjqfK74m0/P1cf6fWCH 9cAS37TiYTowWykSDMxQtSI= X-Google-Smtp-Source: ABdhPJyxaw81/VsDm31di+CjRZDa5b043/h6CfX6p+2JizDxYrVRkfy8Dr09rKnqvDo/5ZkHa0Uyug== X-Received: by 2002:a1c:4483:: with SMTP id r125mr143991wma.80.1609784308269; Mon, 04 Jan 2021 10:18:28 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id x7sm210739wmi.11.2021.01.04.10.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 10:18:27 -0800 (PST) Date: Mon, 4 Jan 2021 19:18:25 +0100 From: Krzysztof Kozlowski To: Mark Brown Cc: Timon Baetz , Marek Szyprowski , Liam Girdwood , Rob Herring , MyungJoo Ham , Chanwoo Choi , Lee Jones , Sebastian Reichel , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210104181825.GB27043@kozik-lap> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> <20210104135156.GB5645@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210104135156.GB5645@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jan 04, 2021 at 01:51:56PM +0000, Mark Brown wrote: > On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote: > > > +- charger: Node for configuring the charger driver. > > + Required properties: > > + - compatible: "maxim,max8997-battery" > > + Optional properties: > > + - extcon: extcon specifier for charging events > > + - charger-supply: regulator node for charging current > > + > > +- muic: Node used only by extcon consumers. > > + Required properties: > > + - compatible: "maxim,max8997-muic" > > Why do these need to appear in the DT binding? We know these features > are there simply from knowing this is a max8997. If you refer to children nodes, then we do not know these entirely because the features could be disabled (pins not connected). In such case these subnodes can be disabled and MFD framework will not instantiate children devices. If you mean "the properties" like extcon or charger, then indeed it's a good question. In theory, wires still could be routed differently, e.g. different charging regulator used as a charger. In practice this is highly unlikely, however such DT design allows easier hooking up of different devices and even potential re-usage of kernel drivers (also unlikely...). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB36C433E0 for ; Mon, 4 Jan 2021 18:19:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5E8821919 for ; Mon, 4 Jan 2021 18:19:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5E8821919 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wyROgKr6qZgu4HqVkdOLFOPIXjlFessOuGJelpE6lgw=; b=IyVeeu4GdRkIdrMs2tY5u/wMG nq5mqiQdrtvdFUOcxTziM4Fi454YPMvyUrG/wA8vnRVESSdaNehmzp1b0nj/itkGhO1LZnvfQfUsR ImS+mpUQ5VGjCGZ4JAcf9v/KjNMFp5DsaZP7x4QtOCPMfWPNQc82BpV2skK3uBC1hiypmuItYuS8w kz8R9LxBU3cJamMSaZUe/dvYBKIzqiRY7C1gLj+EE1USLZjPKQ0B11hHEs6vQ+r1Rhj6VTblZSycJ fB+4/r9YynxpaYMtKmLmhfuGxe44MJ3uquA26hfEJO4sHsJfJyltQ1LIAwVq0DMDP7lK6GnitV7Ys LmMCq0MHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUR5-0003R7-F9; Mon, 04 Jan 2021 18:18:31 +0000 Received: from mail-wm1-f41.google.com ([209.85.128.41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwUR3-0003QB-Fk for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 18:18:30 +0000 Received: by mail-wm1-f41.google.com with SMTP id e25so151533wme.0 for ; Mon, 04 Jan 2021 10:18:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y+NTvbLk4IzzMQK1/SZQ7lLpxAYEqAF6MOVXtS7spWg=; b=ei0MHCM7uWk27vNqah2KCt1gas6sJro+YZS8/PQh7JdzFMC9YCRi1XjiuFEUTtTxCQ szOKQkNSqSP1seEDRsYBxu9QuAVuzI41hKsLbT3QtMa1mCQ559o0X0uhDu+7tu6n8GVL FIe8YDScRMPHPP3fxpfRXqD0CEH64H8EmumgljiECz+ajgMcuRKYQYILyVAfQrL1iPM7 tR5Mke5fAod2DGvdoALFxB33+X3yOgwFQglRuhNlznfEOY6RMlPXGmPXnBrlDeZyzEH8 nmuzCC/xvtWjLgawwst9WDiW2nfHQGTnZ7D08h5LqBMn5fK64LuV6q4/scTFTYrxMZxq vUAQ== X-Gm-Message-State: AOAM530qOOBLizyUq8yO/1Mee9V5KiXu6qEWdVHAn3JGw0Wn7bDzdpbp lS51ycDCMH3+QzRVoGPktAk= X-Google-Smtp-Source: ABdhPJyxaw81/VsDm31di+CjRZDa5b043/h6CfX6p+2JizDxYrVRkfy8Dr09rKnqvDo/5ZkHa0Uyug== X-Received: by 2002:a1c:4483:: with SMTP id r125mr143991wma.80.1609784308269; Mon, 04 Jan 2021 10:18:28 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id x7sm210739wmi.11.2021.01.04.10.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jan 2021 10:18:27 -0800 (PST) Date: Mon, 4 Jan 2021 19:18:25 +0100 From: Krzysztof Kozlowski To: Mark Brown Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Message-ID: <20210104181825.GB27043@kozik-lap> References: <20201230205139.1812366-1-timon.baetz@protonmail.com> <20201230205139.1812366-2-timon.baetz@protonmail.com> <20210104135156.GB5645@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210104135156.GB5645@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_131829_568704_331F313B X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Timon Baetz , Chanwoo Choi , MyungJoo Ham , ~postmarketos/upstreaming@lists.sr.ht, Sebastian Reichel , Lee Jones , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 04, 2021 at 01:51:56PM +0000, Mark Brown wrote: > On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote: > > > +- charger: Node for configuring the charger driver. > > + Required properties: > > + - compatible: "maxim,max8997-battery" > > + Optional properties: > > + - extcon: extcon specifier for charging events > > + - charger-supply: regulator node for charging current > > + > > +- muic: Node used only by extcon consumers. > > + Required properties: > > + - compatible: "maxim,max8997-muic" > > Why do these need to appear in the DT binding? We know these features > are there simply from knowing this is a max8997. If you refer to children nodes, then we do not know these entirely because the features could be disabled (pins not connected). In such case these subnodes can be disabled and MFD framework will not instantiate children devices. If you mean "the properties" like extcon or charger, then indeed it's a good question. In theory, wires still could be routed differently, e.g. different charging regulator used as a charger. In practice this is highly unlikely, however such DT design allows easier hooking up of different devices and even potential re-usage of kernel drivers (also unlikely...). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel