From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
shuah@kernel.org
Subject: Re: [PATCH] selftests/ftrace: Disable multiple_kprobes test on powerpc
Date: Tue, 5 Jan 2021 23:41:37 +0900 [thread overview]
Message-ID: <20210105234137.d412b08f1b0bc07600dac978@kernel.org> (raw)
In-Reply-To: <1609841373.5sgt2b2ism.naveen@linux.ibm.com>
On Tue, 05 Jan 2021 15:42:44 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> Masami Hiramatsu wrote:
> > On Tue, 5 Jan 2021 12:27:30 +0530
> > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> >
> >> Not all symbols are blacklisted on powerpc. Disable multiple_kprobes
> >> test until that is sorted, so that rest of ftrace and kprobe selftests
> >> can be run.
> >
> > This looks good to me, but could you try to find the functions
> > which should be blocked from kprobes?
> > (Usually, the function which are involved in the sw-breakpoint
> > handling, including locks etc.)
>
> Yes, we did add several blacklists some time back, but there has been
> quite a bit of churn in our entry code. I've been meaning to audit it
> for a while now, but this has been blocking tests. It would be nice to
> skip this test for now until I am able to spend some time on this.
OK, But for revisiting this testcase in the future, I think it should
return UNTESTED instead of UNSUPPORTED.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-01-05 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 6:57 [PATCH] selftests/ftrace: Disable multiple_kprobes test on powerpc Naveen N. Rao
2021-01-05 10:01 ` Masami Hiramatsu
2021-01-05 10:12 ` Naveen N. Rao
2021-01-05 14:41 ` Masami Hiramatsu [this message]
2021-01-05 10:15 ` Masami Hiramatsu
2021-01-05 11:21 ` Naveen N. Rao
2021-01-05 14:33 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105234137.d412b08f1b0bc07600dac978@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.