From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/kprobes: Do the notrace functions check without kprobes on ftrace
Date: Wed, 6 Jan 2021 09:56:14 -0500 [thread overview]
Message-ID: <20210106095614.4ca3f166@gandalf.local.home> (raw)
In-Reply-To: <160990323982.16047.9136060149082849917.stgit@devnote2>
On Wed, 6 Jan 2021 12:20:40 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Enable the notrace function check on the architecture which doesn't
> support kprobes on ftrace. This notrace function check is not only
> for the kprobes on ftrace but also sw-breakpoint based kprobes.
> Thus there is no reason to limit this check for the arch which
> supports kprobes on ftrace.
>
> This also changes the dependency of Kconfig. Because kprobe event
> uses the function tracer's address list for identifying notrace
> function, if the CONFIG_FUNCTION_TRACER=n, it can not check whether
> the target function is notrace or not.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>
Thanks Masami,
I queued this up for testing, and will mark it for stable. I know it's a
minor fix, but it also shouldn't have much risk either.
-- Steve
next prev parent reply other threads:[~2021-01-06 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 3:20 [PATCH] tracing/kprobes: Do the notrace functions check without kprobes on ftrace Masami Hiramatsu
2021-01-06 14:56 ` Steven Rostedt [this message]
2021-01-07 14:13 ` Steven Rostedt
2021-01-08 4:19 ` Masami Hiramatsu
-- strict thread matches above, loose matches on Subject: below --
2021-01-14 2:36 ChunyouTang
2021-01-14 3:13 ` Steven Rostedt
2021-01-14 2:51 ChunyouTang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106095614.4ca3f166@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.