From: Olivier Matz <olivier.matz@6wind.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
Date: Thu, 7 Jan 2021 08:49:12 +0100 [thread overview]
Message-ID: <20210107074912.GL2631@platinum> (raw)
In-Reply-To: <20210107013114.3477-1-ashish.sadanandan@gmail.com>
On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote:
> The header was missing the extern "C" directive which causes name
> mangling of functions by C++ compilers, leading to linker errors
> complaining of undefined references to these functions.
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
>
> Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48
I think this line can be dropped (it comes from gerrit).
David, can you do it when pushing the patch?
> Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks!
next prev parent reply other threads:[~2021-01-07 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 1:31 [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 7:49 ` Olivier Matz [this message]
2021-01-11 14:41 ` David Marchand
-- strict thread matches above, loose matches on Subject: below --
2020-12-29 19:41 [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107074912.GL2631@platinum \
--to=olivier.matz@6wind.com \
--cc=ashish.sadanandan@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.