All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Nault <gnault@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] tc: flower: fix json output with mpls lse
Date: Thu, 7 Jan 2021 17:48:56 +0100	[thread overview]
Message-ID: <20210107164856.GC17363@linux.home> (raw)
In-Reply-To: <1ef12e7d378d5b1dad4f056a2225d5ae9d5326cb.1608330201.git.gnault@redhat.com>

On Fri, Dec 18, 2020 at 11:25:32PM +0100, Guillaume Nault wrote:
> The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute was invalid.
> 
> Example:
> 
>   $ tc filter add dev eth0 ingress protocol mpls_uc flower mpls \
>       lse depth 1 label 100                                     \
>       lse depth 2 label 200
> 
>   $ tc -json filter show dev eth0 ingress
>     ...{"eth_type":"8847",
>         "  mpls":["    lse":["depth":1,"label":100],
>                   "    lse":["depth":2,"label":200]]}...

Is there any problem with this patch?
It's archived in patchwork, but still in state "new". Therefore I guess
it was dropped before being considered for review.

This problem precludes the implementation of a kernel selftest for
TCA_FLOWER_KEY_MPLS_OPTS.

Just let me know if I should respin.

Thanks,

William


  reply	other threads:[~2021-01-07 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 22:25 [PATCH iproute2] tc: flower: fix json output with mpls lse Guillaume Nault
2021-01-07 16:48 ` Guillaume Nault [this message]
2021-01-07 17:13   ` Jakub Kicinski
2021-01-07 17:39     ` David Ahern
2021-01-11 10:57       ` Guillaume Nault
2021-01-11 15:30         ` David Ahern
2021-01-11 15:44           ` Guillaume Nault
2021-01-11 16:02             ` David Ahern
2021-01-11 16:06               ` Guillaume Nault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107164856.GC17363@linux.home \
    --to=gnault@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.