From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: lll <liyonglong@chinatelecom.cn>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, davem@davemloft.net, fw@strlen.de,
soheil@google.com, ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH] tcp: remove obsolete paramter sysctl_tcp_low_latency
Date: Thu, 7 Jan 2021 18:45:38 +0100 [thread overview]
Message-ID: <20210107174538.GA19605@breakpoint.cc> (raw)
In-Reply-To: <20210107090635.440b1fc6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> wrote:
> > Got it. But a question: why tcp_tw_recycle can be removed totally?
> > it is also part of uAPI
>
> Good question, perhaps with tcp_tw_recycle we wanted to make sure users
> who depended on it notice removal, since the feature was broken by
> design?
>
> tcp_low_latency is an optimization, not functionality which users may
> depend on.
>
> But I may be wrong so CCing authors.
I guess it was just a case of 'noone noticed'.
I'm not sure if anyone would notice dropping lowlatency sysctl, was just
a case of 'overly careful'. Personally I'd rather have them gone so
'sysctl tcp.bla' shows if the feature exists/does something.
prev parent reply other threads:[~2021-01-07 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 6:11 [PATCH] tcp: remove obsolete paramter sysctl_tcp_low_latency lyl
2020-12-19 0:46 ` Jakub Kicinski
2021-01-07 3:08 ` lll
2021-01-07 17:06 ` Jakub Kicinski
2021-01-07 17:45 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107174538.GA19605@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liyonglong@chinatelecom.cn \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.