From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Machata <petrm@nvidia.com>
Cc: Roi Dayan <roid@nvidia.com>, <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2 v2 1/1] build: Fix link errors on some systems
Date: Fri, 8 Jan 2021 08:18:06 -0800 [thread overview]
Message-ID: <20210108081806.2219efda@hermes.local> (raw)
In-Reply-To: <875z478tjq.fsf@nvidia.com>
On Fri, 8 Jan 2021 14:08:57 +0100
Petr Machata <petrm@nvidia.com> wrote:
> Stephen Hemminger <stephen@networkplumber.org> writes:
>
> > On Thu, 7 Jan 2021 09:13:34 +0200
> > Roi Dayan <roid@nvidia.com> wrote:
> >
> >> +#define _IS_JSON_CONTEXT(type) ((type & PRINT_JSON || type & PRINT_ANY) && is_json_context())
> >> +#define _IS_FP_CONTEXT(type) (!is_json_context() && (type & PRINT_FP || type & PRINT_ANY))
> >
> > You could fold the comparisons? and why are the two options doing comparison in different order?
> >
> > #define _IS_JSON_CONTEXT(type) (is_json_context() && (type & (PRINT_JSON | PRINT_ANY))
> > #define _IS_FP_CONTEXT(type) (!is_json_context() && (type & (PRINT_FP || PRINT_ANY))
>
> (s/||/|/)
Agree.
This was just an email edit, never tried
prev parent reply other threads:[~2021-01-08 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 7:13 [PATCH iproute2 v2 1/1] build: Fix link errors on some systems Roi Dayan
2021-01-07 16:26 ` Stephen Hemminger
2021-01-08 13:08 ` Petr Machata
2021-01-08 16:18 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108081806.2219efda@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=roid@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.