All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <hzpeterchen@gmail.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	John Youn <John.Youn@synopsys.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 0/2] usb: dwc3: gadget: Check for multiple start/stop
Date: Fri, 8 Jan 2021 17:40:16 +0800	[thread overview]
Message-ID: <20210108094016.GA13606@b29397-desktop> (raw)
In-Reply-To: <93173de2-4ba0-52ab-1453-da5535c70ace@synopsys.com>

On 21-01-08 02:40:55, Thinh Nguyen wrote:
> Hi Peter,
> 
> Peter Chen wrote:
> > On 21-01-05 08:56:28, Thinh Nguyen wrote:
> >> Add some checks to avoid going through the start/stop sequence if the gadget
> >> had already started/stopped. This series base-commit is Greg's usb-linus
> >> branch.
> >>
> > Hi Thinh,
> >
> > What's the sequence your could reproduce it?
> >
> > Peter
> 
> You can test as follow:
> 
> # echo connect > /sys/class/udc/<UDC>/soft_connect
> # echo connect > /sys/class/udc/<UDC>/soft_connect
> 
> and
> 
> # echo disconnect > /sys/class/udc/<UDC>/soft_connect
> # echo disconnect > /sys/class/udc/<UDC>/soft_connect
> 
> Thinh
> 

Thanks, now I reproduce the issue. Another improvement you
might consider adding is checking return value for usb_gadget_udc_start
at soft_connect_store.

-- 

Thanks,
Peter Chen


      reply	other threads:[~2021-01-08  9:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 16:56 [PATCH 0/2] usb: dwc3: gadget: Check for multiple start/stop Thinh Nguyen
2021-01-05 16:56 ` [PATCH 1/2] usb: dwc3: gadget: Check if the gadget had started Thinh Nguyen
2021-01-06  7:53   ` Felipe Balbi
2021-01-06  9:35     ` Thinh Nguyen
2021-01-05 16:56 ` [PATCH 2/2] usb: dwc3: gadget: Check if the gadget had stopped Thinh Nguyen
2021-01-06  7:54   ` Felipe Balbi
2021-01-08  2:36 ` [PATCH 0/2] usb: dwc3: gadget: Check for multiple start/stop Peter Chen
2021-01-08  2:40   ` Thinh Nguyen
2021-01-08  9:40     ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210108094016.GA13606@b29397-desktop \
    --to=hzpeterchen@gmail.com \
    --cc=John.Youn@synopsys.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.