From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxoui-0005JH-0w for kexec@lists.infradead.org; Fri, 08 Jan 2021 10:22:36 +0000 Date: Fri, 8 Jan 2021 18:22:24 +0800 From: Baoquan He Subject: Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO Message-ID: <20210108102224.GC4959@MiWiFi-R3L-srv> References: <20200930102328.396488-1-egorenar@linux.ibm.com> <20210108033248.GA4959@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: HAGIO =?utf-8?B?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKQ==?= Cc: "lijiang@redhat.com" , "gregkh@linuxfoundation.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Alexander Egorenkov , "ktkhai@virtuozzo.com" , "ebiederm@xmission.com" , "akpm@linux-foundation.org" , "dyoung@redhat.com" , "christian.brauner@ubuntu.com" , "vgoyal@redhat.com" , "keescook@chromium.org" T24gMDEvMDgvMjEgYXQgMTA6MDdhbSwgSEFHSU8gS0FaVUhJVE8o6JCp5bC+IOS4gOS7gSkgd3Jv dGU6Cj4gSGkgQmFvcXVhbiwKPiAKPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gT24g MDkvMzAvMjAgYXQgMTI6MjNwbSwgQWxleGFuZGVyIEVnb3JlbmtvdiB3cm90ZToKPiA+ID4gVGhl IG9mZnNldCBvZiB0aGUgZmllbGQgJ2luaXRfdXRzX25zLm5hbWUnIGhhcyBjaGFuZ2VkCj4gPiA+ IHNpbmNlIGNvbW1pdCA5YTU2NDkzZjY5NDIgKCJ1dHM6IFVzZSBnZW5lcmljIG5zX2NvbW1vbjo6 Y291bnQiKS4KPiA+IAo+ID4gVGhpcyBwYXRjaCBpcyBtZXJnZWQgaW50byA1LjExLXJjMSwgYnV0 IHdlIG1ldCB0aGUgbWFrZWR1bXBmaWxlIGZhaWx1cmUKPiA+IG9mIGtkdW1wIHRlc3QgY2FzZSBp biA1LjEwLjAga2VybmVsLiBTaG91bGQgYWZmZWN0IDUuOSB0b28gc2luY2UKPiA+IGNvbW1pdCA5 YTU2NDkzZjY5NDIgaXMgbWVyZ2VkIGludG8gNS45LXJjMi4KPiAKPiBIbW0sIGNvbW1pdCA5YTU2 NDkzZjY5NDIgc2hvdWxkIGhhdmUgYmVlbiBtZXJnZWQgaW50byA1LjExLXJjMQo+IHRvZ2V0aGVy IHdpdGggY29tbWl0IGNhNGE5MjQxY2M1ZS4KCkNoZWNrZWQgb24gbWFzdGVyIGJyYW5jaCBvZiBt YWlubGluZSBrZXJuZWwsIGNvbW1pdCA5YTU2NDkzZjY5NDIgaXMgaW4KNS45LXJjMS4gY29tbWl0 IGNhNGE5MjQxY2M1ZSBpcyBtZXJnZWQgaW50byA1LjExLXJjMS4KCmNvbW1pdCA5YTU2NDkzZjY5 NDJjMGUyZGYxNTc5OTg2MTI4NzIxZGE5NmUwMGQ4CkF1dGhvcjogS2lyaWxsIFRraGFpIDxrdGto YWlAdmlydHVvenpvLmNvbT4KRGF0ZTogICBNb24gQXVnIDMgMTM6MTY6MjEgMjAyMCArMDMwMAoK ICAgIHV0czogVXNlIGdlbmVyaWMgbnNfY29tbW9uOjpjb3VudAoKCmNvbW1pdCBjYTRhOTI0MWNj NWU3MThkZTg2YTM0YWZkNDE5NzI4Njk1NDZhNWUzCkF1dGhvcjogQWxleGFuZGVyIEVnb3Jlbmtv diA8ZWdvcmVuYXJAbGludXguaWJtLmNvbT4KRGF0ZTogICBUdWUgRGVjIDE1IDIwOjQ1OjMxIDIw MjAgLTA4MDAKCiAgICBrZHVtcDogYXBwZW5kIHV0c19uYW1lc3BhY2UubmFtZSBvZmZzZXQgdG8g Vk1DT1JFSU5GTwoKCj4gCj4gRG9lcyB5b3VyIG1ha2VkdW1wZmlsZSBoYXZlIHRoZSBmb2xsb3dp bmcgcGF0Y2g/Cj4gaHR0cHM6Ly9naXRodWIuY29tL21ha2VkdW1wZmlsZS9tYWtlZHVtcGZpbGUv Y29tbWl0LzU0YWVjMzg3OGIzZjkxMzQxZTZiYzczNWVkYTE1OGNjYTVjNTRlYzkKCldlIG1ldCB0 aGlzIGlzc3VlIG9uIDUuMTAga2VybmVsLCB0aGUgbGF0ZXN0IG1ha2VkdW1wZmlsZSAxLjYuOCsg Zml4cwppdC4gTWFrZWR1bXBmaWxlIDEuNi44KyBpbmNsdWRlcyB0aGUgY29tbWl0IDU0YWVjMzg3 OGIzZi4gTm90IHN1cmUgaWYgSQpnb3QgdGhlIGtlcm5lbCBjb21taXQgcmlnaHQgaW4gdGhlaXIg Y29ycmVzcG9uZGluZyByZWxlYXNlLgoKVGhhbmtzCkJhb3F1YW4KCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407E5C433DB for ; Fri, 8 Jan 2021 10:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0222623770 for ; Fri, 8 Jan 2021 10:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727410AbhAHKYD (ORCPT ); Fri, 8 Jan 2021 05:24:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23564 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbhAHKYC (ORCPT ); Fri, 8 Jan 2021 05:24:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610101356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JPlcFGEh/ksvh5rQy00+1PndahkVcKk0pnC2uSmTiXA=; b=KgqYv6CbG8rH/skd3K9GUX4ceuf5MjXvWcR7YF6bbIzEonMTMotDJJfSnCIGbBa1N/iRUO iWg/CE9jFO5AQGw9kgug976QwwAEobAK3EcfWXwHGjtWRdylsFaiFn0kD6A+3JzIzSdihS Ut3vELFkbvUSwQ3rmnRWnFDh072eilk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-l8HwyW46Nu2chPyhXUk0JQ-1; Fri, 08 Jan 2021 05:22:32 -0500 X-MC-Unique: l8HwyW46Nu2chPyhXUk0JQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AF12612A0; Fri, 8 Jan 2021 10:22:31 +0000 (UTC) Received: from localhost (ovpn-12-180.pek2.redhat.com [10.72.12.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5B4960C5F; Fri, 8 Jan 2021 10:22:26 +0000 (UTC) Date: Fri, 8 Jan 2021 18:22:24 +0800 From: Baoquan He To: HAGIO =?utf-8?B?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKQ==?= Cc: "gregkh@linuxfoundation.org" , "lijiang@redhat.com" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "ktkhai@virtuozzo.com" , "ebiederm@xmission.com" , "akpm@linux-foundation.org" , "dyoung@redhat.com" , "christian.brauner@ubuntu.com" , "vgoyal@redhat.com" , "keescook@chromium.org" , Alexander Egorenkov Subject: Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO Message-ID: <20210108102224.GC4959@MiWiFi-R3L-srv> References: <20200930102328.396488-1-egorenar@linux.ibm.com> <20210108033248.GA4959@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/21 at 10:07am, HAGIO KAZUHITO(萩尾 一仁) wrote: > Hi Baoquan, > > -----Original Message----- > > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote: > > > The offset of the field 'init_uts_ns.name' has changed > > > since commit 9a56493f6942 ("uts: Use generic ns_common::count"). > > > > This patch is merged into 5.11-rc1, but we met the makedumpfile failure > > of kdump test case in 5.10.0 kernel. Should affect 5.9 too since > > commit 9a56493f6942 is merged into 5.9-rc2. > > Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1 > together with commit ca4a9241cc5e. Checked on master branch of mainline kernel, commit 9a56493f6942 is in 5.9-rc1. commit ca4a9241cc5e is merged into 5.11-rc1. commit 9a56493f6942c0e2df1579986128721da96e00d8 Author: Kirill Tkhai Date: Mon Aug 3 13:16:21 2020 +0300 uts: Use generic ns_common::count commit ca4a9241cc5e718de86a34afd41972869546a5e3 Author: Alexander Egorenkov Date: Tue Dec 15 20:45:31 2020 -0800 kdump: append uts_namespace.name offset to VMCOREINFO > > Does your makedumpfile have the following patch? > https://github.com/makedumpfile/makedumpfile/commit/54aec3878b3f91341e6bc735eda158cca5c54ec9 We met this issue on 5.10 kernel, the latest makedumpfile 1.6.8+ fixs it. Makedumpfile 1.6.8+ includes the commit 54aec3878b3f. Not sure if I got the kernel commit right in their corresponding release. Thanks Baoquan