From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57498C433DB for ; Fri, 8 Jan 2021 12:09:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E98FD2388B for ; Fri, 8 Jan 2021 12:09:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E98FD2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pXGqd+1Dz3tfW9No4DjQlL615WPN4kTIbwrWkapdCb0=; b=X3jjRFdRtF/dg41RHb8m89pxg Uu9ZLP4ABAR8MX1HSxZa9lXyljnAMmm9veR13HVBH4VklEWeceKOlJ2RvgUVsaLFcqFYVWd2g6M4L tUOZsFREnllry7nSEAv7GDI5XnKzRRrEaPI60eibmkg68KyZJctaulQGUm0eLNKfcVzMKruR1qnL7 cg658dmcFjH8obFR00ouaPXwj7sF98/TqpxyliaPkkZT/qR+ly078/I3zngK2pUjvh8rBE7SXlo0d kbUh9/pvGbEStAUit3g7/xbgumXPV1UtcWmvsXkqNiUu9zyCx5hR2SP0BpYPxGHUU5wfvAYsyidun 50h6w9zRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqVq-0002G0-LZ; Fri, 08 Jan 2021 12:05:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqVQ-0002Ej-77 for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 12:04:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B258431B; Fri, 8 Jan 2021 04:04:33 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D95ED3F719; Fri, 8 Jan 2021 04:04:31 -0800 (PST) Date: Fri, 8 Jan 2021 12:04:28 +0000 From: Cristian Marussi To: Thara Gopinath Subject: Re: [PATCH v4 02/37] firmware: arm_scmi: introduce protocol handle definitions Message-ID: <20210108120428.GB9138@e120937-lin> References: <20210106201610.26538-1-cristian.marussi@arm.com> <20210106201610.26538-3-cristian.marussi@arm.com> <19054e89-c117-ef85-444e-8e126a8a9efb@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19054e89-c117-ef85-444e-8e126a8a9efb@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_070436_408740_D79929AB X-CRM114-Status: GOOD ( 32.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, vincent.guittot@linaro.org, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com, etienne.carriere@linaro.org, lukasz.luba@arm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVGhhcmEKCnRoYW5rcyBmb3IgcmV2aWV3aW5nLgoKT24gVGh1LCBKYW4gMDcsIDIwMjEgYXQg MDk6Mjk6MTdBTSAtMDUwMCwgVGhhcmEgR29waW5hdGggd3JvdGU6Cj4gCj4gCj4gT24gMS82LzIx IDM6MTUgUE0sIENyaXN0aWFuIE1hcnVzc2kgd3JvdGU6Cj4gPiBBZGQgYmFzaWMgcHJvdG9jb2wg aGFuZGxlcyBkZWZpbml0aW9ucyBhbmQgcHJpdmF0ZSBkYXRhIGhlbHBlcnMgc3VwcG9ydC4KPiA+ IAo+ID4gQSBwcm90b2NvbCBoYW5kbGUgaWRlbnRpZmllcyBhIHByb3RvY29sIGluc3RhbmNlIGlu aXRpYWxpemVkIGFnYWluc3QgYQo+ID4gc3BlY2lmaWMgaGFuZGxlOyBpdCBlbWJlZHMgYWxsIHRo ZSByZWZlcmVuY2VzIHRvIHRoZSBjb3JlIFNDTUkgeGZlciBtZXRob2RzCj4gPiB0aGF0IHdpbGwg YmUgbmVlZGVkIGJ5IGEgcHJvdG9jb2wgaW1wbGVtZW50YXRpb24gdG8gYnVpbGQgYW5kIHNlbmQg aXRzIG93bgo+ID4gcHJvdG9jb2wgc3BlY2lmaWMgbWVzc2FnZXMgdXNpbmcgY29tbW9uIGNvcmUg bWV0aG9kcy4KPiA+IAo+ID4gQXMgc3VjaCwgaW4gdGhlIGludGVyZmFjZSwgYSBwcm90b2NvbCBo YW5kbGUgd2lsbCBiZSBwYXNzZWQgZG93biBmcm9tIHRoZQo+ID4gY29yZSB0byB0aGUgcHJvdG9j b2wgc3BlY2lmaWMgaW5pdGlhbGl6YXRpb24gY2FsbGJhY2sgYXQgaW5pdCB0aW1lLgo+ID4gCj4g PiBBbnl3YXkgYXQgdGhpcyBwb2ludCBvbmx5IGRlZmluaXRpb25zIGFyZSBpbnRyb2R1Y2VkLCBh bGwgcHJvdG9jb2xzCj4gPiBpbml0aWFsaXphdGlvbiBjb2RlIGFuZCBTQ01JIGRyaXZlcnMgcHJv YmluZyBpcyBzdGlsbCBiYXNlZCBvbiB0aGUgb2xkCj4gPiBpbnRlcmZhY2UsIHNvIG5vIGZ1bmN0 aW9uYWwgY2hhbmdlLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBDcmlzdGlhbiBNYXJ1c3NpIDxj cmlzdGlhbi5tYXJ1c3NpQGFybS5jb20+Cj4gPiAtLS0KPiA+ICAgZHJpdmVycy9maXJtd2FyZS9h cm1fc2NtaS9jb21tb24uaCB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4g ICBkcml2ZXJzL2Zpcm13YXJlL2FybV9zY21pL2RyaXZlci5jIHwgNDUgKysrKysrKysrKysrKysr KysrKysrKysKPiA+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMDQgaW5zZXJ0aW9ucygrKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9jb21tb24uaCBiL2RyaXZl cnMvZmlybXdhcmUvYXJtX3NjbWkvY29tbW9uLmgKPiA+IGluZGV4IGUwNTI1MDdkYzkxOC4uOTc3 ZTMxMjI0ZWZlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9jb21t b24uaAo+ID4gKysrIGIvZHJpdmVycy9maXJtd2FyZS9hcm1fc2NtaS9jb21tb24uaAo+ID4gQEAg LTE0OSw2ICsxNDksNjUgQEAgaW50IHNjbWlfeGZlcl9nZXRfaW5pdChjb25zdCBzdHJ1Y3Qgc2Nt aV9oYW5kbGUgKmgsIHU4IG1zZ19pZCwgdTggcHJvdF9pZCwKPiA+ICAgCQkgICAgICAgc2l6ZV90 IHR4X3NpemUsIHNpemVfdCByeF9zaXplLCBzdHJ1Y3Qgc2NtaV94ZmVyICoqcCk7Cj4gPiAgIHZv aWQgc2NtaV9yZXNldF9yeF90b19tYXhzeihjb25zdCBzdHJ1Y3Qgc2NtaV9oYW5kbGUgKmhhbmRs ZSwKPiA+ICAgCQkJICAgIHN0cnVjdCBzY21pX3hmZXIgKnhmZXIpOwo+ID4gKwo+ID4gK3N0cnVj dCBzY21pX3hmZXJfb3BzOwo+ID4gKwo+ID4gKy8qKgo+ID4gKyAqIHN0cnVjdCBzY21pX3Byb3Rv Y29sX2hhbmRsZSAgLSBSZWZlcmVuY2UgdG8gYW4gaW5pdGlhbGl6ZWQgcHJvdG9jb2wgaW5zdGFu Y2UKPiA+ICsgKgo+ID4gKyAqIEBkZXY6IEEgcmVmZXJlbmNlIHRvIHRoZSBhc3NvY2lhdGVkIFND TUkgaW5zdGFuY2UgZGV2aWNlIChoYW5kbGUtPmRldikuCj4gPiArICogQHhvcHM6IEEgcmVmZXJl bmNlIHRvIGEgc3RydWN0IGhvbGRpbmcgcmVmcyB0byB0aGUgY29yZSB4ZmVyIG9wZXJhdGlvbnMg dGhhdAo+ID4gKyAqCSAgY2FuIGJlIHVzZWQgYnkgdGhlIHByb3RvY29sIGltcGxlbWVudGF0aW9u IHRvIGdlbmVyYXRlIFNDTUkgbWVzc2FnZXMuCj4gPiArICogQHNldF9wcml2OiBBIG1ldGhvZCB0 byBzZXQgcHJvdG9jb2wgcHJpdmF0ZSBkYXRhIGZvciB0aGlzIGluc3RhbmNlLgo+ID4gKyAqIEBn ZXRfcHJpdjogQSBtZXRob2QgdG8gZ2V0IHByb3RvY29sIHByaXZhdGUgZGF0YSBwcmV2aW91c2x5 IHNldC4KPiA+ICsgKgo+ID4gKyAqIFRoaXMgc3RydWN0dXJlIHJlcHJlc2VudHMgYSBwcm90b2Nv bCBpbml0aWFsaXplZCBhZ2FpbnN0IHNwZWNpZmljIFNDTUkKPiA+ICsgKiBpbnN0YW5jZSBhbmQg aXQgd2lsbCBiZSB1c2VkIGFzIGZvbGxvd3M6Cj4gPiArICogLSBhcyBhIHBhcmFtZXRlciBmZWQg ZnJvbSB0aGUgY29yZSB0byB0aGUgcHJvdG9jb2wgaW5pdGlhbGl6YXRpb24gY29kZSBzbwo+ID4g KyAqICAgdGhhdCBpdCBjYW4gYWNjZXNzIHRoZSBjb3JlIHhmZXIgb3BlcmF0aW9ucyB0byBidWls ZCBhbmQgZ2VuZXJhdGUgU0NNSQo+ID4gKyAqICAgbWVzc2FnZXMgZXhjbHVzaXZlbHkgZm9yIHRo ZSBzcGVjaWZpYyB1bmRlcmx5aW5nIHByb3RvY29sIGluc3RhbmNlLgo+ID4gKyAqIC0gYXMgYW4g b3BhcXVlIGhhbmRsZSBmZWQgYnkgYW4gU0NNSSBkcml2ZXIgdXNlciB3aGVuIGl0IHRyaWVzIHRv IGFjY2Vzcwo+ID4gKyAqICAgdGhpcyBwcm90b2NvbCB0aHJvdWdoIGl0cyBvd24gcHJvdG9jb2wg b3BlcmF0aW9ucy4KPiA+ICsgKiAgIEluIHRoaXMgY2FzZSB0aGlzIGhhbmRsZSB3aWxsIGJlIHJl dHVybmVkIGFzIGFuIG9wYXF1ZSBvYmplY3QgdG9nZXRoZXIKPiA+ICsgKiAgIHdpdGggdGhlIHJl bGF0ZWQgcHJvdG9jb2wgb3BlcmF0aW9ucyB3aGVuIHRoZSBTQ01JIGRyaXZlciB0cmllcyB0byBh Y2Nlc3MKPiA+ICsgKiAgIHRoZSBwcm90b2NvbC4KPiA+ICsgKi8KPiA+ICtzdHJ1Y3Qgc2NtaV9w cm90b2NvbF9oYW5kbGUgewo+ID4gKwlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gPiArCWNvbnN0IHN0 cnVjdCBzY21pX3hmZXJfb3BzICp4b3BzOwo+ID4gKwlpbnQgKCpzZXRfcHJpdikoY29uc3Qgc3Ry dWN0IHNjbWlfcHJvdG9jb2xfaGFuZGxlICpwaCwgdm9pZCAqcHJpdik7Cj4gPiArCXZvaWQgKigq Z2V0X3ByaXYpKGNvbnN0IHN0cnVjdCBzY21pX3Byb3RvY29sX2hhbmRsZSAqcGgpOwo+ID4gK307 Cj4gPiArCj4gPiArLyoqCj4gPiArICogc3RydWN0IHNjbWlfeGZlcl9vcHMgIC0gUmVmZXJlbmNl cyB0byB0aGUgY29yZSBTQ01JIHhmZXIgb3BlcmF0aW9ucy4KPiA+ICsgKiBAdmVyc2lvbl9nZXQ6 IEdldCB0aGlzIHZlcnNpb24gcHJvdG9jb2wuCj4gPiArICogQHhmZXJfZ2V0X2luaXQ6IEluaXRp YWxpemUgb25lIHN0cnVjdCB4ZmVyIGlmIGFueSB4ZmVyIHNsb3QgaXMgZnJlZS4KPiA+ICsgKiBA cmVzZXRfcnhfdG9fbWF4c3o6IFJlc2V0IHJ4IHNpemUgdG8gbWF4IHRyYW5zcG9ydCBzaXplLgo+ ID4gKyAqIEBkb194ZmVyOiBEbyB0aGUgU0NNSSB0cmFuc2Zlci4KPiA+ICsgKiBAZG9feGZlcl93 aXRoX3Jlc3BvbnNlOiBEbyB0aGUgU0NNSSB0cmFuc2ZlciB3YWl0aW5nIGZvciBhIHJlc3BvbnNl Lgo+ID4gKyAqIEB4ZmVyX3B1dDogRnJlZSB0aGUgeGZlciBzbG90Lgo+ID4gKyAqCj4gPiArICog Tm90ZSB0aGF0IGFsbCB0aGlzIG9wZXJhdGlvbnMgZXhwZWN0IGEgcHJvdG9jb2wgaGFuZGxlIGFz IGZpcnN0IHBhcmFtZXRlcjsKPiA+ICsgKiB0aGV5IHRoZW4gaW50ZXJuYWxseSB1c2UgaXQgdG8g aW5mZXIgdGhlIHVuZGVybHlpbmcgcHJvdG9jb2wgbnVtYmVyOiB0aGlzCj4gPiArICogd2F5IGlz IG5vdCBwb3NzaWJsZSBmb3IgYSBwcm90b2NvbCBpbXBsZW1lbnRhdGlvbiB0byBmb3JnZSBtZXNz YWdlcyBmb3IKPiA+ICsgKiBhbm90aGVyIHByb3RvY29sLgo+ID4gKyAqLwo+ID4gK3N0cnVjdCBz Y21pX3hmZXJfb3BzIHsKPiAKPiBNYXliZSBtb3ZlIHRoZSBkZWZpbml0aW9uIGFib3ZlIHN0cnVj dCBzY21pX3Byb3RvY29sX2hhbmRsZSB0byBhdm9pZCBhCj4gZGVjbGFyYXRpb24gPwo+IAoKQnV0 IGFsbCB0aGUgb3BzIGRlZmluZWQgaW5zaWRlIHNjbWlfeGZlcl9vcHMgcmVmZXJzIHRoZW4gdG8g YSBwYXJhbQpzdHJ1Y3Qgc2NtaV9wcm90b2NvbF9oYW5kbGUsIHNvIEknZCBuZWVkIGFueXdheSBh IHNpbWlsYXIgZGVjbGFyYXRpb24KdGhlIG90aGVyIHdheSBhcm91bmQuCgpJZiBub3Q6CgpsaW51 eC9kcml2ZXJzL2Zpcm13YXJlL2FybV9zY21pL2NvbW1vbi5oOjE3ODozMjogd2FybmluZzog4oCY c3RydWN0IHNjbWlfcHJvdG9jb2xfaGFuZGxl4oCZIGRlY2xhcmVkIGluc2lkZSBwYXJhbWV0ZXIg bGlzdCB3aWxsIG5vdCBiZSB2aXNpYmxlIG91dHNpZGUgb2YgdGhpcyBkZWZpbml0aW9uIG9yIGRl Y2xhcmF0aW9uCgpUaGFua3MKCkNyaXN0aWFuCj4gCj4gLS0gCj4gV2FybSBSZWdhcmRzCj4gVGhh cmEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460DCC433DB for ; Fri, 8 Jan 2021 12:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E633123A33 for ; Fri, 8 Jan 2021 12:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbhAHMFU (ORCPT ); Fri, 8 Jan 2021 07:05:20 -0500 Received: from foss.arm.com ([217.140.110.172]:49854 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbhAHMFT (ORCPT ); Fri, 8 Jan 2021 07:05:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B258431B; Fri, 8 Jan 2021 04:04:33 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D95ED3F719; Fri, 8 Jan 2021 04:04:31 -0800 (PST) Date: Fri, 8 Jan 2021 12:04:28 +0000 From: Cristian Marussi To: Thara Gopinath Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com Subject: Re: [PATCH v4 02/37] firmware: arm_scmi: introduce protocol handle definitions Message-ID: <20210108120428.GB9138@e120937-lin> References: <20210106201610.26538-1-cristian.marussi@arm.com> <20210106201610.26538-3-cristian.marussi@arm.com> <19054e89-c117-ef85-444e-8e126a8a9efb@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19054e89-c117-ef85-444e-8e126a8a9efb@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thara thanks for reviewing. On Thu, Jan 07, 2021 at 09:29:17AM -0500, Thara Gopinath wrote: > > > On 1/6/21 3:15 PM, Cristian Marussi wrote: > > Add basic protocol handles definitions and private data helpers support. > > > > A protocol handle identifies a protocol instance initialized against a > > specific handle; it embeds all the references to the core SCMI xfer methods > > that will be needed by a protocol implementation to build and send its own > > protocol specific messages using common core methods. > > > > As such, in the interface, a protocol handle will be passed down from the > > core to the protocol specific initialization callback at init time. > > > > Anyway at this point only definitions are introduced, all protocols > > initialization code and SCMI drivers probing is still based on the old > > interface, so no functional change. > > > > Signed-off-by: Cristian Marussi > > --- > > drivers/firmware/arm_scmi/common.h | 59 ++++++++++++++++++++++++++++++ > > drivers/firmware/arm_scmi/driver.c | 45 +++++++++++++++++++++++ > > 2 files changed, 104 insertions(+) > > > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > > index e052507dc918..977e31224efe 100644 > > --- a/drivers/firmware/arm_scmi/common.h > > +++ b/drivers/firmware/arm_scmi/common.h > > @@ -149,6 +149,65 @@ int scmi_xfer_get_init(const struct scmi_handle *h, u8 msg_id, u8 prot_id, > > size_t tx_size, size_t rx_size, struct scmi_xfer **p); > > void scmi_reset_rx_to_maxsz(const struct scmi_handle *handle, > > struct scmi_xfer *xfer); > > + > > +struct scmi_xfer_ops; > > + > > +/** > > + * struct scmi_protocol_handle - Reference to an initialized protocol instance > > + * > > + * @dev: A reference to the associated SCMI instance device (handle->dev). > > + * @xops: A reference to a struct holding refs to the core xfer operations that > > + * can be used by the protocol implementation to generate SCMI messages. > > + * @set_priv: A method to set protocol private data for this instance. > > + * @get_priv: A method to get protocol private data previously set. > > + * > > + * This structure represents a protocol initialized against specific SCMI > > + * instance and it will be used as follows: > > + * - as a parameter fed from the core to the protocol initialization code so > > + * that it can access the core xfer operations to build and generate SCMI > > + * messages exclusively for the specific underlying protocol instance. > > + * - as an opaque handle fed by an SCMI driver user when it tries to access > > + * this protocol through its own protocol operations. > > + * In this case this handle will be returned as an opaque object together > > + * with the related protocol operations when the SCMI driver tries to access > > + * the protocol. > > + */ > > +struct scmi_protocol_handle { > > + struct device *dev; > > + const struct scmi_xfer_ops *xops; > > + int (*set_priv)(const struct scmi_protocol_handle *ph, void *priv); > > + void *(*get_priv)(const struct scmi_protocol_handle *ph); > > +}; > > + > > +/** > > + * struct scmi_xfer_ops - References to the core SCMI xfer operations. > > + * @version_get: Get this version protocol. > > + * @xfer_get_init: Initialize one struct xfer if any xfer slot is free. > > + * @reset_rx_to_maxsz: Reset rx size to max transport size. > > + * @do_xfer: Do the SCMI transfer. > > + * @do_xfer_with_response: Do the SCMI transfer waiting for a response. > > + * @xfer_put: Free the xfer slot. > > + * > > + * Note that all this operations expect a protocol handle as first parameter; > > + * they then internally use it to infer the underlying protocol number: this > > + * way is not possible for a protocol implementation to forge messages for > > + * another protocol. > > + */ > > +struct scmi_xfer_ops { > > Maybe move the definition above struct scmi_protocol_handle to avoid a > declaration ? > But all the ops defined inside scmi_xfer_ops refers then to a param struct scmi_protocol_handle, so I'd need anyway a similar declaration the other way around. If not: linux/drivers/firmware/arm_scmi/common.h:178:32: warning: ‘struct scmi_protocol_handle’ declared inside parameter list will not be visible outside of this definition or declaration Thanks Cristian > > -- > Warm Regards > Thara