From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7523C433E0 for ; Mon, 11 Jan 2021 14:42:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40B00221F8 for ; Mon, 11 Jan 2021 14:42:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40B00221F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7899B6E0EE; Mon, 11 Jan 2021 14:42:02 +0000 (UTC) X-Greylist: delayed 2147 seconds by postgrey-1.36 at gabe; Sat, 09 Jan 2021 00:34:32 UTC Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by gabe.freedesktop.org (Postfix) with ESMTP id B593B6E8E6; Sat, 9 Jan 2021 00:34:32 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1ky2D2-0008AZ-00; Sat, 09 Jan 2021 01:34:24 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id AFC99C0870; Sat, 9 Jan 2021 01:33:52 +0100 (CET) Date: Sat, 9 Jan 2021 01:33:52 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Message-ID: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108235805.GA17543@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Mon, 11 Jan 2021 14:42:01 +0000 Subject: Re: [Intel-gfx] [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, linux-aio@kvack.org, airlied@linux.ie, nouveau@lists.freedesktop.org, bigeasy@linutronix.de, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, ray.huang@amd.com, paulus@samba.org, kraxel@redhat.com, sparclinux@vger.kernel.org, deanbo422@gmail.com, hch@lst.de, paulmck@kernel.org, mpe@ellerman.id.au, x86@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, airlied@redhat.com, linux-snps-arc@lists.infradead.org, linux-mm@kvack.org, mgorman@suse.de, linux-xtensa@linux-xtensa.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, sroland@vmware.com, josef@toxicpanda.com, rostedt@goodmis.org, torvalds@linuxfoundation.org, green.hu@gmail.com, dsterba@suse.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, nickhu@andestech.com, clm@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, bcrl@kvack.org, spice-devel@lists.freedesktop.org, vgupta@synopsys.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, bristot@redhat.com, davem@davemloft.net, linux-btrfs@vger.kernel.org, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17529C433E6 for ; Sat, 9 Jan 2021 00:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB98223AAA for ; Sat, 9 Jan 2021 00:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726011AbhAIAfG (ORCPT ); Fri, 8 Jan 2021 19:35:06 -0500 Received: from elvis.franken.de ([193.175.24.41]:36963 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725792AbhAIAfG (ORCPT ); Fri, 8 Jan 2021 19:35:06 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1ky2D2-0008AZ-01; Sat, 09 Jan 2021 01:34:24 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id AFC99C0870; Sat, 9 Jan 2021 01:33:52 +0100 (CET) Date: Sat, 9 Jan 2021 01:33:52 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Cc: tglx@linutronix.de, airlied@linux.ie, airlied@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, bcrl@kvack.org, bigeasy@linutronix.de, bristot@redhat.com, bsegall@google.com, bskeggs@redhat.com, chris@zankel.net, christian.koenig@amd.com, clm@fb.com, davem@davemloft.net, deanbo422@gmail.com, dietmar.eggemann@arm.com, dri-devel@lists.freedesktop.org, dsterba@suse.com, green.hu@gmail.com, hch@lst.de, intel-gfx@lists.freedesktop.org, jcmvbkbc@gmail.com, josef@toxicpanda.com, juri.lelli@redhat.com, kraxel@redhat.com, linux-aio@kvack.org, linux-arm-kernel@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-csky@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, mgorman@suse.de, mingo@kernel.org, monstr@monstr.eu, mpe@ellerman.id.au, nickhu@andestech.com, nouveau@lists.freedesktop.org, paulmck@kernel.org, paulus@samba.org, peterz@infradead.org, ray.huang@amd.com, rodrigo.vivi@intel.com, rostedt@goodmis.org, sparclinux@vger.kernel.org, spice-devel@lists.freedesktop.org, sroland@vmware.com, torvalds@linuxfoundation.org, vgupta@synopsys.com, vincent.guittot@linaro.org, viro@zeniv.linux.org.uk, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Message-ID: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210108235805.GA17543@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6882C433E0 for ; Sat, 9 Jan 2021 00:34:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DD2D23A1E for ; Sat, 9 Jan 2021 00:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DD2D23A1E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=62Mp5ItIlEH2ukMIU0CzaFPeHw/RPWhkv9dNcMkXkiI=; b=0hyhG7QuOc5u0Yz5qY8tg42O1 6UvCKHCgjBkm+Du9fia007PlpjMpCu9QfzyQVAk/BENpQYWv7fHzkHrU5+v8pifr0b+0DWJ46chE4 43hzCG0++IHJ4ABYUi+YYyY8V/MKVvNKa7NH3o8aC895G6k6F4Hb1A1ZN2vgp/dtRgOOIL1N64Fx9 LorWiWJNqk55OyXbyhhEmRZFRT3gqLXU0W2kqbJF1QiJmecITIG7haNt6MX5ZSKeKXxkxUN5fh7RU 5Upy5JhN7C+FszJx8h2SMi7zkv/1b/KnCf1QnCToQ/EF8y/nhDYLQ4XmJwzX+YuhYSXyU50LaCHBh nq92/Pr2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ky2DB-0006BH-FB; Sat, 09 Jan 2021 00:34:33 +0000 Received: from elvis.franken.de ([193.175.24.41]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ky2D9-0006Av-OX; Sat, 09 Jan 2021 00:34:32 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1ky2D2-0008AZ-00; Sat, 09 Jan 2021 01:34:24 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id AFC99C0870; Sat, 9 Jan 2021 01:33:52 +0100 (CET) Date: Sat, 9 Jan 2021 01:33:52 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Message-ID: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210108235805.GA17543@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_193432_023854_A5DDC367 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, linux-aio@kvack.org, airlied@linux.ie, nouveau@lists.freedesktop.org, bigeasy@linutronix.de, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, ray.huang@amd.com, paulus@samba.org, kraxel@redhat.com, sparclinux@vger.kernel.org, deanbo422@gmail.com, hch@lst.de, vincent.guittot@linaro.org, paulmck@kernel.org, mpe@ellerman.id.au, x86@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, airlied@redhat.com, linux-snps-arc@lists.infradead.org, linux-mm@kvack.org, mgorman@suse.de, linux-xtensa@linux-xtensa.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, sroland@vmware.com, josef@toxicpanda.com, rostedt@goodmis.org, torvalds@linuxfoundation.org, green.hu@gmail.com, rodrigo.vivi@intel.com, dsterba@suse.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, nickhu@andestech.com, clm@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, bcrl@kvack.org, spice-devel@lists.freedesktop.org, vgupta@synopsys.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, bristot@redhat.com, davem@davemloft.net, linux-btrfs@vger.kernel.org, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Bogendoerfer Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Date: Sat, 9 Jan 2021 01:33:52 +0100 Message-ID: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20210108235805.GA17543@alpha.franken.de> Sender: owner-linux-aio@kvack.org To: Paul Cercueil Cc: tglx@linutronix.de, airlied@linux.ie, airlied@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, bcrl@kvack.org, bigeasy@linutronix.de, bristot@redhat.com, bsegall@google.com, bskeggs@redhat.com, chris@zankel.net, christian.koenig@amd.com, clm@fb.com, davem@davemloft.net, deanbo422@gmail.com, dietmar.eggemann@arm.com, dri-devel@lists.freedesktop.org, dsterba@suse.com, green.hu@gmail.com, hch@lst.de, intel-gfx@lists.freedesktop.org, jcmvbkbc@gmail.com, josef@toxicpanda.com, juri.lelli@redhat.com, kraxel@redhat.com, linux-aio@kvack.org, linux-arm-kernel@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-csky@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux@armlinux.org.uklinux List-Id: nouveau.vger.kernel.org On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1662C433DB for ; Sat, 9 Jan 2021 02:57:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF46023A82 for ; Sat, 9 Jan 2021 02:57:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF46023A82 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DCPlG6fG5zDqx2 for ; Sat, 9 Jan 2021 13:57:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=elvis.franken.de (client-ip=193.175.24.41; helo=elvis.franken.de; envelope-from=tsbogend@alpha.franken.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lists.ozlabs.org (Postfix) with ESMTP id 4DCLZb1sX6zDr95 for ; Sat, 9 Jan 2021 11:34:31 +1100 (AEDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1ky2D2-0008AZ-00; Sat, 09 Jan 2021 01:34:24 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id AFC99C0870; Sat, 9 Jan 2021 01:33:52 +0100 (CET) Date: Sat, 9 Jan 2021 01:33:52 +0100 From: Thomas Bogendoerfer To: Paul Cercueil Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Message-ID: <20210109003352.GA18102@alpha.franken.de> References: <20210108235805.GA17543@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210108235805.GA17543@alpha.franken.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Sat, 09 Jan 2021 13:54:00 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: juri.lelli@redhat.com, linux-aio@kvack.org, airlied@linux.ie, nouveau@lists.freedesktop.org, bigeasy@linutronix.de, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, ray.huang@amd.com, paulus@samba.org, kraxel@redhat.com, sparclinux@vger.kernel.org, deanbo422@gmail.com, hch@lst.de, vincent.guittot@linaro.org, paulmck@kernel.org, x86@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, airlied@redhat.com, linux-snps-arc@lists.infradead.org, linux-mm@kvack.org, mgorman@suse.de, linux-xtensa@linux-xtensa.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, sroland@vmware.com, josef@toxicpanda.com, rostedt@goodmis.org, torvalds@linuxfoundation.org, green.hu@gmail.com, rodrigo.vivi@intel.com, dsterba@suse.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, nickhu@andestech.com, clm@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, bcrl@kvack.org, spice-devel@lists.freedesktop.org, vgupta@synopsys.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, bristot@redhat.com, davem@davemloft.net, linux-btrfs@vger.kernel.org, viro@zeniv.linux.org.uk Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Bogendoerfer Date: Sat, 09 Jan 2021 00:33:52 +0000 Subject: Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic Message-Id: <20210109003352.GA18102@alpha.franken.de> List-Id: References: <20210108235805.GA17543@alpha.franken.de> In-Reply-To: <20210108235805.GA17543@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Cercueil Cc: juri.lelli@redhat.com, linux-aio@kvack.org, airlied@linux.ie, nouveau@lists.freedesktop.org, bigeasy@linutronix.de, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, bsegall@google.com, jcmvbkbc@gmail.com, ray.huang@amd.com, paulus@samba.org, kraxel@redhat.com, sparclinux@vger.kernel.org, deanbo422@gmail.com, hch@lst.de, paulmck@kernel.org, mpe@ellerman.id.au, x86@kernel.org, linux@armlinux.org.uk, linux-csky@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, linux-graphics-maintainer@vmware.com, bskeggs@redhat.com, airlied@redhat.com, linux-snps-arc@lists.infradead.org, linux-mm@kvack.org, mgorman@suse.de, linux-xtensa@linux-xtensa.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, sroland@vmware.com, josef@toxicpanda.com, rostedt@goodmis.org, torvalds@linuxfoundation.org, green.hu@gmail.com, dsterba@suse.com, tglx@linutronix.de, virtualization@lists.linux-foundation.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, chris@zankel.net, monstr@monstr.eu, nickhu@andestech.com, clm@fb.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, bcrl@kvack.org, spice-devel@lists.freedesktop.org, vgupta@synopsys.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, bristot@redhat.com, davem@davemloft.net, linux-btrfs@vger.kernel.org, viro@zeniv.linux.org.uk On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > On Fri, Jan 08, 2021 at 08:20:43PM +0000, Paul Cercueil wrote: > > Hi Thomas, > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit. > > > > Any idea what could be happening? > > not yet, kernel crash log of a Malta QEMU is below. update: This dirty hack lets the Malta QEMU boot again: diff --git a/mm/highmem.c b/mm/highmem.c index c3a9ea7875ef..190cdda1149d 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -515,7 +515,7 @@ void *__kmap_local_pfn_prot(unsigned long pfn, pgprot_t prot) vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); BUG_ON(!pte_none(*(kmap_pte - idx))); pteval = pfn_pte(pfn, prot); - set_pte_at(&init_mm, vaddr, kmap_pte - idx, pteval); + set_pte(kmap_pte - idx, pteval); arch_kmap_local_post_map(vaddr, pteval); current->kmap_ctrl.pteval[kmap_local_idx()] = pteval; preempt_enable(); set_pte_at() tries to update cache and could do an kmap_atomic() there. Not sure, if this is allowed at this point. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]