From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/apcupsd: fix reverse dependency for libusb
Date: Sat, 9 Jan 2021 22:40:08 +0100 [thread overview]
Message-ID: <20210109214008.GD3044608@scaer> (raw)
In-Reply-To: <20210109133708.1832131-1-bernd.kuhls@t-online.de>
Bernd, All,
On 2021-01-09 14:37 +0100, Bernd Kuhls spake thusly:
> Commit
> https://git.buildroot.net/buildroot/commit/?id=8a26801c9fad1c7749200e22e9dfdeaeeb65f76e
> added a dependency to gcc >= 4.9 for libusb but forgot to propagate
> the reverse dependency to BR2_PACKAGE_APCUPSD_USB.
Yup, it only propagated to BR2_PACKAGE_APCUPSD_MODBUS_USB and missed
BR2_PACKAGE_APCUPSD_USB.
> Fixes:
> http://autobuild.buildroot.net/results/f34/f348fe8e5530970a14589ca878810a3bdaf98f67/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/apcupsd/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/apcupsd/Config.in b/package/apcupsd/Config.in
> index f87f6a8b55..2a00d43d67 100644
> --- a/package/apcupsd/Config.in
> +++ b/package/apcupsd/Config.in
> @@ -57,13 +57,15 @@ config BR2_PACKAGE_APCUPSD_SNMP
> config BR2_PACKAGE_APCUPSD_USB
> bool "usb"
> depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> select BR2_PACKAGE_LIBUSB
> select BR2_PACKAGE_LIBUSB_COMPAT
> help
> Compile USB UPS code
>
> -comment "usb support needs a toolchain w/ threads"
> - depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "usb support needs a toolchain w/ threads, gcc >= 4.9"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>
> endif
>
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2021-01-09 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 13:37 [Buildroot] [PATCH 1/1] package/apcupsd: fix reverse dependency for libusb Bernd Kuhls
2021-01-09 21:40 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109214008.GD3044608@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.