From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4464899071168002612==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings Date: Sun, 10 Jan 2021 07:30:18 +0800 Message-ID: <20210109233018.GA60187@04e996a7a407> In-Reply-To: <202101100734.VJS04oDD-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4464899071168002612== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Samuel Holland CC: Sebastian Reichel CC: "Chen-Yu Tsai" CC: linux-pm(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant beca= use platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci Fixes: ca4c77bb4315 ("power: supply: axp20x_ac_power: Add wakeup control") CC: Samuel Holland Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 2ff90100ace886895e4fbb2850b8d5e49d931ed6 commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_p= ower: Add wakeup control :::::: branch date: 4 hours ago :::::: commit date: 12 months ago Please take the patch only if it's a positive warning. Thanks! axp20x_ac_power.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/power/supply/axp20x_ac_power.c +++ b/drivers/power/supply/axp20x_ac_power.c @@ -378,8 +378,6 @@ static int axp20x_ac_power_probe(struct for (i =3D 0; i < axp_data->num_irq_names; i++) { irq =3D platform_get_irq_byname(pdev, axp_data->irq_names[i]); if (irq < 0) { - dev_err(&pdev->dev, "No IRQ for %s: %d\n", - axp_data->irq_names[i], irq); return irq; } power->irqs[i] =3D regmap_irq_get_virq(axp20x->regmap_irqc, irq); --===============4464899071168002612==--