From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Yuusuke Ashizuka <ashiduka@fujitsu.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org, torii.ken1@fujitsu.com
Subject: Re: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN
Date: Sun, 10 Jan 2021 10:23:10 +0000 [thread overview]
Message-ID: <20210110102310.GD1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210110085221.5881-1-ashiduka@fujitsu.com>
On Sun, Jan 10, 2021 at 05:52:21PM +0900, Yuusuke Ashizuka wrote:
> RTL9000AA/AN as 100BASE-T1 is following:
> - 100 Mbps
> - Full duplex
> - Link Status Change Interrupt
>
> Signed-off-by: Yuusuke Ashizuka <ashiduka@fujitsu.com>
> Signed-off-by: Torii Kenichi <torii.ken1@fujitsu.com>
Not a review comment on your patch, but, we really need to do
something with the way phylib handles configuration changes - we
have the current situation where config_aneg() _will_ get called
for PHYs like this that do not support autonegotiation if userspace
attempts to enable autoneg - there is nothing in
phy_ethtool_ksettings_set() that prevents this.
Returning an error from config_aneg() achieves nothing, and
resetting the settings in config_init() also does nothing to avoid
autonegotiation being enabled.
I think we need phy_ethtool_ksettings_set() to check whether
ETHTOOL_LINK_MODE_Autoneg_BIT is set in phydev->supported before
allowing the AUTONEG_ENABLE case.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-01-10 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 8:52 [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN Yuusuke Ashizuka
2021-01-10 10:23 ` Russell King - ARM Linux admin [this message]
2021-01-10 16:22 ` Andrew Lunn
2021-01-12 5:14 ` ashiduka
2021-01-12 13:54 ` Andrew Lunn
2021-01-13 1:10 ` ashiduka
2021-01-14 8:38 ` ashiduka
2021-01-14 23:04 ` Andrew Lunn
2021-01-18 10:17 ` ashiduka
2021-01-19 15:46 ` Andrew Lunn
2021-01-20 11:32 ` ashiduka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210110102310.GD1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torii.ken1@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.