From: Leon Romanovsky <leonro@nvidia.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <dledford@redhat.com>,
<jgg@nvidia.com>, <sagi@grimberg.me>, <oren@nvidia.com>,
Israel Rukshin <israelr@nvidia.com>
Subject: Re: [PATCH 2/3] IB/isert: remove unneeded semicolon
Date: Sun, 10 Jan 2021 13:36:43 +0200 [thread overview]
Message-ID: <20210110113643.GI31158@unreal> (raw)
In-Reply-To: <20210110111903.486681-2-mgurtovoy@nvidia.com>
On Sun, Jan 10, 2021 at 11:19:02AM +0000, Max Gurtovoy wrote:
> No need to add semicolon after closing bracket.
>
> Reviewed-by: Israel Rukshin <israelr@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 5958929b7dec..96514f675427 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -1991,7 +1991,7 @@ isert_set_dif_domain(struct se_cmd *se_cmd, struct ib_sig_domain *domain)
> if (se_cmd->prot_type == TARGET_DIF_TYPE1_PROT ||
> se_cmd->prot_type == TARGET_DIF_TYPE2_PROT)
> domain->sig.dif.ref_remap = true;
> -};
> +}
The same goes for iser_set_dif_domain() and iser_cleanup_handler().
Thanks
>
> static int
> isert_set_sig_attrs(struct se_cmd *se_cmd, struct ib_sig_attrs *sig_attrs)
> --
> 2.25.4
>
next prev parent reply other threads:[~2021-01-10 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 11:19 [PATCH 1/3] IB/isert: remove unneeded new lines Max Gurtovoy
2021-01-10 11:19 ` [PATCH 2/3] IB/isert: remove unneeded semicolon Max Gurtovoy
2021-01-10 11:36 ` Leon Romanovsky [this message]
2021-01-10 12:07 ` Max Gurtovoy
2021-01-14 0:07 ` Sagi Grimberg
2021-01-10 11:19 ` [PATCH 3/3] IB/isert: simplify signature cap check Max Gurtovoy
2021-01-14 0:08 ` Sagi Grimberg
2021-01-14 7:29 ` Leon Romanovsky
2021-01-14 12:49 ` Jason Gunthorpe
2021-01-14 12:54 ` Max Gurtovoy
2021-01-14 13:00 ` Leon Romanovsky
2021-01-14 12:59 ` Leon Romanovsky
2021-01-14 0:06 ` [PATCH 1/3] IB/isert: remove unneeded new lines Sagi Grimberg
2021-01-18 21:02 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210110113643.GI31158@unreal \
--to=leonro@nvidia.com \
--cc=dledford@redhat.com \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.