All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/busybox: fix selinux-related build error
Date: Sun, 10 Jan 2021 14:44:14 +0100	[thread overview]
Message-ID: <20210110134414.GS3044608@scaer> (raw)
In-Reply-To: <20210110122310.313941-1-bernd.kuhls@t-online.de>

Bernd, All,

On 2021-01-10 13:23 +0100, Bernd Kuhls spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/b89/b89b7d0f0601bb706e76cea31cf4e43326e5540c/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...3-update_passwd-fix-context-variable.patch | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 package/busybox/0003-update_passwd-fix-context-variable.patch
> 
> diff --git a/package/busybox/0003-update_passwd-fix-context-variable.patch b/package/busybox/0003-update_passwd-fix-context-variable.patch
> new file mode 100644
> index 0000000000..25c07d7054
> --- /dev/null
> +++ b/package/busybox/0003-update_passwd-fix-context-variable.patch
> @@ -0,0 +1,41 @@
> +From b4828612abe378491693c9036db19e4f64768307 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd.kuhls@t-online.de>
> +Date: Sun, 10 Jan 2021 13:15:04 +0100
> +Subject: [PATCH] update_passwd: fix context variable
> +
> +Commit
> +https://git.busybox.net/busybox/commit/libbb/update_passwd.c?id=2496616b0a8d1c80cd1416b73a4847b59b9f969a
> +
> +changed the variable used from context to seuser but forgot this
> +change resulting in build errors detected by buildroot autobuilders:
> +
> +http://autobuild.buildroot.net/results/b89/b89b7d0f0601bb706e76cea31cf4e43326e5540c//build-end.log
> +
> +libbb/update_passwd.c:51:11: error: 'context' undeclared (first use in
> + this function); did you mean 'ucontext'?
> +   freecon(context);
> +
> +Patch sent upstream:
> +http://lists.busybox.net/pipermail/busybox/2021-January/088467.html
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +---
> + libbb/update_passwd.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/libbb/update_passwd.c b/libbb/update_passwd.c
> +index 7b67f30cd..a228075cc 100644
> +--- a/libbb/update_passwd.c
> ++++ b/libbb/update_passwd.c
> +@@ -48,7 +48,7 @@ static void check_selinux_update_passwd(const char *username)
> + 			bb_simple_error_msg_and_die("SELinux: access denied");
> + 	}
> + 	if (ENABLE_FEATURE_CLEAN_UP)
> +-		freecon(context);
> ++		freecon(seuser);
> + }
> + #else
> + # define check_selinux_update_passwd(username) ((void)0)
> +-- 
> +2.29.2
> +
> -- 
> 2.29.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2021-01-10 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 12:23 [Buildroot] [PATCH 1/1] package/busybox: fix selinux-related build error Bernd Kuhls
2021-01-10 13:44 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210110134414.GS3044608@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.