All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Patrisious Haddad <phaddad@nvidia.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	linux-netdev <netdev@vger.kernel.org>,
	RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH iproute2-next v2] rdma: Add support for the netlink extack
Date: Mon, 11 Jan 2021 07:30:38 +0200	[thread overview]
Message-ID: <20210111053038.GJ31158@unreal> (raw)
In-Reply-To: <f2ad7596-b976-aef7-56b7-edfba3a77ba0@gmail.com>

On Sun, Jan 10, 2021 at 10:23:06AM -0700, David Ahern wrote:
> On 1/2/21 11:17 PM, Leon Romanovsky wrote:
> > From: Patrisious Haddad <phaddad@nvidia.com>
> >
> > Add support in rdma for extack errors to be received
> > in userspace when sent from kernel, so now netlink extack
> > error messages sent from kernel would be printed for the
> > user.
> >
> > Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > David,
> >
> > Just as a note, rdmatool is heavily influenced by the devlink and
> > general code should probably be applicable for both tools. Most likely
> > that any core refactoring/fix in the devlink is needed for rdmatool too.
> >
>
> understood and it was not the best model to start with but here we are.
>
> Petr did a good job of refactoring when he added dcb, but rdma was
> slightly different so the refactoring did not update it.

I can work to reduce the gaps, just need to know them.

Thanks

      reply	other threads:[~2021-01-11  5:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03  6:17 [PATCH iproute2-next v2] rdma: Add support for the netlink extack Leon Romanovsky
2021-01-10 17:23 ` David Ahern
2021-01-11  5:30   ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111053038.GJ31158@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=phaddad@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.