From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-rtc@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 3/3] rtc: s5m: use devm_i2c_new_dummy_device()
Date: Mon, 11 Jan 2021 14:36:48 +0100 [thread overview]
Message-ID: <20210111133648.GC34341@kozik-lap> (raw)
In-Reply-To: <20210111124027.21586-4-brgl@bgdev.pl>
On Mon, Jan 11, 2021 at 01:40:27PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Use the managed variant of i2c_new_dummy_device() to shrink code and
> remove the goto label. We can drop the remove callback now too.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/rtc/rtc-s5m.c | 31 +++++++------------------------
> 1 file changed, 7 insertions(+), 24 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2021-01-11 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:40 [PATCH v4 0/3] rtc: s5m: driver improvements Bartosz Golaszewski
2021-01-11 12:40 ` [PATCH v4 1/3] rtc: s5m: select REGMAP_I2C Bartosz Golaszewski
2021-01-11 13:33 ` Krzysztof Kozlowski
2021-01-11 12:40 ` [PATCH v4 2/3] rtc: s5m: check the return value of s5m8767_rtc_init_reg() Bartosz Golaszewski
2021-01-11 13:35 ` Krzysztof Kozlowski
2021-01-11 14:11 ` Bartosz Golaszewski
2021-01-11 14:12 ` Krzysztof Kozlowski
2021-01-11 12:40 ` [PATCH v4 3/3] rtc: s5m: use devm_i2c_new_dummy_device() Bartosz Golaszewski
2021-01-11 13:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111133648.GC34341@kozik-lap \
--to=krzk@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.