From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDE8C433DB for ; Mon, 11 Jan 2021 15:39:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 433482067C for ; Mon, 11 Jan 2021 15:39:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 433482067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23D296E0FB; Mon, 11 Jan 2021 15:39:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8DD36E0F4 for ; Mon, 11 Jan 2021 15:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610379562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=UGpgWj79HBcdJnkBtUIGCZqpsA1rgF0hz/DFMjZHuYug6vpA4KOagjokW6GGCDOnPOXy/I WtpLn9zvsSG9Hpw/8bhHHCQj8qrP2yO52FgTgzx5VDrtOQJQhchCugxLHDn7ImNudFdUQN bo0YbxhPoItwWo1XdJeas/XaIGt23fQ= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-Y2nnYFJeOeKlUB67JMteyg-1; Mon, 11 Jan 2021 10:39:21 -0500 X-MC-Unique: Y2nnYFJeOeKlUB67JMteyg-1 Received: by mail-il1-f200.google.com with SMTP id x15so2962344ilu.11 for ; Mon, 11 Jan 2021 07:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=N/ix6zi+dj+VuKO6SS4JvuX8GEC3SAB5xEQJeTf3nuITaPeg+TNouvz7wqa8OOOV/b Fp2UaYaHd2CesM+D8aRxlR1dAchSysh1TnWV8sx3Lc+ZbwRGOsAaXKi2pXAKlWLT4vLi edUnThlkhOZBJmn/bCiTcomELl0ai+LgY4/8yM3Y17GW7Mn8sWXSZGV6gpdqoXgliQBq LBiQEs0UP4SdZapPSBo7OkOMzaw4YK+rtXVRZ6uOFBzHxVCTo3Y9PG8INHZ9CgCG+K4/ O6Nu/s2VKasTxCYXI8kaXR7dzDeto9qETo+HxwiuDiL6LJBVCqr2kI5JB1d1J0vdjp0Z nqXg== X-Gm-Message-State: AOAM533XHEbinmJq5FAm9XEs1CZO84Etb3KwTpPoxLCeku/7LAbTT8Oa z50YkNktqa1sKieBXJMpuchuAj5pMgHiTOihO1jy55ZnOBvMpwGNcauzrWhtW3aQ/T7nhKB9Kzs CS+qsNAVjRG9wEK3ofV67iNOMUA== X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547588ilr.207.1610379560567; Mon, 11 Jan 2021 07:39:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzlggvM+nwzezd73mKCuiQILg/y8Tnj4twPqnA644Y3DXvue24trNEi0s1w98pXs6fxCdnvw== X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547567ilr.207.1610379560359; Mon, 11 Jan 2021 07:39:20 -0800 (PST) Received: from xps13 ([2605:a601:a63a:4d01:c3c1:7008:ba35:96]) by smtp.gmail.com with ESMTPSA id t2sm16862182ili.31.2021.01.11.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:39:19 -0800 (PST) Date: Mon, 11 Jan 2021 10:39:17 -0500 From: Jeremy Cline To: Christian =?utf-8?B?S8O2bmln?= Subject: Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections Message-ID: <20210111153917.GA22594@xps13> References: <20210108215838.470637-1-jcline@redhat.com> <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> MIME-Version: 1.0 In-Reply-To: <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jcline@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , Timothy Pearson , dri-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , Harry Wentland Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" SGksCgpPbiBNb24sIEphbiAxMSwgMjAyMSBhdCAwOTo1Mzo1NkFNICswMTAwLCBDaHJpc3RpYW4g S8O2bmlnIHdyb3RlOgo+IEFtIDA4LjAxLjIxIHVtIDIyOjU4IHNjaHJpZWIgSmVyZW15IENsaW5l Ogo+ID4gZGNuMjBfcmVzb3VyY2VfY29uc3RydWN0KCkgaW5jbHVkZXMgYSBudW1iZXIgb2Yga3ph bGxvYyhHRlBfS0VSTkVMKQo+ID4gY2FsbHMgd2hpY2ggY2FuIHNsZWVwLCBidXQga2VybmVsX2Zw dV9iZWdpbigpIGRpc2FibGVzIHByZWVtcHRpb24gYW5kCj4gPiBzbGVlcGluZyBpbiB0aGlzIGNv bnRleHQgaXMgaW52YWxpZC4KPiA+IAo+ID4gVGhlIG9ubHkgcGxhY2VzIHRoZSBGUFUgYXBwZWFy cyB0byBiZSByZXF1aXJlZCBpcyBpbiB0aGUKPiA+IGluaXRfc29jX2JvdW5kaW5nX2JveCgpIGZ1 bmN0aW9uIGFuZCB3aGVuIGNhbGN1bGF0aW5nIHRoZQo+ID4ge21pbixtYXh9X2ZpbGxfY2xrX21o ei4gTmFycm93IHRoZSBzY29wZSB0byBqdXN0IHRoZXNlIHR3byBwYXJ0cyB0bwo+ID4gYXZvaWQg c2xlZXBpbmcgd2hpbGUgdXNpbmcgdGhlIEZQVS4KPiA+IAo+ID4gRml4ZXM6IDdhOGEzNDMwYmUx NSAoImFtZGdwdTogV3JhcCBGUFUgZGVwZW5kZW50IGZ1bmN0aW9ucyBpbiBkYzIwIikKPiA+IENj OiBUaW1vdGh5IFBlYXJzb24gPHRwZWFyc29uQHJhcHRvcmVuZ2luZWVyaW5nLmNvbT4KPiA+IFNp Z25lZC1vZmYtYnk6IEplcmVteSBDbGluZSA8amNsaW5lQHJlZGhhdC5jb20+Cj4gCj4gR29vZCBj YXRjaCwgYnV0IEkgd291bGQgcmF0aGVyIHJlcGxhY2UgdGhlIGt6YWxsb2MoR0ZQX0tFUk5FTCkg d2l0aCBhCj4ga3phbGxvYyhHRlBfQVRPTUlDKSBmb3Igbm93Lgo+IAo+IFdlIGhhdmUgdG9ucyBv ZiBwcm9ibGVtcyB3aXRoIHRoaXMgRENfRlBfU1RBUlQoKS9EQ19GUF9FTkQoKSBhbm5vdGF0aW9u cyBhbmQKPiBhcmUgZXZlbiBpbiB0aGUgcHJvY2VzcyBvZiBtb3ZpbmcgdGhlbSBvdXQgb2YgdGhl IGZpbGUgYmVjYXVzZSB0aGUgY29tcGlsZXMKPiB0ZW5kIHRvIGNsdXR0ZXIgRlAgcmVnaXN0ZXJz IGV2ZW4gb3V0c2lkZSBvZiB0aGUgYW5ub3RhdGVkIHJhbmdlcyBvbiBzb21lCj4gYXJjaGl0ZWN0 dXJlcy4KPiAKClRoYW5rcyBmb3IgdGhlIHJldmlldy4gSXMgaXQgYWNjZXB0YWJsZSB0byBtb3Zl IHRoZSBEQ19GUF9FTkQoKQphbm5vdGF0aW9uIHVwIHRvIHRoZSBsYXN0IHVzYWdlPyBLZWVwaW5n IGl0IHdoZXJlIGl0IGlzIGlzIHByb2JhYmx5CmRvLWFibGUsIGJ1dCBjb3ZlcnMgdGhpbmdzIGxp a2UgY2FsbHMgdG8gcmVzb3VyY2VfY29uc3RydWN0KCkgd2hpY2gKbWFrZXMgdXNlIG9mIHN0cnVj dCByZXNvdXJjZV9jcmVhdGVfZnVuY3MuIEknbSBndWVzc2luZyBvbmx5IGEgc3ViLXNldApvZiB0 aGUgaW1wbGVtZW50YXRpb25zIGFyZSBjYWxsZWQgdmlhIHRoaXMgZnVuY3Rpb24sIGJ1dCBoYXZp bmcgYW4KaW50ZXJmYWNlIHdoaWNoIGNhbid0IHNsZWVwIHNvbWV0aW1lcyBkb2Vzbid0IHNvdW5k IGFwcGVhbGluZy4KCkhhcHB5IHRvIGRvIGl0LCBidXQgYmVmb3JlIEkgZ28gZG93biB0aGF0IHJv YWQgSSBqdXN0IHdhbnRlZCB0byBtYWtlCnN1cmUgdGhhdCdzIHdoYXQgeW91IGhhZCBpbiBtaW5k LgoKVGhhbmtzLApKZXJlbXkKCj4gPiAtLS0KPiA+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNw bGF5L2RjL2RjbjIwL2RjbjIwX3Jlc291cmNlLmMgfCA4ICsrKystLS0tCj4gPiAgIDEgZmlsZSBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjAvZGNuMjBfcmVzb3VyY2Uu YyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY24yMC9kY24yMF9yZXNvdXJjZS5j Cj4gPiBpbmRleCBlMDRlY2YwZmMwZGIuLmE0ZmE1YmYwMTZjMSAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY24yMC9kY24yMF9yZXNvdXJjZS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjAvZGNuMjBfcmVzb3VyY2Uu Ywo+ID4gQEAgLTM2MjIsNiArMzYyMiw3IEBAIHN0YXRpYyBib29sIGluaXRfc29jX2JvdW5kaW5n X2JveChzdHJ1Y3QgZGMgKmRjLAo+ID4gICAJaWYgKGJiICYmIEFTSUNSRVZfSVNfTkFWSTEyX1Ao ZGMtPmN0eC0+YXNpY19pZC5od19pbnRlcm5hbF9yZXYpKSB7Cj4gPiAgIAkJaW50IGk7Cj4gPiAr CQlEQ19GUF9TVEFSVCgpOwo+ID4gICAJCWRjbjJfMF9udjEyX3NvYy5zcl9leGl0X3RpbWVfdXMg PQo+ID4gICAJCQkJZml4ZWQxNl90b19kb3VibGVfdG9fY3B1KGJiLT5zcl9leGl0X3RpbWVfdXMp Owo+ID4gICAJCWRjbjJfMF9udjEyX3NvYy5zcl9lbnRlcl9wbHVzX2V4aXRfdGltZV91cyA9Cj4g PiBAQCAtMzcyMSw2ICszNzIyLDcgQEAgc3RhdGljIGJvb2wgaW5pdF9zb2NfYm91bmRpbmdfYm94 KHN0cnVjdCBkYyAqZGMsCj4gPiAgIAkJCWRjbjJfMF9udjEyX3NvYy5jbG9ja19saW1pdHNbaV0u ZHJhbV9zcGVlZF9tdHMgPQo+ID4gICAJCQkJCWZpeGVkMTZfdG9fZG91YmxlX3RvX2NwdShiYi0+ Y2xvY2tfbGltaXRzW2ldLmRyYW1fc3BlZWRfbXRzKTsKPiA+ICAgCQl9Cj4gPiArCQlEQ19GUF9F TkQoKTsKPiA+ICAgCX0KPiA+ICAgCWlmIChwb29sLT5iYXNlLnBwX3NtdSkgewo+ID4gQEAgLTM3 NzcsOCArMzc3OSw2IEBAIHN0YXRpYyBib29sIGRjbjIwX3Jlc291cmNlX2NvbnN0cnVjdCgKPiA+ ICAgCWVudW0gZG1sX3Byb2plY3QgZG1sX3Byb2plY3RfdmVyc2lvbiA9Cj4gPiAgIAkJCWdldF9k bWxfcHJvamVjdF92ZXJzaW9uKGN0eC0+YXNpY19pZC5od19pbnRlcm5hbF9yZXYpOwo+ID4gLQlE Q19GUF9TVEFSVCgpOwo+ID4gLQo+ID4gICAJY3R4LT5kY19iaW9zLT5yZWdzID0gJmJpb3NfcmVn czsKPiA+ICAgCXBvb2wtPmJhc2UuZnVuY3MgPSAmZGNuMjBfcmVzX3Bvb2xfZnVuY3M7Cj4gPiBA QCAtMzk1OSw4ICszOTU5LDEwIEBAIHN0YXRpYyBib29sIGRjbjIwX3Jlc291cmNlX2NvbnN0cnVj dCgKPiA+ICAgCQkJCXJhbmdlcy5yZWFkZXJfd21fc2V0c1tpXS53bV9pbnN0ID0gaTsKPiA+ICAg CQkJCXJhbmdlcy5yZWFkZXJfd21fc2V0c1tpXS5taW5fZHJhaW5fY2xrX21oeiA9IFBQX1NNVV9X TV9TRVRfUkFOR0VfQ0xLX1VOQ09OU1RSQUlORURfTUlOOwo+ID4gICAJCQkJcmFuZ2VzLnJlYWRl cl93bV9zZXRzW2ldLm1heF9kcmFpbl9jbGtfbWh6ID0gUFBfU01VX1dNX1NFVF9SQU5HRV9DTEtf VU5DT05TVFJBSU5FRF9NQVg7Cj4gPiArCQkJCURDX0ZQX1NUQVJUKCk7Cj4gPiAgIAkJCQlyYW5n ZXMucmVhZGVyX3dtX3NldHNbaV0ubWluX2ZpbGxfY2xrX21oeiA9IChpID4gMCkgPyAobG9hZGVk X2JiLT5jbG9ja19saW1pdHNbaSAtIDFdLmRyYW1fc3BlZWRfbXRzIC8gMTYpICsgMSA6IDA7Cj4g PiAgIAkJCQlyYW5nZXMucmVhZGVyX3dtX3NldHNbaV0ubWF4X2ZpbGxfY2xrX21oeiA9IGxvYWRl ZF9iYi0+Y2xvY2tfbGltaXRzW2ldLmRyYW1fc3BlZWRfbXRzIC8gMTY7Cj4gPiArCQkJCURDX0ZQ X0VORCgpOwo+ID4gICAJCQkJcmFuZ2VzLm51bV9yZWFkZXJfd21fc2V0cyA9IGkgKyAxOwo+ID4g ICAJCQl9Cj4gPiBAQCAtNDEyNSwxMiArNDEyNywxMCBAQCBzdGF0aWMgYm9vbCBkY24yMF9yZXNv dXJjZV9jb25zdHJ1Y3QoCj4gPiAgIAkJcG9vbC0+YmFzZS5vZW1fZGV2aWNlID0gTlVMTDsKPiA+ ICAgCX0KPiA+IC0JRENfRlBfRU5EKCk7Cj4gPiAgIAlyZXR1cm4gdHJ1ZTsKPiA+ICAgY3JlYXRl X2ZhaWw6Cj4gPiAtCURDX0ZQX0VORCgpOwo+ID4gICAJZGNuMjBfcmVzb3VyY2VfZGVzdHJ1Y3Qo cG9vbCk7Cj4gPiAgIAlyZXR1cm4gZmFsc2U7Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA1CBC433E6 for ; Mon, 11 Jan 2021 15:39:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5005A20637 for ; Mon, 11 Jan 2021 15:39:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5005A20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85D3A6E0FE; Mon, 11 Jan 2021 15:39:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id C94216E0FB for ; Mon, 11 Jan 2021 15:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610379562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=UGpgWj79HBcdJnkBtUIGCZqpsA1rgF0hz/DFMjZHuYug6vpA4KOagjokW6GGCDOnPOXy/I WtpLn9zvsSG9Hpw/8bhHHCQj8qrP2yO52FgTgzx5VDrtOQJQhchCugxLHDn7ImNudFdUQN bo0YbxhPoItwWo1XdJeas/XaIGt23fQ= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-CtIfQqi6ODGLDf73TDdQyg-1; Mon, 11 Jan 2021 10:39:21 -0500 X-MC-Unique: CtIfQqi6ODGLDf73TDdQyg-1 Received: by mail-io1-f70.google.com with SMTP id x7so12787501ion.12 for ; Mon, 11 Jan 2021 07:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=MmjDvXJFLVvwb30pk8vzC+TXwh5hFq3Ypbs+PcWhk8c0WgWPRQzdWbtwylbXn5voZW ODOXPkQEqBF4wdBQP6N3Kq2YLWzR28ylrHirIxzeLbru1xbZoVO3+4a/927fRXHIhD8+ iwJfBtuTVgXKnKxjLc+G/Q/4CHih64IN+6iJpCnhRxLViR7HkMSN3J0NKcWIv+ngF4J1 BrBKGsc2n5kbdtGjQPVfnSXtStygp3Bw5ghLVTQZDV+tcvHwI7oZ43bgoZpMRxeX/ZT0 1dbpQB3u783EJCRpGNusSe2Nk9Wqz2E8hMmOBXmfmwIPA9g+WmKz/D0HaCgPZQiGjctz +XFw== X-Gm-Message-State: AOAM531Ywyz7TD+HAP0F10Qe63xXoZckOPvPd8YBQNPWUN9wSVGldlTq SfmShLHjIMFM9ChGLZxZhUEe6pi73ZDsWLZP0k5UBDEhg6X/An7yQNJ5AggdAxbVi9l0P3+wvWh Nf0Txf/PpdF6UxJqDyrK7U+ohJZkF X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547589ilr.207.1610379560594; Mon, 11 Jan 2021 07:39:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzlggvM+nwzezd73mKCuiQILg/y8Tnj4twPqnA644Y3DXvue24trNEi0s1w98pXs6fxCdnvw== X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547567ilr.207.1610379560359; Mon, 11 Jan 2021 07:39:20 -0800 (PST) Received: from xps13 ([2605:a601:a63a:4d01:c3c1:7008:ba35:96]) by smtp.gmail.com with ESMTPSA id t2sm16862182ili.31.2021.01.11.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:39:19 -0800 (PST) Date: Mon, 11 Jan 2021 10:39:17 -0500 From: Jeremy Cline To: Christian =?utf-8?B?S8O2bmln?= Subject: Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections Message-ID: <20210111153917.GA22594@xps13> References: <20210108215838.470637-1-jcline@redhat.com> <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> MIME-Version: 1.0 In-Reply-To: <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jcline@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , Timothy Pearson , dri-devel@lists.freedesktop.org, Alex Deucher Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGksCgpPbiBNb24sIEphbiAxMSwgMjAyMSBhdCAwOTo1Mzo1NkFNICswMTAwLCBDaHJpc3RpYW4g S8O2bmlnIHdyb3RlOgo+IEFtIDA4LjAxLjIxIHVtIDIyOjU4IHNjaHJpZWIgSmVyZW15IENsaW5l Ogo+ID4gZGNuMjBfcmVzb3VyY2VfY29uc3RydWN0KCkgaW5jbHVkZXMgYSBudW1iZXIgb2Yga3ph bGxvYyhHRlBfS0VSTkVMKQo+ID4gY2FsbHMgd2hpY2ggY2FuIHNsZWVwLCBidXQga2VybmVsX2Zw dV9iZWdpbigpIGRpc2FibGVzIHByZWVtcHRpb24gYW5kCj4gPiBzbGVlcGluZyBpbiB0aGlzIGNv bnRleHQgaXMgaW52YWxpZC4KPiA+IAo+ID4gVGhlIG9ubHkgcGxhY2VzIHRoZSBGUFUgYXBwZWFy cyB0byBiZSByZXF1aXJlZCBpcyBpbiB0aGUKPiA+IGluaXRfc29jX2JvdW5kaW5nX2JveCgpIGZ1 bmN0aW9uIGFuZCB3aGVuIGNhbGN1bGF0aW5nIHRoZQo+ID4ge21pbixtYXh9X2ZpbGxfY2xrX21o ei4gTmFycm93IHRoZSBzY29wZSB0byBqdXN0IHRoZXNlIHR3byBwYXJ0cyB0bwo+ID4gYXZvaWQg c2xlZXBpbmcgd2hpbGUgdXNpbmcgdGhlIEZQVS4KPiA+IAo+ID4gRml4ZXM6IDdhOGEzNDMwYmUx NSAoImFtZGdwdTogV3JhcCBGUFUgZGVwZW5kZW50IGZ1bmN0aW9ucyBpbiBkYzIwIikKPiA+IENj OiBUaW1vdGh5IFBlYXJzb24gPHRwZWFyc29uQHJhcHRvcmVuZ2luZWVyaW5nLmNvbT4KPiA+IFNp Z25lZC1vZmYtYnk6IEplcmVteSBDbGluZSA8amNsaW5lQHJlZGhhdC5jb20+Cj4gCj4gR29vZCBj YXRjaCwgYnV0IEkgd291bGQgcmF0aGVyIHJlcGxhY2UgdGhlIGt6YWxsb2MoR0ZQX0tFUk5FTCkg d2l0aCBhCj4ga3phbGxvYyhHRlBfQVRPTUlDKSBmb3Igbm93Lgo+IAo+IFdlIGhhdmUgdG9ucyBv ZiBwcm9ibGVtcyB3aXRoIHRoaXMgRENfRlBfU1RBUlQoKS9EQ19GUF9FTkQoKSBhbm5vdGF0aW9u cyBhbmQKPiBhcmUgZXZlbiBpbiB0aGUgcHJvY2VzcyBvZiBtb3ZpbmcgdGhlbSBvdXQgb2YgdGhl IGZpbGUgYmVjYXVzZSB0aGUgY29tcGlsZXMKPiB0ZW5kIHRvIGNsdXR0ZXIgRlAgcmVnaXN0ZXJz IGV2ZW4gb3V0c2lkZSBvZiB0aGUgYW5ub3RhdGVkIHJhbmdlcyBvbiBzb21lCj4gYXJjaGl0ZWN0 dXJlcy4KPiAKClRoYW5rcyBmb3IgdGhlIHJldmlldy4gSXMgaXQgYWNjZXB0YWJsZSB0byBtb3Zl IHRoZSBEQ19GUF9FTkQoKQphbm5vdGF0aW9uIHVwIHRvIHRoZSBsYXN0IHVzYWdlPyBLZWVwaW5n IGl0IHdoZXJlIGl0IGlzIGlzIHByb2JhYmx5CmRvLWFibGUsIGJ1dCBjb3ZlcnMgdGhpbmdzIGxp a2UgY2FsbHMgdG8gcmVzb3VyY2VfY29uc3RydWN0KCkgd2hpY2gKbWFrZXMgdXNlIG9mIHN0cnVj dCByZXNvdXJjZV9jcmVhdGVfZnVuY3MuIEknbSBndWVzc2luZyBvbmx5IGEgc3ViLXNldApvZiB0 aGUgaW1wbGVtZW50YXRpb25zIGFyZSBjYWxsZWQgdmlhIHRoaXMgZnVuY3Rpb24sIGJ1dCBoYXZp bmcgYW4KaW50ZXJmYWNlIHdoaWNoIGNhbid0IHNsZWVwIHNvbWV0aW1lcyBkb2Vzbid0IHNvdW5k IGFwcGVhbGluZy4KCkhhcHB5IHRvIGRvIGl0LCBidXQgYmVmb3JlIEkgZ28gZG93biB0aGF0IHJv YWQgSSBqdXN0IHdhbnRlZCB0byBtYWtlCnN1cmUgdGhhdCdzIHdoYXQgeW91IGhhZCBpbiBtaW5k LgoKVGhhbmtzLApKZXJlbXkKCj4gPiAtLS0KPiA+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNw bGF5L2RjL2RjbjIwL2RjbjIwX3Jlc291cmNlLmMgfCA4ICsrKystLS0tCj4gPiAgIDEgZmlsZSBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjAvZGNuMjBfcmVzb3VyY2Uu YyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY24yMC9kY24yMF9yZXNvdXJjZS5j Cj4gPiBpbmRleCBlMDRlY2YwZmMwZGIuLmE0ZmE1YmYwMTZjMSAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9kY24yMC9kY24yMF9yZXNvdXJjZS5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvZGNuMjAvZGNuMjBfcmVzb3VyY2Uu Ywo+ID4gQEAgLTM2MjIsNiArMzYyMiw3IEBAIHN0YXRpYyBib29sIGluaXRfc29jX2JvdW5kaW5n X2JveChzdHJ1Y3QgZGMgKmRjLAo+ID4gICAJaWYgKGJiICYmIEFTSUNSRVZfSVNfTkFWSTEyX1Ao ZGMtPmN0eC0+YXNpY19pZC5od19pbnRlcm5hbF9yZXYpKSB7Cj4gPiAgIAkJaW50IGk7Cj4gPiAr CQlEQ19GUF9TVEFSVCgpOwo+ID4gICAJCWRjbjJfMF9udjEyX3NvYy5zcl9leGl0X3RpbWVfdXMg PQo+ID4gICAJCQkJZml4ZWQxNl90b19kb3VibGVfdG9fY3B1KGJiLT5zcl9leGl0X3RpbWVfdXMp Owo+ID4gICAJCWRjbjJfMF9udjEyX3NvYy5zcl9lbnRlcl9wbHVzX2V4aXRfdGltZV91cyA9Cj4g PiBAQCAtMzcyMSw2ICszNzIyLDcgQEAgc3RhdGljIGJvb2wgaW5pdF9zb2NfYm91bmRpbmdfYm94 KHN0cnVjdCBkYyAqZGMsCj4gPiAgIAkJCWRjbjJfMF9udjEyX3NvYy5jbG9ja19saW1pdHNbaV0u ZHJhbV9zcGVlZF9tdHMgPQo+ID4gICAJCQkJCWZpeGVkMTZfdG9fZG91YmxlX3RvX2NwdShiYi0+ Y2xvY2tfbGltaXRzW2ldLmRyYW1fc3BlZWRfbXRzKTsKPiA+ICAgCQl9Cj4gPiArCQlEQ19GUF9F TkQoKTsKPiA+ICAgCX0KPiA+ICAgCWlmIChwb29sLT5iYXNlLnBwX3NtdSkgewo+ID4gQEAgLTM3 NzcsOCArMzc3OSw2IEBAIHN0YXRpYyBib29sIGRjbjIwX3Jlc291cmNlX2NvbnN0cnVjdCgKPiA+ ICAgCWVudW0gZG1sX3Byb2plY3QgZG1sX3Byb2plY3RfdmVyc2lvbiA9Cj4gPiAgIAkJCWdldF9k bWxfcHJvamVjdF92ZXJzaW9uKGN0eC0+YXNpY19pZC5od19pbnRlcm5hbF9yZXYpOwo+ID4gLQlE Q19GUF9TVEFSVCgpOwo+ID4gLQo+ID4gICAJY3R4LT5kY19iaW9zLT5yZWdzID0gJmJpb3NfcmVn czsKPiA+ICAgCXBvb2wtPmJhc2UuZnVuY3MgPSAmZGNuMjBfcmVzX3Bvb2xfZnVuY3M7Cj4gPiBA QCAtMzk1OSw4ICszOTU5LDEwIEBAIHN0YXRpYyBib29sIGRjbjIwX3Jlc291cmNlX2NvbnN0cnVj dCgKPiA+ICAgCQkJCXJhbmdlcy5yZWFkZXJfd21fc2V0c1tpXS53bV9pbnN0ID0gaTsKPiA+ICAg CQkJCXJhbmdlcy5yZWFkZXJfd21fc2V0c1tpXS5taW5fZHJhaW5fY2xrX21oeiA9IFBQX1NNVV9X TV9TRVRfUkFOR0VfQ0xLX1VOQ09OU1RSQUlORURfTUlOOwo+ID4gICAJCQkJcmFuZ2VzLnJlYWRl cl93bV9zZXRzW2ldLm1heF9kcmFpbl9jbGtfbWh6ID0gUFBfU01VX1dNX1NFVF9SQU5HRV9DTEtf VU5DT05TVFJBSU5FRF9NQVg7Cj4gPiArCQkJCURDX0ZQX1NUQVJUKCk7Cj4gPiAgIAkJCQlyYW5n ZXMucmVhZGVyX3dtX3NldHNbaV0ubWluX2ZpbGxfY2xrX21oeiA9IChpID4gMCkgPyAobG9hZGVk X2JiLT5jbG9ja19saW1pdHNbaSAtIDFdLmRyYW1fc3BlZWRfbXRzIC8gMTYpICsgMSA6IDA7Cj4g PiAgIAkJCQlyYW5nZXMucmVhZGVyX3dtX3NldHNbaV0ubWF4X2ZpbGxfY2xrX21oeiA9IGxvYWRl ZF9iYi0+Y2xvY2tfbGltaXRzW2ldLmRyYW1fc3BlZWRfbXRzIC8gMTY7Cj4gPiArCQkJCURDX0ZQ X0VORCgpOwo+ID4gICAJCQkJcmFuZ2VzLm51bV9yZWFkZXJfd21fc2V0cyA9IGkgKyAxOwo+ID4g ICAJCQl9Cj4gPiBAQCAtNDEyNSwxMiArNDEyNywxMCBAQCBzdGF0aWMgYm9vbCBkY24yMF9yZXNv dXJjZV9jb25zdHJ1Y3QoCj4gPiAgIAkJcG9vbC0+YmFzZS5vZW1fZGV2aWNlID0gTlVMTDsKPiA+ ICAgCX0KPiA+IC0JRENfRlBfRU5EKCk7Cj4gPiAgIAlyZXR1cm4gdHJ1ZTsKPiA+ICAgY3JlYXRl X2ZhaWw6Cj4gPiAtCURDX0ZQX0VORCgpOwo+ID4gICAJZGNuMjBfcmVzb3VyY2VfZGVzdHJ1Y3Qo cG9vbCk7Cj4gPiAgIAlyZXR1cm4gZmFsc2U7Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F1DC433DB for ; Mon, 11 Jan 2021 15:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDACB20637 for ; Mon, 11 Jan 2021 15:41:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730472AbhAKPku (ORCPT ); Mon, 11 Jan 2021 10:40:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50817 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727180AbhAKPkt (ORCPT ); Mon, 11 Jan 2021 10:40:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610379562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=UGpgWj79HBcdJnkBtUIGCZqpsA1rgF0hz/DFMjZHuYug6vpA4KOagjokW6GGCDOnPOXy/I WtpLn9zvsSG9Hpw/8bhHHCQj8qrP2yO52FgTgzx5VDrtOQJQhchCugxLHDn7ImNudFdUQN bo0YbxhPoItwWo1XdJeas/XaIGt23fQ= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-JFgxkQL4NNWcvie_BtvaBA-1; Mon, 11 Jan 2021 10:39:21 -0500 X-MC-Unique: JFgxkQL4NNWcvie_BtvaBA-1 Received: by mail-io1-f71.google.com with SMTP id l5so12800794ioj.17 for ; Mon, 11 Jan 2021 07:39:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=V6s22bNSoq1L+NIFn/JvX6d51nE1mLRjnfTwZ0WeTw4=; b=gauq6b0ipw2A2JSmE83BytXxwToyX7Kc4B52hF50ZBPCOSpPX+MI5ftYsGkuDfZCYP dRNQzc+LrsSEKTJytMZ7vBbvAi6OLAQvLApc06JL5xRrnWqUw3NyzMG4n35d0wgahe/i UTZQQs+hwZsp7H8zj80ecGVkuDckQjtiaxoz20hyPk0x/gk07t1TX3Zi+BlAm9t5N7qu J+CpE1KUZtUruTot/IHgEKtX3SGCMvCeMRQUmOMRo2UTtn4c7ARWtEL0LSJOR+PBfYwc 8Hm5+5bPKp4plgrtUx0Lr1y2rfB/GWaHw37IO0YQPI6/sxWckrYj4tmTtBob2iotZnLH M+/Q== X-Gm-Message-State: AOAM531eKY9D6Eihg2Y1JuaXrzqKUeK50WlI4DISrFkxQNbD1Rv4fUux 0LKuOG+rY9blyNuA0fNnvZNWkAvdx/2zS7wvO09XHowyIuGA4bXKX+tcoWJMKMqDWBgoslItHzG Wh0xvS+Ty6j+G/7WHs1A/S7yL X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547582ilr.207.1610379560551; Mon, 11 Jan 2021 07:39:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzlggvM+nwzezd73mKCuiQILg/y8Tnj4twPqnA644Y3DXvue24trNEi0s1w98pXs6fxCdnvw== X-Received: by 2002:a92:cf44:: with SMTP id c4mr15547567ilr.207.1610379560359; Mon, 11 Jan 2021 07:39:20 -0800 (PST) Received: from xps13 ([2605:a601:a63a:4d01:c3c1:7008:ba35:96]) by smtp.gmail.com with ESMTPSA id t2sm16862182ili.31.2021.01.11.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:39:19 -0800 (PST) Date: Mon, 11 Jan 2021 10:39:17 -0500 From: Jeremy Cline To: Christian =?utf-8?B?S8O2bmln?= Cc: Harry Wentland , Leo Li , Alex Deucher , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Timothy Pearson Subject: Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections Message-ID: <20210111153917.GA22594@xps13> References: <20210108215838.470637-1-jcline@redhat.com> <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3c94f9d6-501d-271c-ca83-1cf4229cb3ab@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote: > Am 08.01.21 um 22:58 schrieb Jeremy Cline: > > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) > > calls which can sleep, but kernel_fpu_begin() disables preemption and > > sleeping in this context is invalid. > > > > The only places the FPU appears to be required is in the > > init_soc_bounding_box() function and when calculating the > > {min,max}_fill_clk_mhz. Narrow the scope to just these two parts to > > avoid sleeping while using the FPU. > > > > Fixes: 7a8a3430be15 ("amdgpu: Wrap FPU dependent functions in dc20") > > Cc: Timothy Pearson > > Signed-off-by: Jeremy Cline > > Good catch, but I would rather replace the kzalloc(GFP_KERNEL) with a > kzalloc(GFP_ATOMIC) for now. > > We have tons of problems with this DC_FP_START()/DC_FP_END() annotations and > are even in the process of moving them out of the file because the compiles > tend to clutter FP registers even outside of the annotated ranges on some > architectures. > Thanks for the review. Is it acceptable to move the DC_FP_END() annotation up to the last usage? Keeping it where it is is probably do-able, but covers things like calls to resource_construct() which makes use of struct resource_create_funcs. I'm guessing only a sub-set of the implementations are called via this function, but having an interface which can't sleep sometimes doesn't sound appealing. Happy to do it, but before I go down that road I just wanted to make sure that's what you had in mind. Thanks, Jeremy > > --- > > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c > > index e04ecf0fc0db..a4fa5bf016c1 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c > > @@ -3622,6 +3622,7 @@ static bool init_soc_bounding_box(struct dc *dc, > > if (bb && ASICREV_IS_NAVI12_P(dc->ctx->asic_id.hw_internal_rev)) { > > int i; > > + DC_FP_START(); > > dcn2_0_nv12_soc.sr_exit_time_us = > > fixed16_to_double_to_cpu(bb->sr_exit_time_us); > > dcn2_0_nv12_soc.sr_enter_plus_exit_time_us = > > @@ -3721,6 +3722,7 @@ static bool init_soc_bounding_box(struct dc *dc, > > dcn2_0_nv12_soc.clock_limits[i].dram_speed_mts = > > fixed16_to_double_to_cpu(bb->clock_limits[i].dram_speed_mts); > > } > > + DC_FP_END(); > > } > > if (pool->base.pp_smu) { > > @@ -3777,8 +3779,6 @@ static bool dcn20_resource_construct( > > enum dml_project dml_project_version = > > get_dml_project_version(ctx->asic_id.hw_internal_rev); > > - DC_FP_START(); > > - > > ctx->dc_bios->regs = &bios_regs; > > pool->base.funcs = &dcn20_res_pool_funcs; > > @@ -3959,8 +3959,10 @@ static bool dcn20_resource_construct( > > ranges.reader_wm_sets[i].wm_inst = i; > > ranges.reader_wm_sets[i].min_drain_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MIN; > > ranges.reader_wm_sets[i].max_drain_clk_mhz = PP_SMU_WM_SET_RANGE_CLK_UNCONSTRAINED_MAX; > > + DC_FP_START(); > > ranges.reader_wm_sets[i].min_fill_clk_mhz = (i > 0) ? (loaded_bb->clock_limits[i - 1].dram_speed_mts / 16) + 1 : 0; > > ranges.reader_wm_sets[i].max_fill_clk_mhz = loaded_bb->clock_limits[i].dram_speed_mts / 16; > > + DC_FP_END(); > > ranges.num_reader_wm_sets = i + 1; > > } > > @@ -4125,12 +4127,10 @@ static bool dcn20_resource_construct( > > pool->base.oem_device = NULL; > > } > > - DC_FP_END(); > > return true; > > create_fail: > > - DC_FP_END(); > > dcn20_resource_destruct(pool); > > return false; >