From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wesley Zhao <zhaowei1102@thundersoft.com>
Cc: akpm@linux-foundation.org, keescook@chromium.org,
tglx@linutronix.de, kerneldev@karsmulder.nl,
nivedita@alum.mit.edu, joe@perches.com, gpiccoli@canonical.com,
aquini@redhat.com, gustavoars@kernel.org, ojeda@kernel.org,
ndesaulniers@gooogle.com, linux-kernel@vger.kernel.org,
david@redhat.com, dan.j.williams@intel.com, guohanjun@huawei.com,
mchehab+huawei@kernel.org
Subject: Re: [PATCH 1/2] lib/cmdline: add new function get_option_ull()
Date: Mon, 11 Jan 2021 19:22:59 +0200 [thread overview]
Message-ID: <20210111172259.GZ4077@smile.fi.intel.com> (raw)
In-Reply-To: <1610382798-4528-1-git-send-email-zhaowei1102@thundersoft.com>
On Mon, Jan 11, 2021 at 08:33:17AM -0800, Wesley Zhao wrote:
> From: "Wesley.Zhao" <zhaowei1102@thundersoft.com>
>
> In the future we would pass the unsigned long long parameter
> like(0x123456781234) in cmdline on the 64bit platform, so add a new
> option parse function get_option_ull()
No negative numbers?
No test cases?
No user?
Please, address above.
Besides that, consider to deduplicate (like it's done in simple_strto*() family
of functions), so we don't have two implementation that are basically do the
same, only put result to a different type of variable.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-01-11 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 16:33 [PATCH 1/2] lib/cmdline: add new function get_option_ull() Wesley Zhao
2021-01-11 16:33 ` [PATCH 2/2] resource: Make it possible to reserve memory on 64bit platform Wesley Zhao
2021-01-11 17:24 ` David Hildenbrand
2021-01-11 18:03 ` Andy Shevchenko
2021-01-11 17:22 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111172259.GZ4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=guohanjun@huawei.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=ndesaulniers@gooogle.com \
--cc=nivedita@alum.mit.edu \
--cc=ojeda@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhaowei1102@thundersoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.