From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-iio@vger.kernel.orgi, Luca Ceresoli <luca@lucaceresoli.net>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] i2c: smbus: use get/put_unaligned_le16 when working with word data
Date: Mon, 11 Jan 2021 22:04:11 +0100 [thread overview]
Message-ID: <20210111210411.GC17475@kunai> (raw)
In-Reply-To: <20191118073659.7yomkvqthuenqjpu@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
> You claim this was clearer. For me it is not. With the explicit
> assignment to msgbuf0[1] and msbbuf0[2] it is immediatly obvious to me
> what happens. Even though the endianness is explicitly mentioned in
> put_unaligned_le16, it takes a bit longer for me to understand what it
> does and which part of data->word ends up in which byte.
Seems like I am on Uwe's side again. For me, the current way is
also more readable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-11 21:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 20:31 [PATCH v3 0/3] Use void pointers instead of char in I2C transfer APIs Dmitry Torokhov
2019-11-12 20:31 ` Dmitry Torokhov
2019-11-12 20:31 ` [PATCH v3 1/3] i2c: use void pointers for supplying data for reads and writes Dmitry Torokhov
2019-11-12 20:31 ` Dmitry Torokhov
2019-11-13 9:47 ` Luca Ceresoli
2019-11-13 9:47 ` Luca Ceresoli
2019-11-18 7:43 ` Uwe Kleine-König
2019-11-18 7:43 ` Uwe Kleine-König
2019-11-18 8:04 ` Dmitry Torokhov
2019-11-18 8:04 ` Dmitry Torokhov
2019-11-18 8:38 ` Uwe Kleine-König
2019-11-18 8:38 ` Uwe Kleine-König
2021-01-11 21:02 ` Wolfram Sang
2019-11-12 20:31 ` [PATCH v3 2/3] i2c: smbus: use get/put_unaligned_le16 when working with word data Dmitry Torokhov
2019-11-13 9:47 ` Luca Ceresoli
2019-11-13 19:39 ` Dmitry Torokhov
2019-11-14 9:23 ` Luca Ceresoli
2019-11-18 7:36 ` Uwe Kleine-König
2021-01-11 21:04 ` Wolfram Sang [this message]
2019-11-12 20:31 ` [PATCH v3 3/3] i2c: smbus: switch from loops to memcpy Dmitry Torokhov
2019-11-13 9:47 ` Luca Ceresoli
2019-11-18 7:47 ` Uwe Kleine-König
2019-11-18 8:09 ` Dmitry Torokhov
2019-11-18 8:47 ` Uwe Kleine-König
2021-01-11 21:04 ` Wolfram Sang
2021-01-11 21:01 ` [PATCH v3 0/3] Use void pointers instead of char in I2C transfer APIs Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111210411.GC17475@kunai \
--to=wsa@the-dreams.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.orgi \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.