From: Christoph Hellwig <hch@lst.de>
To: Michal Krakowiak <michal.krakowiak@linux.intel.com>
Cc: Michal Krakowiak <michal.krakowiak@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: trace: parse format nvm command in detail
Date: Tue, 12 Jan 2021 09:33:00 +0100 [thread overview]
Message-ID: <20210112083300.GA25601@lst.de> (raw)
In-Reply-To: <20210111201552.GA90320@michal-desk>
On Mon, Jan 11, 2021 at 09:15:52PM +0100, Michal Krakowiak wrote:
> Like Dan, I really appreciate having the trace parsed in the kernel. I
> understand the concerns. What about having both: detailed parsing and raw
> bytes? It does not seem to me like a big deal to append a field with the
> raw data even if detailed parsing is implemented. Let the parsing extends
> the raw data instead of replacing them. This will result in the detailed
> human-friendly output (which is nice to have) while not losing data in the
> future (in the case that a new unsupported by parser field appears).
That is how the kernel trace events work, including for the block layer.
blktrace is a separate piece of software that attaches to the raw
tracepoints and adds its own handling, so I don't think it is the right
comparism here.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-12 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:53 [PATCH] nvme: trace: parse format nvm command in detail Michal Krakowiak
2021-01-04 16:02 ` Keith Busch
2021-01-06 9:00 ` Christoph Hellwig
2021-01-08 22:34 ` Keith Busch
2021-01-09 0:12 ` Dan Williams
2021-01-11 17:01 ` Keith Busch
2021-01-11 17:10 ` Dan Williams
2021-01-11 17:50 ` Keith Busch
2021-01-11 20:15 ` Michal Krakowiak
2021-01-12 8:33 ` Christoph Hellwig [this message]
2021-01-05 19:31 ` Minwoo Im
2021-01-27 17:46 ` Christoph Hellwig
2021-01-28 12:25 ` Michal Krakowiak
2021-01-28 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112083300.GA25601@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michal.krakowiak@intel.com \
--cc=michal.krakowiak@linux.intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.