From: Wolfram Sang <wsa@kernel.org>
To: Mikko Perttunen <cyndis@kapsi.fi>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com, talho@nvidia.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Muhammed Fazal <mfazale@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag
Date: Tue, 12 Jan 2021 11:26:05 +0100 [thread overview]
Message-ID: <20210112102605.GB973@kunai> (raw)
In-Reply-To: <92fb3f30-a08c-eb42-0741-affc3ceae0c0@kapsi.fi>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
> > I wonder if bailing out on an unknown flag shouldn't be revisited in
> > general? I mean this will happen again when a new I2C_M_* flag is
> > introduced.
> >
>
> If it's guaranteed that any new flags are optional to handle by the driver,
> than that is certainly better. I'll post a v3 with that approach.
If there will be a new flag, it is highly likely that it will handle
some corner case which only gets applied when there is a I2C_FUNC_* flag
guarding it. If the new flag turns out to be mandatory, the (poor)
author needs to check with all existing drivers anyhow.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-12 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 15:58 [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag Mikko Perttunen
2021-01-11 21:42 ` Wolfram Sang
2021-01-12 10:19 ` Mikko Perttunen
2021-01-12 10:26 ` Wolfram Sang [this message]
2021-01-12 10:27 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112102605.GB973@kunai \
--to=wsa@kernel.org \
--cc=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mfazale@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.