From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F0CEC433DB for ; Tue, 12 Jan 2021 14:37:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0705620771 for ; Tue, 12 Jan 2021 14:37:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0705620771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fu86B0QaCvZvgCYyh0EsAfjw7UphZZpAkKZ393YriO8=; b=Ft7y/5sPOKF2mt7cDwPB19MdJ WGuuHAIPkcYMyH2vQghjIeQVxj6VDT+UIlOYL4UHEoKYBMDcJjfA8EtckBRXtguBR7jE2fylFAd61 y1LT1Z1IFSdjYiUg7u7hZY46Mm+WQN4Vp+p3t+Hqv5uCV6JmPv2mLZQai7YArKuiuEs2xc+Nr95b6 hpxbNbmnaHcfDpvasN2I5f8mbn9F3lFC5RAGzfr+NFRLcfUP3EIKi+1Y/i4md43S7tyF6KuNM0jAr r2OXEIkJOgKl8t118ogqmjG5jr1E4Q+H4WFxafqE0X6CRlMsxQSNhEYSnQVGW0EnqDjKnDYmUGbQa XumFmHQgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzKm1-0003ek-GW; Tue, 12 Jan 2021 14:35:53 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzKlr-0003az-S1 for linux-mtd@lists.infradead.org; Tue, 12 Jan 2021 14:35:48 +0000 X-Originating-IP: 109.220.210.98 Received: from xps13 (lfbn-tou-1-1619-98.w109-220.abo.wanadoo.fr [109.220.210.98]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 99CD140002; Tue, 12 Jan 2021 14:35:35 +0000 (UTC) Date: Tue, 12 Jan 2021 15:35:34 +0100 From: Miquel Raynal To: Adam Ford Subject: Re: [PATCH 04/20] mtd: nand: ecc-bch: Stop exporting the private structure Message-ID: <20210112153534.5ba93cde@xps13> In-Reply-To: <20210111112027.7cbda0ba@xps13> References: <20200929230124.31491-1-miquel.raynal@bootlin.com> <20200929230124.31491-5-miquel.raynal@bootlin.com> <20210111112027.7cbda0ba@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_093544_037543_04D1C13E X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , ycllin@mxic.com.tw, linux-mtd@lists.infradead.org, Thomas Petazzoni , Linux-OMAP Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQWRhbSwKCk1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+IHdyb3Rl IG9uIE1vbiwgMTEgSmFuIDIwMjEKMTE6MjA6MjcgKzAxMDA6Cgo+IEhpIEFkYW0sCj4gCj4gQWRh bSBGb3JkIDxhZm9yZDE3M0BnbWFpbC5jb20+IHdyb3RlIG9uIFNhdCwgOSBKYW4gMjAyMSAwODo0 Njo0NCAtMDYwMDoKPiAKPiA+IE9uIFR1ZSwgU2VwIDI5LCAyMDIwIGF0IDY6MDkgUE0gTWlxdWVs IFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4gd3JvdGU6ICAKPiA+ID4KPiA+ID4g VGhlIE5BTkQgQkNIIGNvbnRyb2wgc3RydWN0dXJlIGhhcyBub3RoaW5nIHRvIGRvIG91dHNpZGUg b2YgdGhpcwo+ID4gPiBkcml2ZXIsIGFsbCB1c2VycyBvZiB0aGUgbmFuZF9iY2hfaW5pdC9mcmVl KCkgZnVuY3Rpb25zIGp1c3Qgc2F2ZSBpdAo+ID4gPiB0byBjaGlwLT5lY2MucHJpdiBzbyBkbyBp dCBpbiB0aGlzIGRyaXZlciBkaXJlY3RseSBhbmQgcmV0dXJuIGEKPiA+ID4gcmVndWxhciBlcnJv ciBjb2RlIGluc3RlYWQuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1pcXVlbCBSYXluYWwg PG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gPiA+IC0tLSAgICAKPiA+IAo+ID4gU3RhcnRp bmcgd2l0aCB0aGlzIGNvbW1pdDogIDNjMGZlMzZhYmViZSwgdGhlIGtlcm5lbCBlaXRoZXIgZG9l c24ndAo+ID4gYnVpbGQgb3IgcmV0dXJucyBlcnJvcnMgb24gc29tZSBvbWFwMnBsdXMgZGV2aWNl cyB3aXRoIHRoZSBmb2xsb3dpbmcKPiA+IGVycm9yOgo+ID4gCj4gPiAgICAgbmFuZDogZGV2aWNl IGZvdW5kLCBNYW51ZmFjdHVyZXIgSUQ6IDB4MmMsIENoaXAgSUQ6IDB4YmMKPiA+ICAgICBuYW5k OiBNaWNyb24gTVQyOUY0RzE2QUJCREEzVwo+ID4gICAgIG5hbmQ6IDUxMiBNaUIsIFNMQywgZXJh c2Ugc2l6ZTogMTI4IEtpQiwgcGFnZSBzaXplOiAyMDQ4LCBPT0Igc2l6ZTogNjQKPiA+ICAgICBu YW5kOiB1c2luZyBPTUFQX0VDQ19CQ0g4X0NPREVfSFdfREVURUNUSU9OX1NXCj4gPiAgICAgSW52 YWxpZCBFQ0MgbGF5b3V0Cj4gPiAgICAgb21hcDItbmFuZCAzMDAwMDAwMC5uYW5kOiB1bmFibGUg dG8gdXNlIEJDSCBsaWJyYXJ5Cj4gPiAgICAgb21hcDItbmFuZDogcHJvYmUgb2YgMzAwMDAwMDAu bmFuZCBmYWlsZWQgd2l0aCBlcnJvciAtMjIKPiA+ICAgICA4PC0tLSBjdXQgaGVyZSAtLS0KPiA+ IAo+ID4gVGhlcmUgYXJlIGZldyBjb21taXRzIHVzaW5nIGdpdCBiaXNlY3QgdGhhdCBoYXZlIGJ1 aWxkIGVycm9ycywgc28gaXQKPiA+IHdhc24ndCBwb3NzaWJsZSBmb3IgbWUgdG8gZGV0ZXJtaW5l IHRoZSBleGFjdCBjb21taXQgdGhhdCBicm9rZSB0aGUKPiA+IEVDQy4gIElmIHRoZSBidWlsZCBm YWlsZWQsIEkgbWFya2VkIGl0IGFzICdiYWQnIHRvIGdpdCBiaXNlY3QuICAKPiAKPiBJIGFtIHNv cnJ5IHRvIGhlYXIgdGhhdCwgSSByZWd1bGFybHkgcmViYXNlIHdpdGggYSBtYWtlIHJ1biBiZXR3 ZWVuIGVhY2gKPiBwaWNrIGFuZCBwdXNoIG15IGJyYW5jaGVzIHRvIGEgMC1kYXkgcmVwb3NpdG9y eSB0byBoYXZlIHJvYm90cyBjaGVjawo+IGZvciBzdWNoIGVycm9ycywgYnV0IHNvbWV0aW1lcyBJ IGZhaWwuCj4gCj4gPiBOZXdlciBjb21taXRzIGhhdmUgcmVtZWRpZWQgdGhlIGJ1aWxkIGlzc3Vl LCBidXQgdGhlIEludmFsaWQgRUNDCj4gPiBsYXlvdXQgZXJyb3Igc3RpbGwgZXhpc3RzIGFzIG9m IDUuMTEtUkMyLiAgCj4gCj4gT2sgc28gbGV0J3MgZm9jdXMgb24gdGhlc2UuCj4gCj4gPiBEbyB5 b3UgaGF2ZSBhbnkgc3VnZ2VzdGlvbnMgb24gd2hhdCBJIGNhbiBkbyB0byByZW1lZHkgdGhpcz8g IEkgYW0KPiA+IHdpbGxpbmcgdG8gdHJ5IGFuZCB0ZXN0LiAgCj4gCj4gR2xhZCB0byBoZWFyIHRo YXQuCj4gCj4gQ2FuIHlvdSBzaGFyZSB0aGUgTkFORCBjb250cm9sbGVyIERUIG5vZGUgeW91IGFy ZSB1c2luZz8KPiAKPiBBbHNvLCBjYW4geW91IHBsZWFzZSBhZGQgYSBmZXcgcHJpbnRrJ3MgbGlr ZSBiZWxvdyBhbmQgZ2l2ZSBtZSB0aGUKPiBvdXRwdXQ/CgpXaWxsIHlvdSBoYXZlIHRoZSB0aW1l IHRvIGNoZWNrIHRoZXNlIHNvb24/IEkgYW0gcmVhZHkgdG8gaGVscCBhbmQKd291bGQgbGlrZSB0 byBmaXggaXQgYXNhcC4KCkNoZWVycywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120ECC433E0 for ; Tue, 12 Jan 2021 14:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB2882312D for ; Tue, 12 Jan 2021 14:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725957AbhALOgU convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2021 09:36:20 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45053 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731880AbhALOgU (ORCPT ); Tue, 12 Jan 2021 09:36:20 -0500 X-Greylist: delayed 101707 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jan 2021 09:36:19 EST X-Originating-IP: 109.220.210.98 Received: from xps13 (lfbn-tou-1-1619-98.w109-220.abo.wanadoo.fr [109.220.210.98]) (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 99CD140002; Tue, 12 Jan 2021 14:35:35 +0000 (UTC) Date: Tue, 12 Jan 2021 15:35:34 +0100 From: Miquel Raynal To: Adam Ford Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Julien Su , ycllin@mxic.com.tw, Thomas Petazzoni , Linux-OMAP Subject: Re: [PATCH 04/20] mtd: nand: ecc-bch: Stop exporting the private structure Message-ID: <20210112153534.5ba93cde@xps13> In-Reply-To: <20210111112027.7cbda0ba@xps13> References: <20200929230124.31491-1-miquel.raynal@bootlin.com> <20200929230124.31491-5-miquel.raynal@bootlin.com> <20210111112027.7cbda0ba@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Adam, Miquel Raynal wrote on Mon, 11 Jan 2021 11:20:27 +0100: > Hi Adam, > > Adam Ford wrote on Sat, 9 Jan 2021 08:46:44 -0600: > > > On Tue, Sep 29, 2020 at 6:09 PM Miquel Raynal wrote: > > > > > > The NAND BCH control structure has nothing to do outside of this > > > driver, all users of the nand_bch_init/free() functions just save it > > > to chip->ecc.priv so do it in this driver directly and return a > > > regular error code instead. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > > Starting with this commit: 3c0fe36abebe, the kernel either doesn't > > build or returns errors on some omap2plus devices with the following > > error: > > > > nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xbc > > nand: Micron MT29F4G16ABBDA3W > > nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 > > nand: using OMAP_ECC_BCH8_CODE_HW_DETECTION_SW > > Invalid ECC layout > > omap2-nand 30000000.nand: unable to use BCH library > > omap2-nand: probe of 30000000.nand failed with error -22 > > 8<--- cut here --- > > > > There are few commits using git bisect that have build errors, so it > > wasn't possible for me to determine the exact commit that broke the > > ECC. If the build failed, I marked it as 'bad' to git bisect. > > I am sorry to hear that, I regularly rebase with a make run between each > pick and push my branches to a 0-day repository to have robots check > for such errors, but sometimes I fail. > > > Newer commits have remedied the build issue, but the Invalid ECC > > layout error still exists as of 5.11-RC2. > > Ok so let's focus on these. > > > Do you have any suggestions on what I can do to remedy this? I am > > willing to try and test. > > Glad to hear that. > > Can you share the NAND controller DT node you are using? > > Also, can you please add a few printk's like below and give me the > output? Will you have the time to check these soon? I am ready to help and would like to fix it asap. Cheers, Miquèl