From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD780C433DB for ; Tue, 12 Jan 2021 20:04:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4979622202 for ; Tue, 12 Jan 2021 20:04:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4979622202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610481873; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Nu7oh/SSpLGoTkRA9TqhpX2JIpWnE0ufKKfte/EimYo=; b=TbHBrqAlmVDdAtGE0cknH965aQlW0qzfRuRUhEaOVF232qvNI59udwrfqVXca1p74lg1u4 Dr2RxmFhJ8w+yiu/xHPqw+P0svZkjtb7h8gJk63twoFHv0EO6JenLykswFV7jeRtXs9fyL Y1y3sygHQ6UhPSuXkWncedBNZB1Z/dA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-cBe2qeUFNXOvN_9ldOpyqw-1; Tue, 12 Jan 2021 15:04:29 -0500 X-MC-Unique: cBe2qeUFNXOvN_9ldOpyqw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22239107ACF8; Tue, 12 Jan 2021 20:04:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A119E1F0; Tue, 12 Jan 2021 20:04:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E0011180954D; Tue, 12 Jan 2021 20:04:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10CK4L0w005513 for ; Tue, 12 Jan 2021 15:04:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3726C1975F; Tue, 12 Jan 2021 20:04:21 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 545F419744; Tue, 12 Jan 2021 20:04:18 +0000 (UTC) Date: Tue, 12 Jan 2021 15:04:17 -0500 From: Mike Snitzer To: Mikulas Patocka Message-ID: <20210112200417.GA15241@redhat.com> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com Subject: Re: [dm-devel] dm-integrity: fix the maximum number of arguments X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jan 12 2021 at 2:54pm -0500, Mikulas Patocka wrote: > Advance the maximum number of arguments to 15. > > Signed-off-by: Mikulas Patocka > Cc: stable@vger.kernel.org # v4.19+ > > --- > drivers/md/dm-integrity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/md/dm-integrity.c > =================================================================== > --- linux-2.6.orig/drivers/md/dm-integrity.c 2021-01-12 20:45:23.000000000 +0100 > +++ linux-2.6/drivers/md/dm-integrity.c 2021-01-12 20:46:15.000000000 +0100 > @@ -3792,7 +3792,7 @@ static int dm_integrity_ctr(struct dm_ta > unsigned extra_args; > struct dm_arg_set as; > static const struct dm_arg _args[] = { > - {0, 9, "Invalid number of feature args"}, > + {0, 15, "Invalid number of feature args"}, > }; > unsigned journal_sectors, interleave_sectors, buffer_sectors, journal_watermark, sync_msec; > bool should_write_sb; Can you please expand on which args weren't accounted for? Which commit introduced the problem? (I'd like a "Fixes:" reference) Thanks, Mike -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel