From: Jason Gunthorpe <jgg@nvidia.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>, Yishai Hadas <yishaih@nvidia.com>
Cc: <linux-rdma@vger.kernel.org>, <leon@kernel.org>
Subject: Re: [PATCH 1/2] RDMA/uverbs: Don't set rcq if qp_type is IB_QPT_XRC_INI
Date: Tue, 12 Jan 2021 16:09:25 -0400 [thread overview]
Message-ID: <20210112200925.GA20208@nvidia.com> (raw)
In-Reply-To: <20201216071755.149449-1-yangx.jy@cn.fujitsu.com>
On Wed, Dec 16, 2020 at 03:17:54PM +0800, Xiao Yang wrote:
> INI QP doesn't require receive CQ.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> drivers/infiniband/core/uverbs_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index 418d133a8fb0..d8bc8ea3ad1e 100644
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -1345,7 +1345,7 @@ static int create_qp(struct uverbs_attr_bundle *attrs,
> if (has_sq)
> scq = uobj_get_obj_read(cq, UVERBS_OBJECT_CQ,
> cmd->send_cq_handle, attrs);
> - if (!ind_tbl)
> + if (!ind_tbl && cmd->qp_type != IB_QPT_XRC_INI)
> rcq = rcq ?: scq;
Hmm, this does make it consistent with the UVERBS_METHOD_QP_CREATE
flow which does set attr.recv_cq to NULL if the user didn't specify one.
However this has been like this since the beginning - what are you
doing that this detail matters?
Jason
next prev parent reply other threads:[~2021-01-12 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 7:17 [PATCH 1/2] RDMA/uverbs: Don't set rcq if qp_type is IB_QPT_XRC_INI Xiao Yang
2020-12-16 7:17 ` [PATCH 2/2] RDMA/rxe: Add check for supported QP types Xiao Yang
2021-01-12 20:15 ` Jason Gunthorpe
2021-01-12 20:09 ` Jason Gunthorpe [this message]
2021-01-14 8:58 ` [PATCH 1/2] RDMA/uverbs: Don't set rcq if qp_type is IB_QPT_XRC_INI Xiao Yang
2021-01-15 19:23 ` Jason Gunthorpe
2021-01-18 7:58 ` Xiao Yang
2021-01-21 17:05 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112200925.GA20208@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.