From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH net] Revert "virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()"
Date: Wed, 13 Jan 2021 11:14:14 -0500 [thread overview]
Message-ID: <20210113111337-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CANn89iKOiZhOZ1jstMyzfx6KsjfcNmNJ4EFxq=ZbweQyjRtv0w@mail.gmail.com>
On Wed, Jan 13, 2021 at 04:53:38PM +0100, Eric Dumazet wrote:
> On Wed, Jan 13, 2021 at 4:51 PM Eric Dumazet <edumazet@google.com> wrote:
> >
>
> > To be clear, I now think the revert is not needed.
> >
> > I will post instead a patch that should take care of the problem both
> > for virtio and napi_get_frags() tiny skbs
>
> Then later, we might change things so that the sk_buff cache being
> changed by Alexander Lobakin
> can also be used for these allocations.
That sounds like a great idea.
--
MST
prev parent reply other threads:[~2021-01-13 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 5:12 [PATCH net] Revert "virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()" Eric Dumazet
2021-01-13 5:28 ` Eric Dumazet
2021-01-13 9:52 ` Michael S. Tsirkin
2021-01-13 9:57 ` Eric Dumazet
2021-01-13 15:44 ` Paolo Abeni
2021-01-13 15:51 ` Eric Dumazet
2021-01-13 15:53 ` Eric Dumazet
2021-01-13 16:14 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113111337-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gthelen@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.