From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223FDC433E6 for ; Wed, 13 Jan 2021 18:31:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C121233ED for ; Wed, 13 Jan 2021 18:31:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C121233ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0rS7kVSEqyGBQUbn5r61OeXTJR/DuIgaX5dsFCIyHUo=; b=Drup7Rgdnx9Gi7oECLXO/R6UY UN/s3LIrR+iEHUQY1QuPxl+o1CmVfeHx637OpZFhOVZSrKLw+/7ZVXgL7zqphEQ2bHIAnMPBgezLq oRhxdIedEPKsy5hpoYenmaFDoN2MAXjnsxpnQaAMOj27VAGFsxynb5ZYcXj4+pwUPcCd2DhzubBKS MzZIqjVOUJcvOY3YR4almIgnK9zeGDIY+/GV1T7dSUpZqkhzy20Mu80dySJGHcdlOOm3053lw908u pO04ibO9DqRBKbnET8CaF5DNtHRkkAitviQC0NpHLqI5LAk9tfeYtKw8xySDzOCg51miOKAXBwyCI Dflblrxfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzkvu-0001bd-E7; Wed, 13 Jan 2021 18:31:50 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzkvr-0001b5-9J for linux-nvme@lists.infradead.org; Wed, 13 Jan 2021 18:31:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 920E468AFE; Wed, 13 Jan 2021 19:31:42 +0100 (CET) Date: Wed, 13 Jan 2021 19:31:42 +0100 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH] nvme-tcp: fix possible data corruption with bio merges Message-ID: <20210113183142.GA19254@lst.de> References: <20210113182449.1580181-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210113182449.1580181-1-sagi@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_133147_776650_F7EE3693 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > static inline size_t nvme_tcp_req_cur_length(struct nvme_tcp_request *req) > { > - return min_t(size_t, req->iter.bvec->bv_len - req->iter.iov_offset, > - req->pdu_len - req->pdu_sent); > + return min_t(size_t, req->iter.count, > + min_t(size_t, req->iter.bvec->bv_len - req->iter.iov_offset, > + req->pdu_len - req->pdu_sent)); We are not supposed to directly poke into an iov_iter. I suspect this should be something like: return min_t(size_t, iov_iter_single_seg_count(&req->iter), req->pdu_len - req->pdu_sent); _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme