All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Piotr Figiel <figiel@google.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Alexey Gladkov <gladkov.alexey@gmail.com>,
	Christian Brauner <christian.brauner@ubuntu.com>,
	Michel Lespinasse <walken@google.com>,
	Bernd Edlinger <bernd.edlinger@hotmail.de>,
	Andrei Vagin <avagin@gmail.com>,
	mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, posk@google.com,
	kyurtsever@google.com, ckennelly@google.com, pjt@google.com
Subject: Re: [PATCH] fs/proc: Expose RSEQ configuration
Date: Thu, 14 Jan 2021 00:25:47 +0300	[thread overview]
Message-ID: <20210113212547.GA487841@localhost.localdomain> (raw)
In-Reply-To: <20210113174127.2500051-1-figiel@google.com>

On Wed, Jan 13, 2021 at 06:41:27PM +0100, Piotr Figiel wrote:
> +static int proc_pid_rseq(struct seq_file *m, struct pid_namespace *ns,
> +				struct pid *pid, struct task_struct *task)
> +{
> +	int res = lock_trace(task);
> +
> +	if (res)
> +		return res;
> +	seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig);

may I suggest

	"%tx", (uintptr_t)	// or %lx

Mandatory 64-bit is too much on 32-bit.

Or even "%tx %08x" ?

  reply	other threads:[~2021-01-14  2:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 17:41 [PATCH] fs/proc: Expose RSEQ configuration Piotr Figiel
2021-01-13 21:25 ` Alexey Dobriyan [this message]
2021-01-13 21:32 ` Alexey Dobriyan
2021-01-14 19:20   ` Piotr Figiel
2021-01-14  0:36 ` kernel test robot
2021-01-14  0:36   ` kernel test robot
2021-01-14  1:13 ` kernel test robot
2021-01-14  1:13   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113212547.GA487841@localhost.localdomain \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@gmail.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=ckennelly@google.com \
    --cc=ebiederm@xmission.com \
    --cc=figiel@google.com \
    --cc=gladkov.alexey@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kyurtsever@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=pjt@google.com \
    --cc=posk@google.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.