From: Vladimir Oltean <olteanv@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 net-next 2/5] net: dsa: Don't offload port attributes on standalone ports
Date: Thu, 14 Jan 2021 02:36:05 +0200 [thread overview]
Message-ID: <20210114003605.cncsgffxiashxvpv@skbuf> (raw)
In-Reply-To: <20210113084255.22675-3-tobias@waldekranz.com>
On Wed, Jan 13, 2021 at 09:42:52AM +0100, Tobias Waldekranz wrote:
> In a situation where a standalone port is indirectly attached to a
> bridge (e.g. via a LAG) which is not offloaded, do not offload any
> port attributes either. The port should behave as a standard NIC.
>
> Previously, on mv88e6xxx, this meant that in the following setup:
>
> br0
> /
> team0
> / \
> swp0 swp1
>
> If vlan filtering was enabled on br0, swp0's and swp1's QMode was set
> to "secure". This caused all untagged packets to be dropped, as their
> default VID (0) was not loaded into the VTU.
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-01-14 1:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 8:42 [PATCH v5 net-next 0/5] net: dsa: Link aggregation support Tobias Waldekranz
2021-01-13 8:42 ` [PATCH v5 net-next 1/5] net: bonding: Notify ports about their initial state Tobias Waldekranz
2021-01-13 8:42 ` [PATCH v5 net-next 2/5] net: dsa: Don't offload port attributes on standalone ports Tobias Waldekranz
2021-01-14 0:36 ` Vladimir Oltean [this message]
2021-01-13 8:42 ` [PATCH v5 net-next 3/5] net: dsa: Link aggregation support Tobias Waldekranz
2021-01-13 8:42 ` [PATCH v5 net-next 4/5] net: dsa: mv88e6xxx: " Tobias Waldekranz
2021-01-14 0:50 ` Vladimir Oltean
2021-01-14 8:05 ` Tobias Waldekranz
2021-01-13 8:42 ` [PATCH v5 net-next 5/5] net: dsa: tag_dsa: Support reception of packets from LAG devices Tobias Waldekranz
2021-01-15 1:30 ` [PATCH v5 net-next 0/5] net: dsa: Link aggregation support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114003605.cncsgffxiashxvpv@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vfalico@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.