From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Lee Date: Thu, 14 Jan 2021 01:35:35 +0000 Subject: [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan In-Reply-To: <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> References: <20210113070850.1184506-1-troy_lee@aspeedtech.com> <20210113070850.1184506-2-troy_lee@aspeedtech.com> <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> Message-ID: <20210114013535.GB2151879@aspeedtech.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Rob, The 01/13/2021 23:45, Rob Herring wrote: > On Wed, 13 Jan 2021 07:08:45 +0000, Troy Lee wrote: > > We add binding for supporting a new AST2600 PWM/Fan hwmon driver. > > > > Changes since v1: > > - dt binding with DT schema format > > > > Signed-off-by: Troy Lee > > --- > > .../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 137 ++++++++++++++++++ > > 1 file changed, 137 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml:108:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > See https://patchwork.ozlabs.org/patch/1425628 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > After install yamllint and ran 'make dt_binding_check' again, I can see the same issue. I'll fix it in v3 patch set. Thanks, Troy Lee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D430FC4332B for ; Thu, 14 Jan 2021 01:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 931672310A for ; Thu, 14 Jan 2021 01:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728285AbhANBxv (ORCPT ); Wed, 13 Jan 2021 20:53:51 -0500 Received: from twspam01.aspeedtech.com ([211.20.114.71]:61505 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbhANBxv (ORCPT ); Wed, 13 Jan 2021 20:53:51 -0500 Received: from twspam01.aspeedtech.com (localhost [127.0.0.2] (may be forged)) by twspam01.aspeedtech.com with ESMTP id 10E1Y8tB015352; Thu, 14 Jan 2021 09:34:08 +0800 (GMT-8) (envelope-from troy_lee@aspeedtech.com) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 10E1UhIW015149; Thu, 14 Jan 2021 09:30:43 +0800 (GMT-8) (envelope-from troy_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Jan 2021 09:35:43 +0800 Date: Thu, 14 Jan 2021 01:35:35 +0000 From: Troy Lee To: Rob Herring CC: Andrew Jeffery , Ryan Chen , "leetroy@gmail.com" , "openbmc@lists.ozlabs.org" , Philipp Zabel , "Jonathan Corbet" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:DOCUMENTATION" , Rob Herring , Jean Delvare , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:HARDWARE MONITORING" , ChiaWei Wang , Joel Stanley , Guenter Roeck , open list Subject: Re: [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan Message-ID: <20210114013535.GB2151879@aspeedtech.com> References: <20210113070850.1184506-1-troy_lee@aspeedtech.com> <20210113070850.1184506-2-troy_lee@aspeedtech.com> <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 10E1UhIW015149 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Rob, The 01/13/2021 23:45, Rob Herring wrote: > On Wed, 13 Jan 2021 07:08:45 +0000, Troy Lee wrote: > > We add binding for supporting a new AST2600 PWM/Fan hwmon driver. > > > > Changes since v1: > > - dt binding with DT schema format > > > > Signed-off-by: Troy Lee > > --- > > .../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 137 ++++++++++++++++++ > > 1 file changed, 137 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml:108:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > See https://patchwork.ozlabs.org/patch/1425628 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > After install yamllint and ran 'make dt_binding_check' again, I can see the same issue. I'll fix it in v3 patch set. Thanks, Troy Lee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04534C433DB for ; Thu, 14 Jan 2021 01:39:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A4BA23435 for ; Thu, 14 Jan 2021 01:39:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A4BA23435 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DGRn718LYzDrnl for ; Thu, 14 Jan 2021 12:39:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=fail (SPF fail - not authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=troy_lee@aspeedtech.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DGRlS0r23zDqYb; Thu, 14 Jan 2021 12:37:54 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 10E1UhIW015149; Thu, 14 Jan 2021 09:30:43 +0800 (GMT-8) (envelope-from troy_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Jan 2021 09:35:43 +0800 Date: Thu, 14 Jan 2021 01:35:35 +0000 From: Troy Lee To: Rob Herring Subject: Re: [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan Message-ID: <20210114013535.GB2151879@aspeedtech.com> References: <20210113070850.1184506-1-troy_lee@aspeedtech.com> <20210113070850.1184506-2-troy_lee@aspeedtech.com> <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1610552704.291941.2506185.nullmailer@robh.at.kernel.org> X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 10E1UhIW015149 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:HARDWARE MONITORING" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jean Delvare , Ryan Chen , Guenter Roeck , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Jonathan Corbet , Andrew Jeffery , "openbmc@lists.ozlabs.org" , "open list:DOCUMENTATION" , open list , "leetroy@gmail.com" , Rob Herring , Philipp Zabel , ChiaWei Wang , "moderated list:ARM/ASPEED MACHINE SUPPORT" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Rob, The 01/13/2021 23:45, Rob Herring wrote: > On Wed, 13 Jan 2021 07:08:45 +0000, Troy Lee wrote: > > We add binding for supporting a new AST2600 PWM/Fan hwmon driver. > > > > Changes since v1: > > - dt binding with DT schema format > > > > Signed-off-by: Troy Lee > > --- > > .../hwmon/aspeed,ast2600-pwm-tachometer.yaml | 137 ++++++++++++++++++ > > 1 file changed, 137 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/hwmon/aspeed,ast2600-pwm-tachometer.yaml:108:2: [warning] wrong indentation: expected 2 but found 1 (indentation) > > dtschema/dtc warnings/errors: > > See https://patchwork.ozlabs.org/patch/1425628 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > After install yamllint and ran 'make dt_binding_check' again, I can see the same issue. I'll fix it in v3 patch set. Thanks, Troy Lee