From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Dany Madden <drt@linux.ibm.com>,
Lijun Pan <ljp@linux.ibm.com>,
Rick Lindsley <ricklind@linux.ibm.com>
Subject: Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking
Date: Wed, 13 Jan 2021 18:35:44 -0800 [thread overview]
Message-ID: <20210114023544.GA251151@us.ibm.com> (raw)
In-Reply-To: <20210112180054.28ebcd1a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski [kuba@kernel.org] wrote:
> On Tue, 12 Jan 2021 10:14:34 -0800 Sukadev Bhattiprolu wrote:
> > Use more consistent locking when reading/writing the adapter->state
> > field. This patch set fixes a race condition during ibmvnic_open()
> > where the adapter could be left in the PROBED state if a reset occurs
> > at the wrong time. This can cause networking to not come up during
> > boot and potentially require manual intervention in bringing up
> > applications that depend on the network.
>
> Apologies for not having enough time to suggest details, but let me
> state this again - the patches which fix bugs need to go into net with
> Fixes tags, the refactoring needs to go to net-next without Fixes tags.
> If there are dependencies, patches go to net first, then within a week
> or so the reset can be posted for net-next, after net -> net-next merge.
I think the locking bug fixes need the refactoring. So would it be ok to
send the refactoring (patches 2 through 4) first to net-next and when
they are merged send the the bug fixes (1, 5 and 6)? Patch 7 can be
sent to net-next later after that.
Thanks,
Sukadev
prev parent reply other threads:[~2021-01-14 2:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 18:14 [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 1/7] ibmvnic: restore state in change-param reset Sukadev Bhattiprolu
2021-01-12 18:35 ` Dany Madden
2021-01-12 18:14 ` [PATCH net-next v2 2/7] ibmvnic: update reset function prototypes Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 3/7] ibmvnic: avoid allocating rwi entries Sukadev Bhattiprolu
2021-01-12 19:48 ` Saeed Mahameed
2021-01-13 1:15 ` Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 4/7] ibmvnic: switch order of checks in ibmvnic_reset Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue Sukadev Bhattiprolu
2021-01-12 19:56 ` Saeed Mahameed
2021-01-13 0:40 ` Sukadev Bhattiprolu
2021-01-13 1:56 ` Jakub Kicinski
2021-01-12 18:14 ` [PATCH net-next v2 6/7] ibmvnic: check adapter->state under state_lock Sukadev Bhattiprolu
2021-01-12 18:14 ` [PATCH net-next v2 7/7] ibmvnic: add comments about state_lock Sukadev Bhattiprolu
2021-01-12 20:00 ` [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking Saeed Mahameed
2021-01-13 2:00 ` Jakub Kicinski
2021-01-13 4:42 ` Sukadev Bhattiprolu
2021-01-13 18:57 ` Jakub Kicinski
2021-01-13 19:55 ` Sukadev Bhattiprolu
2021-01-14 2:35 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114023544.GA251151@us.ibm.com \
--to=sukadev@linux.ibm.com \
--cc=drt@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=ljp@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.