From: Bin Meng <bmeng.cn@gmail.com>
To: "Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Francisco Iglesias" <frasse.iglesias@gmail.com>
Cc: "Andrew Jeffery" <andrew@aj.id.au>,
"Bin Meng" <bin.meng@windriver.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>
Subject: [PATCH 7/9] Revert "aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command"
Date: Thu, 14 Jan 2021 23:09:00 +0800 [thread overview]
Message-ID: <20210114150902.11515-8-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210114150902.11515-1-bmeng.cn@gmail.com>
From: Bin Meng <bin.meng@windriver.com>
This reverts commit 7faf6f1790dddf9f3acf6ddd95f7bbc1b4a755d0.
The incorrect implementation of dummy cycles in m25p80 model is now
corrected. Revert this commit.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
hw/ssi/aspeed_smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 16addee4dc..1e78b5232f 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -802,11 +802,11 @@ static int aspeed_smc_num_dummies(uint8_t command)
case FAST_READ:
case DOR:
case QOR:
- case FAST_READ_4:
case DOR_4:
case QOR_4:
return 1;
case DIOR:
+ case FAST_READ_4:
case DIOR_4:
return 2;
case QIOR:
--
2.25.1
next prev parent reply other threads:[~2021-01-14 15:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 15:08 [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands Bin Meng
2021-01-14 15:08 ` [PATCH 1/9] hw/block: m25p80: Fix the number of dummy bytes needed for Windbond flashes Bin Meng
2021-01-14 15:08 ` [PATCH 2/9] hw/block: m25p80: Fix the number of dummy bytes needed for Numonyx/Micron flashes Bin Meng
2021-01-14 15:08 ` [PATCH 3/9] hw/block: m25p80: Fix the number of dummy bytes needed for Macronix flashes Bin Meng
2021-01-14 15:08 ` [PATCH 4/9] hw/block: m25p80: Fix the number of dummy bytes needed for Spansion flashes Bin Meng
2021-01-14 15:08 ` [PATCH 5/9] hw/block: m25p80: Support fast read for SST flashes Bin Meng
2021-01-14 15:08 ` [PATCH 6/9] hw/ssi: xilinx_spips: Fix generic fifo dummy cycle handling Bin Meng
2021-01-14 15:09 ` Bin Meng [this message]
2021-01-14 15:09 ` [PATCH 8/9] Revert "aspeed/smc: snoop SPI transfers to fake dummy cycles" Bin Meng
2021-01-14 15:09 ` [PATCH 9/9] hw/ssi: npcm7xx_fiu: Correct the dummy cycle emulation logic Bin Meng
2021-01-14 17:12 ` Havard Skinnemoen via
2021-01-14 17:12 ` Havard Skinnemoen via
2021-01-14 15:59 ` [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands Cédric Le Goater
2021-01-14 16:12 ` no-reply
2021-01-14 18:13 ` Francisco Iglesias
2021-01-15 2:07 ` Bin Meng
2021-01-15 3:29 ` Havard Skinnemoen via
2021-01-15 3:29 ` Havard Skinnemoen via
2021-01-15 13:54 ` Bin Meng
2021-01-15 12:26 ` Francisco Iglesias
2021-01-15 14:38 ` Bin Meng
2021-01-18 10:05 ` Francisco Iglesias
2021-01-18 12:32 ` Bin Meng
2021-01-19 13:01 ` Francisco Iglesias
2021-01-20 14:20 ` Bin Meng
2021-01-21 8:50 ` Francisco Iglesias
2021-01-21 8:59 ` Bin Meng
2021-01-21 10:01 ` Francisco Iglesias
2021-01-21 14:18 ` Francisco Iglesias
2021-02-08 14:41 ` Bin Meng
2021-02-08 15:30 ` Edgar E. Iglesias
2021-02-09 9:35 ` Francisco Iglesias
2021-04-23 6:45 ` Bin Meng
2021-04-27 5:56 ` Alistair Francis
2021-04-27 8:54 ` Francisco Iglesias
2021-04-27 8:54 ` Francisco Iglesias
2021-04-27 14:32 ` Cédric Le Goater
2021-04-27 14:32 ` Cédric Le Goater
2021-04-28 13:12 ` Bin Meng
2021-04-28 13:12 ` Bin Meng
2021-04-28 13:54 ` Cédric Le Goater
2021-04-28 13:54 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114150902.11515-8-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew@aj.id.au \
--cc=bin.meng@windriver.com \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=frasse.iglesias@gmail.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.