All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Neta Ostrovsky <netao@nvidia.com>,
	Avihai Horon <avihaih@nvidia.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/cma: Fix error flow in default_roce_mode_store
Date: Thu, 14 Jan 2021 13:06:59 -0400	[thread overview]
Message-ID: <20210114170659.GB316809@nvidia.com> (raw)
In-Reply-To: <20210113130214.562108-1-leon@kernel.org>

On Wed, Jan 13, 2021 at 03:02:14PM +0200, Leon Romanovsky wrote:
> From: Neta Ostrovsky <netao@nvidia.com>
> 
> In default_roce_mode_store(), we took a reference to cma_dev, but
> didn't return it in error flow. Fix it by calling to cma_dev_put
> in such flow.
> 
> Fixes: 1c15b4f2a42f ("RDMA/core: Modify enum ib_gid_type and enum rdma_network_type")
> Signed-off-by: Neta Ostrovsky <netao@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/core/cma_configfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to for-rc

Thanks,
Jason

      reply	other threads:[~2021-01-14 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 13:02 [PATCH rdma-next] RDMA/cma: Fix error flow in default_roce_mode_store Leon Romanovsky
2021-01-14 17:06 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114170659.GB316809@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=avihaih@nvidia.com \
    --cc=dledford@redhat.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netao@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.