From: Alan Stern <stern@rowland.harvard.edu>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Daewoong Kim <daewoong00.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
allen.lkml@gmail.com, gustavoars@kernel.org,
a.darwish@linutronix.de, romain.perier@gmail.com,
dvyukov@google.com, andreyknvl@google.com,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/1] usb: xhci: setup packets don't need DMA mapping
Date: Thu, 14 Jan 2021 13:00:21 -0500 [thread overview]
Message-ID: <20210114180021.GA1935@rowland.harvard.edu> (raw)
In-Reply-To: <20210114050402.GA18650@b29397-desktop>
On Thu, Jan 14, 2021 at 01:04:02PM +0800, Peter Chen wrote:
> On 21-01-14 11:59:07, Daewoong Kim wrote:
> > DMA mapping of urb->setup_packet is not necessary for xHCI host
> > controllers. The xHCI specification says that Setup Stage TRB includes
> > whole Setup Data; therefore, urb->setup_dma will not be used in the xhci
> > HCD code.
> >
>
> How about bypass map/unmap operation for xHCI control transfer directly?
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 91ab81c3fc79..0a0ab14b7638 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1374,7 +1374,8 @@ static int xhci_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
>
> xhci = hcd_to_xhci(hcd);
>
> - if (xhci_urb_suitable_for_idt(urb))
> + if (xhci_urb_suitable_for_idt(urb) ||
> + (usb_endpoint_xfer_control(&urb->ep->desc)))
> return 0;
Would this affect the map/unmap operations for the DATA packets in a
control transfer, along with the SETUP packet?
Alan Stern
next prev parent reply other threads:[~2021-01-14 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 2:59 [PATCH 1/1] usb: xhci: setup packets don't need DMA mapping Daewoong Kim
2021-01-14 5:04 ` Peter Chen
2021-01-14 18:00 ` Alan Stern [this message]
2021-01-15 0:32 ` Peter Chen
2021-01-18 1:07 ` Daewoong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114180021.GA1935@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=a.darwish@linutronix.de \
--cc=allen.lkml@gmail.com \
--cc=andreyknvl@google.com \
--cc=daewoong00.kim@lge.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=hzpeterchen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.