Re: [PATCH 4/5] arch: arm64: dts: imx8mq/m/n/p: add mac address for FEC

[Shawn Guo <shawnguo@kernel.org>]

On Tue, Jan 12, 2021 at 10:42:19AM +0000, Joakim Zhang wrote:
> 
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: 2021年1月5日 8:35
> > To: Joakim Zhang <qiangqing.zhang@nxp.com>
> > Cc: s.hauer@pengutronix.de; festevam@gmail.com;
> > devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; Andy Duan
> > <fugang.duan@nxp.com>
> > Subject: Re: [PATCH 4/5] arch: arm64: dts: imx8mq/m/n/p: add mac address
> > for FEC
> > 
> > On Thu, Nov 19, 2020 at 05:52:48PM +0800, Joakim Zhang wrote:
> > > Add mac address in efuse, so that FEC driver can parse it from nvmem
> > > cell.
> > >
> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 7 +++++++
> > > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 7 +++++++
> > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 7 +++++++
> > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
> > >  4 files changed, 28 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index 367174031a90..0fbff13a9629 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -521,6 +521,10 @@
> > >  				cpu_speed_grade: speed-grade@10 {
> > >  					reg = <0x10 4>;
> > >  				};
> > > +
> > > +				fec_mac_address: mac-address@640 {
> > 
> > Shouldn't the unit-address be @90 rather than @640?
> 
> 
> Hi Shann, @90 is a offset, @640 is an absolute address, which one is prefer to you? Thanks.

My point was that unit-address should match 'reg' property.

Shawn