[djwong-xfs:scrub-rtsummary 13/56] fs/xfs/xfs_icache.c:1683 xfs_blockgc_free_dquots() error: we previously assumed 'mp' could be null (see line 1674)

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3865 bytes --]

CC: kbuild-all(a)lists.01.org
CC: "Darrick J. Wong" <darrick.wong@oracle.com>
TO: "Darrick J. Wong" <djwong@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git scrub-rtsummary
head:   30ed2e375306b1c5c8c622635a87595eec25a2d0
commit: 9e90c7eeb433809da02f5fbaf09bc5fdf92791b0 [13/56] xfs: flush eof/cowblocks if we can't reserve quota for inode creation
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-m021-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/xfs/xfs_icache.c:1683 xfs_blockgc_free_dquots() error: we previously assumed 'mp' could be null (see line 1674)

vim +/mp +1683 fs/xfs/xfs_icache.c

7bd9977471d51f89 Darrick J. Wong 2021-01-15  1647  
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1648  /*
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1649   * Run cow/eofblocks scans on the supplied dquots.  We don't know exactly which
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1650   * quota caused an allocation failure, so we make a best effort by including
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1651   * each quota under low free space conditions (less than 1% free space) in the
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1652   * scan.
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1653   */
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1654  int
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1655  xfs_blockgc_free_dquots(
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1656  	struct xfs_dquot	*udqp,
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1657  	struct xfs_dquot	*gdqp,
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1658  	struct xfs_dquot	*pdqp,
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1659  	unsigned int		eof_flags,
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1660  	bool			*found_work)
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1661  {
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1662  	struct xfs_eofblocks	eofb = {0};
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1663  	struct xfs_mount	*mp = NULL;
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1664  	int			error;
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1665  
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1666  	*found_work = false;
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1667  
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1668  	if (!udqp && !gdqp && !pdqp)
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1669  		return 0;
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1670  	if (udqp)
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1671  		mp = udqp->q_mount;
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1672  	if (!mp && gdqp)
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1673  		mp = gdqp->q_mount;
9e90c7eeb433809d Darrick J. Wong 2021-01-15 @1674  	if (!mp && pdqp)
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1675  		mp = pdqp->q_mount;
9e90c7eeb433809d Darrick J. Wong 2021-01-15  1676  
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1677  	/*
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1678  	 * Run a scan to increase effectiveness and use the union filter to
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1679  	 * cover all applicable quotas in a single scan.
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1680  	 */
6a1725833ef0d776 Darrick J. Wong 2021-01-15  1681  	eofb.eof_flags = XFS_EOF_FLAGS_UNION | eof_flags;
7bd9977471d51f89 Darrick J. Wong 2021-01-15  1682  
9e90c7eeb433809d Darrick J. Wong 2021-01-15 @1683  	if (XFS_IS_UQUOTA_ENFORCED(mp) && udqp && xfs_dquot_lowsp(udqp)) {

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32748 bytes --]