From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-firmware: remove imx sdma firmware
Date: Sun, 17 Jan 2021 15:22:56 +0100 [thread overview]
Message-ID: <20210117142256.GH2375@scaer> (raw)
In-Reply-To: <20210117133119.73546-1-romain.naour@gmail.com>
Romain, All,
On 2021-01-17 14:31 +0100, Romain Naour spake thusly:
> As reported on the mailing list [1], the imx sdma firmwares for
> imx[6,7,8] are provided by two packages: firmware-imx and
> linux-firmware
>
> $ sha256sum ./firmware-imx-8.10/firmware/sdma/sdma-imx6q.bin
> 7790c161b7e013a9dbcbffb17cc5d4cb63d952949a505647e4679f02d04c4784
> ./firmware-imx-8.10/firmware/sdma/sdma-imx6q.bin
>
> $ sha256sum ./linux-firmware-20201022/imx/sdma/sdma-imx6q.bin
> 7790c161b7e013a9dbcbffb17cc5d4cb63d952949a505647e4679f02d04c4784
> ./linux-firmware-20201022/imx/sdma/sdma-imx6q.bin
>
> Keep firmware-imx as the only imx sdma firmware provider.
>
> [1] http://lists.busybox.net/pipermail/buildroot/2021-January/300938.html
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Stephane Viau <stephane.viau@oss.nxp.com>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
At first, I was going to suggest that we should insteaddrop the separate
firmware-imx package, and keep just linux-firmware.
But as explained in the thread you pointed in the commit log (?),
firmware-imx also has firmwares for older CPUs, so I've added that as a
justification why we keep it and not the option from linux-firmware.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Config.in.legacy | 8 ++++++++
> package/linux-firmware/Config.in | 9 ---------
> package/linux-firmware/linux-firmware.mk | 6 ------
> 3 files changed, 8 insertions(+), 15 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 3c022d21d7..a322d18cb3 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,14 @@ endif
>
> comment "Legacy options removed in 2021.02"
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_IMX_SDMA
> + bool "imx sdma firmware is provided by firmware-imx"
> + select BR2_LEGACY
> + select BR2_PACKAGE_FIRMWARE_IMX
> + help
> + linux-firmware provide the same firmware as firmware-imx.
> + We prefer using firmware-imx as the only provider.
> +
> config BR2_GDB_VERSION_8_2
> bool "gdb 8.2.x has been removed"
> select BR2_LEGACY
> diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
> index 8e71c21251..a41310ff2a 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -459,15 +459,6 @@ config BR2_PACKAGE_LINUX_FIRMWARE_XCx000
>
> endmenu
>
> -menu "SoC Firmware"
> -
> -config BR2_PACKAGE_LINUX_FIRMWARE_IMX_SDMA
> - bool "Freescale i.MX SDMA"
> - help
> - Firmware files for i.MX SDMA.
> -
> -endmenu
> -
> menu "Fibre Channel Adapter Firmware"
>
> config BR2_PACKAGE_LINUX_FIRMWARE_QLOGIC_2XXX
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index 22fac9d7aa..f23da171c6 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -64,12 +64,6 @@ LINUX_FIRMWARE_FILES += qca/rampatch_usb_00000302.bin qca/nvm_usb_00000302.bin
> LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.qcom
> endif
>
> -# Freescale i.MX SDMA
> -ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_IMX_SDMA),y)
> -LINUX_FIRMWARE_FILES += imx/sdma/sdma-imx6q.bin imx/sdma/sdma-imx7d.bin
> -LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.sdma_firmware
> -endif
> -
> # rt2501/rt61
> ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RALINK_RT61),y)
> LINUX_FIRMWARE_FILES += rt2561.bin rt2561s.bin rt2661.bin
> --
> 2.25.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-01-17 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 13:31 [Buildroot] [PATCH] package/linux-firmware: remove imx sdma firmware Romain Naour
2021-01-17 14:22 ` Yann E. MORIN [this message]
2021-01-18 8:00 ` Gary Bisson
2021-01-18 20:32 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117142256.GH2375@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.