From: Kent Gibson <warthog618@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kselftest@vger.kernel.org, bgolaszewski@baylibre.com,
linus.walleij@linaro.org, shuah@kernel.org, bamv2005@gmail.com
Subject: Re: [PATCH v2 1/7] selftests: gpio: rework and simplify test implementation
Date: Mon, 18 Jan 2021 07:54:37 +0800 [thread overview]
Message-ID: <20210117235437.GA6841@sol> (raw)
In-Reply-To: <20210107025731.226017-2-warthog618@gmail.com>
On Thu, Jan 07, 2021 at 10:57:25AM +0800, Kent Gibson wrote:
> The GPIO mockup selftests are overly complicated with separate
> implementations of the tests for sysfs and cdev uAPI, and with the cdev
> implementation being dependent on tools/gpio and libmount.
>
> Rework the test implementation to provide a common test suite with a
> simplified pluggable uAPI interface. The cdev implementation utilises
> the GPIO uAPI directly to remove the dependence on tools/gpio.
> The simplified uAPI interface removes the need for any file system mount
> checks in C, and so removes the dependence on libmount.
>
> The rework also fixes the sysfs test implementation which has been broken
> since the device created in the multiple gpiochip case was split into
> separate devices.
>
> Fixes: commit 8a39f597bcfd ("gpio: mockup: rework device probing")
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Just a note that the 'commit' should be removed from the Fixes tag.
That will be fixed in v3.
The patches have been reviewed from the gpio side - any feedback from the
selftest side?
Cheers,
Kent.
next prev parent reply other threads:[~2021-01-17 23:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 2:57 [PATCH v2 0/7] selftests: gpio: rework and port to GPIO uAPI v2 Kent Gibson
2021-01-07 2:57 ` [PATCH v2 1/7] selftests: gpio: rework and simplify test implementation Kent Gibson
2021-01-14 15:04 ` Bartosz Golaszewski
2021-01-17 23:54 ` Kent Gibson [this message]
2021-01-07 2:57 ` [PATCH v2 2/7] selftests: gpio: remove obsolete gpio-mockup-chardev.c Kent Gibson
2021-01-14 15:04 ` Bartosz Golaszewski
2021-01-07 2:57 ` [PATCH v2 3/7] selftests: remove obsolete build restriction for gpio Kent Gibson
2021-01-14 15:04 ` Bartosz Golaszewski
2021-01-07 2:57 ` [PATCH v2 4/7] selftests: remove obsolete gpio references from kselftest_deps.sh Kent Gibson
2021-01-14 15:05 ` Bartosz Golaszewski
2021-01-07 2:57 ` [PATCH v2 5/7] tools: gpio: remove uAPI v1 code no longer used by selftests Kent Gibson
2021-01-14 15:12 ` Bartosz Golaszewski
2021-01-07 2:57 ` [PATCH v2 6/7] selftests: gpio: port to GPIO uAPI v2 Kent Gibson
2021-01-14 15:13 ` Bartosz Golaszewski
2021-01-07 2:57 ` [PATCH v2 7/7] selftests: gpio: add CONFIG_GPIO_CDEV to config Kent Gibson
2021-01-14 15:13 ` Bartosz Golaszewski
2021-01-18 15:04 ` [PATCH v2 0/7] selftests: gpio: rework and port to GPIO uAPI v2 Linus Walleij
2021-01-19 0:34 ` Kent Gibson
2021-01-19 10:37 ` Bartosz Golaszewski
2021-01-19 10:59 ` Kent Gibson
2021-01-19 11:02 ` Bartosz Golaszewski
2021-01-19 11:21 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117235437.GA6841@sol \
--to=warthog618@gmail.com \
--cc=bamv2005@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.