From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F1AC433DB for ; Mon, 18 Jan 2021 12:29:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF96322286 for ; Mon, 18 Jan 2021 12:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391395AbhARM25 (ORCPT ); Mon, 18 Jan 2021 07:28:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42163 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391199AbhARM2x (ORCPT ); Mon, 18 Jan 2021 07:28:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610972845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4t9hxLI3c27quDQ06hH0LqJQwL5pt6zZt+4PjybMLus=; b=YjlFi7iSvNuTxErrsQxAquvTdddUBpjfAKzC0Sk/yZ6CN0cVQgdCwnNiuQhdjF7vFEKhFH CZZQ9gZzQfC0kS8GnF/+UJtf+VFmhJAww+LG5Sw3mdjQhyTA2ricqVgpnTeQfK6Gn93pgj gWgDLR9FXRCMrpm4EHkMzCs0S3H0bXc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-mHdeiv9iM96Olr7gbd2syA-1; Mon, 18 Jan 2021 07:27:23 -0500 X-MC-Unique: mHdeiv9iM96Olr7gbd2syA-1 Received: by mail-wr1-f70.google.com with SMTP id n11so8203832wro.7 for ; Mon, 18 Jan 2021 04:27:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4t9hxLI3c27quDQ06hH0LqJQwL5pt6zZt+4PjybMLus=; b=b6UXynldjelVWBgu0MS943uouv/z2KPnFopTqQmIACkyEfcUMkCh83H1UpzkwxTSbW JLzmZYnd7iC8JnuEd8TS6+6CtTbJoDa/WVUu5xYp/bRM1hs2PfT+Uk9rIv+M5LEtPJpl PjMPA9X76c+GOx3hii3Tzc/TxlMzQE3Mr2mx0qTnhU6D5+oJKPvho5/hsrewD9EviSf2 S0/exgl/3VeoUUlOyAF++AlMxgvZ972WPh2TxYrrYTZf7ajBnQYYBrT2V+QSWP5sdW43 0hp5FN/WU4Oiy+l1x8dxPKlC9CQpO7VPw5FkKezMivjm/zJGfhjYvUgUVkihf1PBVOHT fY5w== X-Gm-Message-State: AOAM532ybGxIdXG5X3lT9b3uzcU9PDhpWTlCq+rzjA08lQsMSEx8a5Oa 0mR6V1PxWe0jDwSUkqG9M2RWPL9gddGNaETwdHS+esCKJ6IGaqQNzovlhrRHSkHkV7GoECeE3W0 OxzEJQjV0RUpV X-Received: by 2002:adf:ec86:: with SMTP id z6mr25591932wrn.17.1610972842626; Mon, 18 Jan 2021 04:27:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrDwjLmyAp5ze/Z7CO1QoqA7XEqd1cdTgI2I5axRLmYtXljl1vRJEjffpSsd1Ieh81PfR2qA== X-Received: by 2002:adf:ec86:: with SMTP id z6mr25591913wrn.17.1610972842429; Mon, 18 Jan 2021 04:27:22 -0800 (PST) Received: from redhat.com (bzq-79-177-39-148.red.bezeqint.net. [79.177.39.148]) by smtp.gmail.com with ESMTPSA id j9sm29836629wrm.14.2021.01.18.04.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 04:27:21 -0800 (PST) Date: Mon, 18 Jan 2021 07:27:18 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Xuan Zhuo , netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Magnus Karlsson , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v2 5/7] virtio-net, xsk: realize the function of xsk packet sending Message-ID: <20210118065907-mutt-send-email-mst@kernel.org> References: <9e1f5a4b633887ce1f66e39bc762b8497a379a43.1610765285.git.xuanzhuo@linux.alibaba.com> <20e27fa0-c7c3-0cc3-bd27-19d1fe9b7717@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20e27fa0-c7c3-0cc3-bd27-19d1fe9b7717@redhat.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jan 18, 2021 at 05:10:24PM +0800, Jason Wang wrote: > > On 2021/1/16 上午10:59, Xuan Zhuo wrote: > > virtnet_xsk_run will be called in the tx interrupt handling function > > virtnet_poll_tx. > > > > The sending process gets desc from the xsk tx queue, and assembles it to > > send the data. > > > > Compared with other drivers, a special place is that the page of the > > data in xsk is used here instead of the dma address. Because the virtio > > interface does not use the dma address. > > > > Signed-off-by: Xuan Zhuo > > --- > > drivers/net/virtio_net.c | 200 ++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 197 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index a62d456..42aa9ad 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -119,6 +119,8 @@ struct virtnet_xsk_hdr { > > u32 len; > > }; > > +#define VIRTNET_STATE_XSK_WAKEUP 1 > > + > > #define VIRTNET_SQ_STAT(m) offsetof(struct virtnet_sq_stats, m) > > #define VIRTNET_RQ_STAT(m) offsetof(struct virtnet_rq_stats, m) > > @@ -163,9 +165,12 @@ struct send_queue { > > struct xsk_buff_pool __rcu *pool; > > struct virtnet_xsk_hdr __rcu *hdr; > > + unsigned long state; > > u64 hdr_con; > > u64 hdr_pro; > > u64 hdr_n; > > + struct xdp_desc last_desc; > > + bool wait_slot; > > } xsk; > > }; Please add documentation about the new fields/defines, how are they accessed, what locking/ordering is in place. > > @@ -284,6 +289,8 @@ static void __free_old_xmit_ptr(struct send_queue *sq, bool in_napi, > > bool xsk_wakeup, > > unsigned int *_packets, unsigned int *_bytes); > > static void free_old_xmit_skbs(struct send_queue *sq, bool in_napi); > > +static int virtnet_xsk_run(struct send_queue *sq, > > + struct xsk_buff_pool *pool, int budget); > > static bool is_xdp_frame(void *ptr) > > { > > @@ -1590,6 +1597,8 @@ static int virtnet_poll_tx(struct napi_struct *napi, int budget) > > struct virtnet_info *vi = sq->vq->vdev->priv; > > unsigned int index = vq2txq(sq->vq); > > struct netdev_queue *txq; > > + struct xsk_buff_pool *pool; > > + int work = 0; > > if (unlikely(is_xdp_raw_buffer_queue(vi, index))) { > > /* We don't need to enable cb for XDP */ > > @@ -1599,15 +1608,26 @@ static int virtnet_poll_tx(struct napi_struct *napi, int budget) > > txq = netdev_get_tx_queue(vi->dev, index); > > __netif_tx_lock(txq, raw_smp_processor_id()); > > - free_old_xmit_skbs(sq, true); > > + > > + rcu_read_lock(); > > + pool = rcu_dereference(sq->xsk.pool); > > + if (pool) { > > + work = virtnet_xsk_run(sq, pool, budget); > > + rcu_read_unlock(); > > + } else { > > + rcu_read_unlock(); > > + free_old_xmit_skbs(sq, true); > > + } > > + > > __netif_tx_unlock(txq); > > - virtqueue_napi_complete(napi, sq->vq, 0); > > + if (work < budget) > > + virtqueue_napi_complete(napi, sq->vq, 0); > > if (sq->vq->num_free >= 2 + MAX_SKB_FRAGS) > > netif_tx_wake_queue(txq); > > - return 0; > > + return work; > > } > > static int xmit_skb(struct send_queue *sq, struct sk_buff *skb) > > @@ -2647,6 +2667,180 @@ static int virtnet_xdp(struct net_device *dev, struct netdev_bpf *xdp) > > } > > } > > +static int virtnet_xsk_xmit(struct send_queue *sq, struct xsk_buff_pool *pool, > > + struct xdp_desc *desc) > > +{ > > + struct virtnet_info *vi = sq->vq->vdev->priv; > > + void *data, *ptr; > > + struct page *page; > > + struct virtnet_xsk_hdr *xskhdr; > > + u32 idx, offset, n, i, copy, copied; > > + u64 addr; > > + int err, m; > > + > > + addr = desc->addr; > > + > > + data = xsk_buff_raw_get_data(pool, addr); > > + offset = offset_in_page(data); > > + > > + /* one for hdr, one for the first page */ > > + n = 2; > > + m = desc->len - (PAGE_SIZE - offset); > > + if (m > 0) { > > + n += m >> PAGE_SHIFT; > > + if (m & PAGE_MASK) > > + ++n; > > + > > + n = min_t(u32, n, ARRAY_SIZE(sq->sg)); > > + } > > + > > + idx = sq->xsk.hdr_con % sq->xsk.hdr_n; > > > I don't understand the reason of the hdr array. It looks to me all of them > are zero and read only from device. > > Any reason for not reusing a single hdr for all xdp descriptors? Or maybe > it's time to introduce VIRTIO_NET_F_NO_HDR. I'm not sure it's worth it, since - xdp can be enabled/disabled dynamically - there's intent to add offload support to xdp > > > + xskhdr = &sq->xsk.hdr[idx]; > > + > > + /* xskhdr->hdr has been memset to zero, so not need to clear again */ > > + > > + sg_init_table(sq->sg, n); > > + sg_set_buf(sq->sg, &xskhdr->hdr, vi->hdr_len); > > + > > + copied = 0; > > + for (i = 1; i < n; ++i) { > > + copy = min_t(int, desc->len - copied, PAGE_SIZE - offset); > > + > > + page = xsk_buff_raw_get_page(pool, addr + copied); > > + > > + sg_set_page(sq->sg + i, page, copy, offset); > > + copied += copy; > > + if (offset) > > + offset = 0; > > + } > > > It looks to me we need to terminate the sg: > > ** >  * virtqueue_add_outbuf - expose output buffers to other end >  * @vq: the struct virtqueue we're talking about. >  * @sg: scatterlist (must be well-formed and terminated!) > > > > + > > + xskhdr->len = desc->len; > > + ptr = xdp_to_ptr(&xskhdr->type); > > + > > + err = virtqueue_add_outbuf(sq->vq, sq->sg, n, ptr, GFP_ATOMIC); > > + if (unlikely(err)) > > + sq->xsk.last_desc = *desc; > > + else > > + sq->xsk.hdr_con++; > > + > > + return err; > > +} > > + > > +static bool virtnet_xsk_dev_is_full(struct send_queue *sq) > > +{ > > + if (sq->vq->num_free < 2 + MAX_SKB_FRAGS) > > + return true; > > + > > + if (sq->xsk.hdr_con == sq->xsk.hdr_pro) > > + return true; > > > Can we really reach here? > > > > + > > + return false; > > +} > > + > > +static int virtnet_xsk_xmit_zc(struct send_queue *sq, > > + struct xsk_buff_pool *pool, unsigned int budget) > > +{ > > + struct xdp_desc desc; > > + int err, packet = 0; > > + int ret = -EAGAIN; > > + > > + if (sq->xsk.last_desc.addr) { > > + err = virtnet_xsk_xmit(sq, pool, &sq->xsk.last_desc); > > + if (unlikely(err)) > > + return -EBUSY; > > + > > + ++packet; > > + sq->xsk.last_desc.addr = 0; > > + } > > + > > + while (budget-- > 0) { > > + if (virtnet_xsk_dev_is_full(sq)) { > > + ret = -EBUSY; > > + break; > > + } > > > It looks to me we will always hit this if userspace is fast. E.g we don't > kick until the virtqueue is full ... > > > > + > > + if (!xsk_tx_peek_desc(pool, &desc)) { > > + /* done */ > > + ret = 0; > > + break; > > + } > > + > > + err = virtnet_xsk_xmit(sq, pool, &desc); > > + if (unlikely(err)) { > > + ret = -EBUSY; > > + break; > > + } > > + > > + ++packet; > > + } > > + > > + if (packet) { > > + xsk_tx_release(pool); > > + > > + if (virtqueue_kick_prepare(sq->vq) && virtqueue_notify(sq->vq)) { > > + u64_stats_update_begin(&sq->stats.syncp); > > + sq->stats.kicks++; > > + u64_stats_update_end(&sq->stats.syncp); > > + } > > + } > > + > > + return ret; > > +} > > + > > +static int virtnet_xsk_run(struct send_queue *sq, > > + struct xsk_buff_pool *pool, int budget) > > +{ > > + int err, ret = 0; > > + unsigned int _packets = 0; > > + unsigned int _bytes = 0; > > + > > + sq->xsk.wait_slot = false; > > + > > + __free_old_xmit_ptr(sq, true, false, &_packets, &_bytes); > > + > > + err = virtnet_xsk_xmit_zc(sq, pool, xsk_budget); > > + if (!err) { > > + struct xdp_desc desc; > > + > > + clear_bit(VIRTNET_STATE_XSK_WAKEUP, &sq->xsk.state); > > + xsk_set_tx_need_wakeup(pool); > > + > > + /* Race breaker. If new is coming after last xmit > > + * but before flag change > > + */ > > + > > + if (!xsk_tx_peek_desc(pool, &desc)) > > + goto end; > > + > > + set_bit(VIRTNET_STATE_XSK_WAKEUP, &sq->xsk.state); > > + xsk_clear_tx_need_wakeup(pool); > > > How memory ordering is going to work here? Or we don't need to care about > that? > > > > + > > + sq->xsk.last_desc = desc; > > + ret = budget; > > + goto end; > > + } > > + > > + xsk_clear_tx_need_wakeup(pool); > > + > > + if (err == -EAGAIN) { > > + ret = budget; > > + goto end; > > + } > > + > > + __free_old_xmit_ptr(sq, true, false, &_packets, &_bytes); > > + > > + if (!virtnet_xsk_dev_is_full(sq)) { > > + ret = budget; > > + goto end; > > + } > > + > > + sq->xsk.wait_slot = true; > > + > > + virtnet_sq_stop_check(sq, true); > > +end: > > + return ret; > > +} > > + > > static int virtnet_get_phys_port_name(struct net_device *dev, char *buf, > > size_t len) > > { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC49C433DB for ; Mon, 18 Jan 2021 12:27:34 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1FA62225C for ; Mon, 18 Jan 2021 12:27:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1FA62225C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 63D01857C1; Mon, 18 Jan 2021 12:27:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KV_iP5j-FMAm; Mon, 18 Jan 2021 12:27:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7E04A85792; Mon, 18 Jan 2021 12:27:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 607F6C088B; Mon, 18 Jan 2021 12:27:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2FB9BC013A for ; Mon, 18 Jan 2021 12:27:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1B0B086FFE for ; Mon, 18 Jan 2021 12:27:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tOSlV15bz1lh for ; Mon, 18 Jan 2021 12:27:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by hemlock.osuosl.org (Postfix) with ESMTPS id C0EC786F82 for ; Mon, 18 Jan 2021 12:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610972847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4t9hxLI3c27quDQ06hH0LqJQwL5pt6zZt+4PjybMLus=; b=OcQtCE1GUYPt6r2Yjat+fn/6d/wlb64ypyjbH+i9qqqZ9G0rEAApHfn7hgVb4CK2x7NdRU Kydi8zKonaAJTL3UdnN6Y4B4IQdfY6KpK7IZYCPmsW+DRv3OU3jQh1uGInMPEH6HTIiPd9 j5wuSxUFTsMNRy8lf3G/2ozYVo8P7Nk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-zHar2JVbMAKVBf3na5UDtg-1; Mon, 18 Jan 2021 07:27:24 -0500 X-MC-Unique: zHar2JVbMAKVBf3na5UDtg-1 Received: by mail-wr1-f69.google.com with SMTP id u29so8233126wru.6 for ; Mon, 18 Jan 2021 04:27:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4t9hxLI3c27quDQ06hH0LqJQwL5pt6zZt+4PjybMLus=; b=mEx18w2988+sEblW9ZBYWmJLBJkaScxIRqTpawWc4m4gPnLEf00oLzebHEkNjxkuCT 3SUOPkzjd2Ld9AIAIVZOho360qU1/X4I9WBqlg9q6PJBmBvihT+SsliGptVeFUUD/j3o lyfyvfhZ823h2SykfYKt64FP6a7Qb8lmUs7dsvoBKVYVOoZlnEZRtR/GKl6voj6YBxnM 5iDDpAYUOdPVIpxSiZKxXB9G24jm1Jk39q7uXvkh72RASik1gYHq+XEJJEZHMip4EarR P0+fZ5II+EXsCw0g1W/cpXzvtu8fvjcttB121Uszzonfy0pkTpNEJ2Qyqb9w3Z9RyjJo sWaw== X-Gm-Message-State: AOAM533yCtdYMGAG0G5ML/6TBLuaJhCKxPhRqGglgy9K5ykzJpMNZ6iM CJibjodXFjshNgqCd7uYbDrBZAxIDDD3SP3a5prpLQYZ7iJal8Yu885E9NIYb7k2xHdFFvp9PHC rRYn5No72m/NFrSjDkdCWX6fbmwR8CUgOWWdCzOtTYg== X-Received: by 2002:adf:ec86:: with SMTP id z6mr25591928wrn.17.1610972842626; Mon, 18 Jan 2021 04:27:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrDwjLmyAp5ze/Z7CO1QoqA7XEqd1cdTgI2I5axRLmYtXljl1vRJEjffpSsd1Ieh81PfR2qA== X-Received: by 2002:adf:ec86:: with SMTP id z6mr25591913wrn.17.1610972842429; Mon, 18 Jan 2021 04:27:22 -0800 (PST) Received: from redhat.com (bzq-79-177-39-148.red.bezeqint.net. [79.177.39.148]) by smtp.gmail.com with ESMTPSA id j9sm29836629wrm.14.2021.01.18.04.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 04:27:21 -0800 (PST) Date: Mon, 18 Jan 2021 07:27:18 -0500 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH net-next v2 5/7] virtio-net, xsk: realize the function of xsk packet sending Message-ID: <20210118065907-mutt-send-email-mst@kernel.org> References: <9e1f5a4b633887ce1f66e39bc762b8497a379a43.1610765285.git.xuanzhuo@linux.alibaba.com> <20e27fa0-c7c3-0cc3-bd27-19d1fe9b7717@redhat.com> MIME-Version: 1.0 In-Reply-To: <20e27fa0-c7c3-0cc3-bd27-19d1fe9b7717@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Xuan Zhuo , Song Liu , Martin KaFai Lau , Jesper Dangaard Brouer , Daniel Borkmann , netdev@vger.kernel.org, John Fastabend , Alexei Starovoitov , Andrii Nakryiko , Yonghong Song , Jonathan Lemon , KP Singh , Jakub Kicinski , bpf@vger.kernel.org, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , virtualization@lists.linux-foundation.org, "David S. Miller" , Magnus Karlsson X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBKYW4gMTgsIDIwMjEgYXQgMDU6MTA6MjRQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDIxLzEvMTYg5LiK5Y2IMTA6NTksIFh1YW4gWmh1byB3cm90ZToKPiA+IHZp cnRuZXRfeHNrX3J1biB3aWxsIGJlIGNhbGxlZCBpbiB0aGUgdHggaW50ZXJydXB0IGhhbmRsaW5n IGZ1bmN0aW9uCj4gPiB2aXJ0bmV0X3BvbGxfdHguCj4gPiAKPiA+IFRoZSBzZW5kaW5nIHByb2Nl c3MgZ2V0cyBkZXNjIGZyb20gdGhlIHhzayB0eCBxdWV1ZSwgYW5kIGFzc2VtYmxlcyBpdCB0bwo+ ID4gc2VuZCB0aGUgZGF0YS4KPiA+IAo+ID4gQ29tcGFyZWQgd2l0aCBvdGhlciBkcml2ZXJzLCBh IHNwZWNpYWwgcGxhY2UgaXMgdGhhdCB0aGUgcGFnZSBvZiB0aGUKPiA+IGRhdGEgaW4geHNrIGlz IHVzZWQgaGVyZSBpbnN0ZWFkIG9mIHRoZSBkbWEgYWRkcmVzcy4gQmVjYXVzZSB0aGUgdmlydGlv Cj4gPiBpbnRlcmZhY2UgZG9lcyBub3QgdXNlIHRoZSBkbWEgYWRkcmVzcy4KPiA+IAo+ID4gU2ln bmVkLW9mZi1ieTogWHVhbiBaaHVvIDx4dWFuemh1b0BsaW51eC5hbGliYWJhLmNvbT4KPiA+IC0t LQo+ID4gICBkcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMgfCAyMDAgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDE5NyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jCj4gPiBpbmRleCBh NjJkNDU2Li40MmFhOWFkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5j Cj4gPiArKysgYi9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiA+IEBAIC0xMTksNiArMTE5LDgg QEAgc3RydWN0IHZpcnRuZXRfeHNrX2hkciB7Cj4gPiAgIAl1MzIgbGVuOwo+ID4gICB9Owo+ID4g KyNkZWZpbmUgVklSVE5FVF9TVEFURV9YU0tfV0FLRVVQIDEKPiA+ICsKPiA+ICAgI2RlZmluZSBW SVJUTkVUX1NRX1NUQVQobSkJb2Zmc2V0b2Yoc3RydWN0IHZpcnRuZXRfc3Ffc3RhdHMsIG0pCj4g PiAgICNkZWZpbmUgVklSVE5FVF9SUV9TVEFUKG0pCW9mZnNldG9mKHN0cnVjdCB2aXJ0bmV0X3Jx X3N0YXRzLCBtKQo+ID4gQEAgLTE2Myw5ICsxNjUsMTIgQEAgc3RydWN0IHNlbmRfcXVldWUgewo+ ID4gICAJCXN0cnVjdCB4c2tfYnVmZl9wb29sICAgX19yY3UgKnBvb2w7Cj4gPiAgIAkJc3RydWN0 IHZpcnRuZXRfeHNrX2hkciBfX3JjdSAqaGRyOwo+ID4gKwkJdW5zaWduZWQgbG9uZyAgICAgICAg ICBzdGF0ZTsKPiA+ICAgCQl1NjQgICAgICAgICAgICAgICAgICAgIGhkcl9jb247Cj4gPiAgIAkJ dTY0ICAgICAgICAgICAgICAgICAgICBoZHJfcHJvOwo+ID4gICAJCXU2NCAgICAgICAgICAgICAg ICAgICAgaGRyX247Cj4gPiArCQlzdHJ1Y3QgeGRwX2Rlc2MgICAgICAgIGxhc3RfZGVzYzsKPiA+ ICsJCWJvb2wgICAgICAgICAgICAgICAgICAgd2FpdF9zbG90Owo+ID4gICAJfSB4c2s7Cj4gPiAg IH07CgoKClBsZWFzZSBhZGQgZG9jdW1lbnRhdGlvbiBhYm91dCB0aGUgbmV3IGZpZWxkcy9kZWZp bmVzLCBob3cgYXJlIHRoZXkKYWNjZXNzZWQsIHdoYXQgbG9ja2luZy9vcmRlcmluZyBpcyBpbiBw bGFjZS4KCj4gPiBAQCAtMjg0LDYgKzI4OSw4IEBAIHN0YXRpYyB2b2lkIF9fZnJlZV9vbGRfeG1p dF9wdHIoc3RydWN0IHNlbmRfcXVldWUgKnNxLCBib29sIGluX25hcGksCj4gPiAgIAkJCQlib29s IHhza193YWtldXAsCj4gPiAgIAkJCQl1bnNpZ25lZCBpbnQgKl9wYWNrZXRzLCB1bnNpZ25lZCBp bnQgKl9ieXRlcyk7Cj4gPiAgIHN0YXRpYyB2b2lkIGZyZWVfb2xkX3htaXRfc2ticyhzdHJ1Y3Qg c2VuZF9xdWV1ZSAqc3EsIGJvb2wgaW5fbmFwaSk7Cj4gPiArc3RhdGljIGludCB2aXJ0bmV0X3hz a19ydW4oc3RydWN0IHNlbmRfcXVldWUgKnNxLAo+ID4gKwkJCSAgIHN0cnVjdCB4c2tfYnVmZl9w b29sICpwb29sLCBpbnQgYnVkZ2V0KTsKPiA+ICAgc3RhdGljIGJvb2wgaXNfeGRwX2ZyYW1lKHZv aWQgKnB0cikKPiA+ICAgewo+ID4gQEAgLTE1OTAsNiArMTU5Nyw4IEBAIHN0YXRpYyBpbnQgdmly dG5ldF9wb2xsX3R4KHN0cnVjdCBuYXBpX3N0cnVjdCAqbmFwaSwgaW50IGJ1ZGdldCkKPiA+ICAg CXN0cnVjdCB2aXJ0bmV0X2luZm8gKnZpID0gc3EtPnZxLT52ZGV2LT5wcml2Owo+ID4gICAJdW5z aWduZWQgaW50IGluZGV4ID0gdnEydHhxKHNxLT52cSk7Cj4gPiAgIAlzdHJ1Y3QgbmV0ZGV2X3F1 ZXVlICp0eHE7Cj4gPiArCXN0cnVjdCB4c2tfYnVmZl9wb29sICpwb29sOwo+ID4gKwlpbnQgd29y ayA9IDA7Cj4gPiAgIAlpZiAodW5saWtlbHkoaXNfeGRwX3Jhd19idWZmZXJfcXVldWUodmksIGlu ZGV4KSkpIHsKPiA+ICAgCQkvKiBXZSBkb24ndCBuZWVkIHRvIGVuYWJsZSBjYiBmb3IgWERQICov Cj4gPiBAQCAtMTU5OSwxNSArMTYwOCwyNiBAQCBzdGF0aWMgaW50IHZpcnRuZXRfcG9sbF90eChz dHJ1Y3QgbmFwaV9zdHJ1Y3QgKm5hcGksIGludCBidWRnZXQpCj4gPiAgIAl0eHEgPSBuZXRkZXZf Z2V0X3R4X3F1ZXVlKHZpLT5kZXYsIGluZGV4KTsKPiA+ICAgCV9fbmV0aWZfdHhfbG9jayh0eHEs IHJhd19zbXBfcHJvY2Vzc29yX2lkKCkpOwo+ID4gLQlmcmVlX29sZF94bWl0X3NrYnMoc3EsIHRy dWUpOwo+ID4gKwo+ID4gKwlyY3VfcmVhZF9sb2NrKCk7Cj4gPiArCXBvb2wgPSByY3VfZGVyZWZl cmVuY2Uoc3EtPnhzay5wb29sKTsKPiA+ICsJaWYgKHBvb2wpIHsKPiA+ICsJCXdvcmsgPSB2aXJ0 bmV0X3hza19ydW4oc3EsIHBvb2wsIGJ1ZGdldCk7Cj4gPiArCQlyY3VfcmVhZF91bmxvY2soKTsK PiA+ICsJfSBlbHNlIHsKPiA+ICsJCXJjdV9yZWFkX3VubG9jaygpOwo+ID4gKwkJZnJlZV9vbGRf eG1pdF9za2JzKHNxLCB0cnVlKTsKPiA+ICsJfQo+ID4gKwo+ID4gICAJX19uZXRpZl90eF91bmxv Y2sodHhxKTsKPiA+IC0JdmlydHF1ZXVlX25hcGlfY29tcGxldGUobmFwaSwgc3EtPnZxLCAwKTsK PiA+ICsJaWYgKHdvcmsgPCBidWRnZXQpCj4gPiArCQl2aXJ0cXVldWVfbmFwaV9jb21wbGV0ZShu YXBpLCBzcS0+dnEsIDApOwo+ID4gICAJaWYgKHNxLT52cS0+bnVtX2ZyZWUgPj0gMiArIE1BWF9T S0JfRlJBR1MpCj4gPiAgIAkJbmV0aWZfdHhfd2FrZV9xdWV1ZSh0eHEpOwo+ID4gLQlyZXR1cm4g MDsKPiA+ICsJcmV0dXJuIHdvcms7Cj4gPiAgIH0KPiA+ICAgc3RhdGljIGludCB4bWl0X3NrYihz dHJ1Y3Qgc2VuZF9xdWV1ZSAqc3EsIHN0cnVjdCBza19idWZmICpza2IpCj4gPiBAQCAtMjY0Nyw2 ICsyNjY3LDE4MCBAQCBzdGF0aWMgaW50IHZpcnRuZXRfeGRwKHN0cnVjdCBuZXRfZGV2aWNlICpk ZXYsIHN0cnVjdCBuZXRkZXZfYnBmICp4ZHApCj4gPiAgIAl9Cj4gPiAgIH0KPiA+ICtzdGF0aWMg aW50IHZpcnRuZXRfeHNrX3htaXQoc3RydWN0IHNlbmRfcXVldWUgKnNxLCBzdHJ1Y3QgeHNrX2J1 ZmZfcG9vbCAqcG9vbCwKPiA+ICsJCQkgICAgc3RydWN0IHhkcF9kZXNjICpkZXNjKQo+ID4gK3sK PiA+ICsJc3RydWN0IHZpcnRuZXRfaW5mbyAqdmkgPSBzcS0+dnEtPnZkZXYtPnByaXY7Cj4gPiAr CXZvaWQgKmRhdGEsICpwdHI7Cj4gPiArCXN0cnVjdCBwYWdlICpwYWdlOwo+ID4gKwlzdHJ1Y3Qg dmlydG5ldF94c2tfaGRyICp4c2toZHI7Cj4gPiArCXUzMiBpZHgsIG9mZnNldCwgbiwgaSwgY29w eSwgY29waWVkOwo+ID4gKwl1NjQgYWRkcjsKPiA+ICsJaW50IGVyciwgbTsKPiA+ICsKPiA+ICsJ YWRkciA9IGRlc2MtPmFkZHI7Cj4gPiArCj4gPiArCWRhdGEgPSB4c2tfYnVmZl9yYXdfZ2V0X2Rh dGEocG9vbCwgYWRkcik7Cj4gPiArCW9mZnNldCA9IG9mZnNldF9pbl9wYWdlKGRhdGEpOwo+ID4g Kwo+ID4gKwkvKiBvbmUgZm9yIGhkciwgb25lIGZvciB0aGUgZmlyc3QgcGFnZSAqLwo+ID4gKwlu ID0gMjsKPiA+ICsJbSA9IGRlc2MtPmxlbiAtIChQQUdFX1NJWkUgLSBvZmZzZXQpOwo+ID4gKwlp ZiAobSA+IDApIHsKPiA+ICsJCW4gKz0gbSA+PiBQQUdFX1NISUZUOwo+ID4gKwkJaWYgKG0gJiBQ QUdFX01BU0spCj4gPiArCQkJKytuOwo+ID4gKwo+ID4gKwkJbiA9IG1pbl90KHUzMiwgbiwgQVJS QVlfU0laRShzcS0+c2cpKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZHggPSBzcS0+eHNrLmhkcl9j b24gJSBzcS0+eHNrLmhkcl9uOwo+IAo+IAo+IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgcmVhc29u IG9mIHRoZSBoZHIgYXJyYXkuIEl0IGxvb2tzIHRvIG1lIGFsbCBvZiB0aGVtCj4gYXJlIHplcm8g YW5kIHJlYWQgb25seSBmcm9tIGRldmljZS4KPiAKPiBBbnkgcmVhc29uIGZvciBub3QgcmV1c2lu ZyBhIHNpbmdsZSBoZHIgZm9yIGFsbCB4ZHAgZGVzY3JpcHRvcnM/IE9yIG1heWJlCj4gaXQncyB0 aW1lIHRvIGludHJvZHVjZSBWSVJUSU9fTkVUX0ZfTk9fSERSLgoKSSdtIG5vdCBzdXJlIGl0J3Mg d29ydGggaXQsIHNpbmNlCi0geGRwIGNhbiBiZSBlbmFibGVkL2Rpc2FibGVkIGR5bmFtaWNhbGx5 Ci0gdGhlcmUncyBpbnRlbnQgdG8gYWRkIG9mZmxvYWQgc3VwcG9ydCB0byB4ZHAKCj4gCj4gPiAr CXhza2hkciA9ICZzcS0+eHNrLmhkcltpZHhdOwo+ID4gKwo+ID4gKwkvKiB4c2toZHItPmhkciBo YXMgYmVlbiBtZW1zZXQgdG8gemVybywgc28gbm90IG5lZWQgdG8gY2xlYXIgYWdhaW4gKi8KPiA+ ICsKPiA+ICsJc2dfaW5pdF90YWJsZShzcS0+c2csIG4pOwo+ID4gKwlzZ19zZXRfYnVmKHNxLT5z ZywgJnhza2hkci0+aGRyLCB2aS0+aGRyX2xlbik7Cj4gPiArCj4gPiArCWNvcGllZCA9IDA7Cj4g PiArCWZvciAoaSA9IDE7IGkgPCBuOyArK2kpIHsKPiA+ICsJCWNvcHkgPSBtaW5fdChpbnQsIGRl c2MtPmxlbiAtIGNvcGllZCwgUEFHRV9TSVpFIC0gb2Zmc2V0KTsKPiA+ICsKPiA+ICsJCXBhZ2Ug PSB4c2tfYnVmZl9yYXdfZ2V0X3BhZ2UocG9vbCwgYWRkciArIGNvcGllZCk7Cj4gPiArCj4gPiAr CQlzZ19zZXRfcGFnZShzcS0+c2cgKyBpLCBwYWdlLCBjb3B5LCBvZmZzZXQpOwo+ID4gKwkJY29w aWVkICs9IGNvcHk7Cj4gPiArCQlpZiAob2Zmc2V0KQo+ID4gKwkJCW9mZnNldCA9IDA7Cj4gPiAr CX0KPiAKPiAKPiBJdCBsb29rcyB0byBtZSB3ZSBuZWVkIHRvIHRlcm1pbmF0ZSB0aGUgc2c6Cj4g Cj4gKioKPiDCoCogdmlydHF1ZXVlX2FkZF9vdXRidWYgLSBleHBvc2Ugb3V0cHV0IGJ1ZmZlcnMg dG8gb3RoZXIgZW5kCj4gwqAqIEB2cTogdGhlIHN0cnVjdCB2aXJ0cXVldWUgd2UncmUgdGFsa2lu ZyBhYm91dC4KPiDCoCogQHNnOiBzY2F0dGVybGlzdCAobXVzdCBiZSB3ZWxsLWZvcm1lZCBhbmQg dGVybWluYXRlZCEpCj4gCj4gCj4gPiArCj4gPiArCXhza2hkci0+bGVuID0gZGVzYy0+bGVuOwo+ ID4gKwlwdHIgPSB4ZHBfdG9fcHRyKCZ4c2toZHItPnR5cGUpOwo+ID4gKwo+ID4gKwllcnIgPSB2 aXJ0cXVldWVfYWRkX291dGJ1ZihzcS0+dnEsIHNxLT5zZywgbiwgcHRyLCBHRlBfQVRPTUlDKTsK PiA+ICsJaWYgKHVubGlrZWx5KGVycikpCj4gPiArCQlzcS0+eHNrLmxhc3RfZGVzYyA9ICpkZXNj Owo+ID4gKwllbHNlCj4gPiArCQlzcS0+eHNrLmhkcl9jb24rKzsKPiA+ICsKPiA+ICsJcmV0dXJu IGVycjsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGJvb2wgdmlydG5ldF94c2tfZGV2X2lzX2Z1 bGwoc3RydWN0IHNlbmRfcXVldWUgKnNxKQo+ID4gK3sKPiA+ICsJaWYgKHNxLT52cS0+bnVtX2Zy ZWUgPCAyICsgTUFYX1NLQl9GUkFHUykKPiA+ICsJCXJldHVybiB0cnVlOwo+ID4gKwo+ID4gKwlp ZiAoc3EtPnhzay5oZHJfY29uID09IHNxLT54c2suaGRyX3BybykKPiA+ICsJCXJldHVybiB0cnVl Owo+IAo+IAo+IENhbiB3ZSByZWFsbHkgcmVhY2ggaGVyZT8KPiAKPiAKPiA+ICsKPiA+ICsJcmV0 dXJuIGZhbHNlOwo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgaW50IHZpcnRuZXRfeHNrX3htaXRf emMoc3RydWN0IHNlbmRfcXVldWUgKnNxLAo+ID4gKwkJCSAgICAgICBzdHJ1Y3QgeHNrX2J1ZmZf cG9vbCAqcG9vbCwgdW5zaWduZWQgaW50IGJ1ZGdldCkKPiA+ICt7Cj4gPiArCXN0cnVjdCB4ZHBf ZGVzYyBkZXNjOwo+ID4gKwlpbnQgZXJyLCBwYWNrZXQgPSAwOwo+ID4gKwlpbnQgcmV0ID0gLUVB R0FJTjsKPiA+ICsKPiA+ICsJaWYgKHNxLT54c2subGFzdF9kZXNjLmFkZHIpIHsKPiA+ICsJCWVy ciA9IHZpcnRuZXRfeHNrX3htaXQoc3EsIHBvb2wsICZzcS0+eHNrLmxhc3RfZGVzYyk7Cj4gPiAr CQlpZiAodW5saWtlbHkoZXJyKSkKPiA+ICsJCQlyZXR1cm4gLUVCVVNZOwo+ID4gKwo+ID4gKwkJ KytwYWNrZXQ7Cj4gPiArCQlzcS0+eHNrLmxhc3RfZGVzYy5hZGRyID0gMDsKPiA+ICsJfQo+ID4g Kwo+ID4gKwl3aGlsZSAoYnVkZ2V0LS0gPiAwKSB7Cj4gPiArCQlpZiAodmlydG5ldF94c2tfZGV2 X2lzX2Z1bGwoc3EpKSB7Cj4gPiArCQkJcmV0ID0gLUVCVVNZOwo+ID4gKwkJCWJyZWFrOwo+ID4g KwkJfQo+IAo+IAo+IEl0IGxvb2tzIHRvIG1lIHdlIHdpbGwgYWx3YXlzIGhpdCB0aGlzIGlmIHVz ZXJzcGFjZSBpcyBmYXN0LiBFLmcgd2UgZG9uJ3QKPiBraWNrIHVudGlsIHRoZSB2aXJ0cXVldWUg aXMgZnVsbCAuLi4KPiAKPiAKPiA+ICsKPiA+ICsJCWlmICgheHNrX3R4X3BlZWtfZGVzYyhwb29s LCAmZGVzYykpIHsKPiA+ICsJCQkvKiBkb25lICovCj4gPiArCQkJcmV0ID0gMDsKPiA+ICsJCQli cmVhazsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCWVyciA9IHZpcnRuZXRfeHNrX3htaXQoc3EsIHBv b2wsICZkZXNjKTsKPiA+ICsJCWlmICh1bmxpa2VseShlcnIpKSB7Cj4gPiArCQkJcmV0ID0gLUVC VVNZOwo+ID4gKwkJCWJyZWFrOwo+ID4gKwkJfQo+ID4gKwo+ID4gKwkJKytwYWNrZXQ7Cj4gPiAr CX0KPiA+ICsKPiA+ICsJaWYgKHBhY2tldCkgewo+ID4gKwkJeHNrX3R4X3JlbGVhc2UocG9vbCk7 Cj4gPiArCj4gPiArCQlpZiAodmlydHF1ZXVlX2tpY2tfcHJlcGFyZShzcS0+dnEpICYmIHZpcnRx dWV1ZV9ub3RpZnkoc3EtPnZxKSkgewo+ID4gKwkJCXU2NF9zdGF0c191cGRhdGVfYmVnaW4oJnNx LT5zdGF0cy5zeW5jcCk7Cj4gPiArCQkJc3EtPnN0YXRzLmtpY2tzKys7Cj4gPiArCQkJdTY0X3N0 YXRzX3VwZGF0ZV9lbmQoJnNxLT5zdGF0cy5zeW5jcCk7Cj4gPiArCQl9Cj4gPiArCX0KPiA+ICsK PiA+ICsJcmV0dXJuIHJldDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGludCB2aXJ0bmV0X3hz a19ydW4oc3RydWN0IHNlbmRfcXVldWUgKnNxLAo+ID4gKwkJCSAgIHN0cnVjdCB4c2tfYnVmZl9w b29sICpwb29sLCBpbnQgYnVkZ2V0KQo+ID4gK3sKPiA+ICsJaW50IGVyciwgcmV0ID0gMDsKPiA+ ICsJdW5zaWduZWQgaW50IF9wYWNrZXRzID0gMDsKPiA+ICsJdW5zaWduZWQgaW50IF9ieXRlcyA9 IDA7Cj4gPiArCj4gPiArCXNxLT54c2sud2FpdF9zbG90ID0gZmFsc2U7Cj4gPiArCj4gPiArCV9f ZnJlZV9vbGRfeG1pdF9wdHIoc3EsIHRydWUsIGZhbHNlLCAmX3BhY2tldHMsICZfYnl0ZXMpOwo+ ID4gKwo+ID4gKwllcnIgPSB2aXJ0bmV0X3hza194bWl0X3pjKHNxLCBwb29sLCB4c2tfYnVkZ2V0 KTsKPiA+ICsJaWYgKCFlcnIpIHsKPiA+ICsJCXN0cnVjdCB4ZHBfZGVzYyBkZXNjOwo+ID4gKwo+ ID4gKwkJY2xlYXJfYml0KFZJUlRORVRfU1RBVEVfWFNLX1dBS0VVUCwgJnNxLT54c2suc3RhdGUp Owo+ID4gKwkJeHNrX3NldF90eF9uZWVkX3dha2V1cChwb29sKTsKPiA+ICsKPiA+ICsJCS8qIFJh Y2UgYnJlYWtlci4gSWYgbmV3IGlzIGNvbWluZyBhZnRlciBsYXN0IHhtaXQKPiA+ICsJCSAqIGJ1 dCBiZWZvcmUgZmxhZyBjaGFuZ2UKPiA+ICsJCSAqLwo+ID4gKwo+ID4gKwkJaWYgKCF4c2tfdHhf cGVla19kZXNjKHBvb2wsICZkZXNjKSkKPiA+ICsJCQlnb3RvIGVuZDsKPiA+ICsKPiA+ICsJCXNl dF9iaXQoVklSVE5FVF9TVEFURV9YU0tfV0FLRVVQLCAmc3EtPnhzay5zdGF0ZSk7Cj4gPiArCQl4 c2tfY2xlYXJfdHhfbmVlZF93YWtldXAocG9vbCk7Cj4gCj4gCj4gSG93IG1lbW9yeSBvcmRlcmlu ZyBpcyBnb2luZyB0byB3b3JrIGhlcmU/IE9yIHdlIGRvbid0IG5lZWQgdG8gY2FyZSBhYm91dAo+ IHRoYXQ/Cj4gCj4gCj4gPiArCj4gPiArCQlzcS0+eHNrLmxhc3RfZGVzYyA9IGRlc2M7Cj4gPiAr CQlyZXQgPSBidWRnZXQ7Cj4gPiArCQlnb3RvIGVuZDsKPiA+ICsJfQo+ID4gKwo+ID4gKwl4c2tf Y2xlYXJfdHhfbmVlZF93YWtldXAocG9vbCk7Cj4gPiArCj4gPiArCWlmIChlcnIgPT0gLUVBR0FJ Tikgewo+ID4gKwkJcmV0ID0gYnVkZ2V0Owo+ID4gKwkJZ290byBlbmQ7Cj4gPiArCX0KPiA+ICsK PiA+ICsJX19mcmVlX29sZF94bWl0X3B0cihzcSwgdHJ1ZSwgZmFsc2UsICZfcGFja2V0cywgJl9i eXRlcyk7Cj4gPiArCj4gPiArCWlmICghdmlydG5ldF94c2tfZGV2X2lzX2Z1bGwoc3EpKSB7Cj4g PiArCQlyZXQgPSBidWRnZXQ7Cj4gPiArCQlnb3RvIGVuZDsKPiA+ICsJfQo+ID4gKwo+ID4gKwlz cS0+eHNrLndhaXRfc2xvdCA9IHRydWU7Cj4gPiArCj4gPiArCXZpcnRuZXRfc3Ffc3RvcF9jaGVj ayhzcSwgdHJ1ZSk7Cj4gPiArZW5kOgo+ID4gKwlyZXR1cm4gcmV0Owo+ID4gK30KPiA+ICsKPiA+ ICAgc3RhdGljIGludCB2aXJ0bmV0X2dldF9waHlzX3BvcnRfbmFtZShzdHJ1Y3QgbmV0X2Rldmlj ZSAqZGV2LCBjaGFyICpidWYsCj4gPiAgIAkJCQkgICAgICBzaXplX3QgbGVuKQo+ID4gICB7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXph dGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmly dHVhbGl6YXRpb24=