From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C817C433DB for ; Mon, 18 Jan 2021 07:23:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF481223DB for ; Mon, 18 Jan 2021 07:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF481223DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+5HijLeblGBJxHuG+3+XMF+3L4Nfe5Dce6cUwYaZEw0=; b=N9rxk9zPdHzDXf2mqoJHQPIZv WPj3cOu9NDyfgdBOEgXUT6yJ0u8Mmgh76JVvog+jfM5ECPoBEPGl08+jjUf7ZYYrrPIe7FRBf7kxK K2tiSqS5CPwBgTpuEAqPIJNfJ5Q/FxZbRK8XfcXie1/B3J/i3JEDW0Hs0++bc9ePbAI7cnrsi1eVp 9VdGbjbgp2KVtUpiHKL7kkUlujX50Qx0NcR/1eSZYNAuBmd63rZqbwVSgKO9K1/B7Gy7LvoeYfzaS yXXY7iXzTxvgD75SgClJS/EIztp9fjBvWsyUO5KjTcpUwY4f1ZR87pG5ZHJFXrXl0Njs3HgDcRGMn IZwJaQohQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Oru-0003cV-Qz; Mon, 18 Jan 2021 07:22:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Orr-0003bv-Qe for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 07:22:28 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42F33223DB; Mon, 18 Jan 2021 07:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610954545; bh=Dys7rGW1fG7tf0UqdF5FrJQ9Cfnw1iIv2F3vpVjk03k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XL1wBH7lWLSYViezMFlGqkpoeFqzJbmTXx44kQJ62VcXev+z/yXVMbtuzGRovLTuK wQINKshwMsBrtGsNfUtpou1IArNuM09LIkaCX5T/q+fLNBYIk+NL3IwKKowNhoBi3s VhyJWalS711mbFfe11aM7dB9k0woiIK6vMJboK9ea+Q00Nyi6b/EKfyRtXOcMvm2OA 9dNFUGKIxVGgxNuWi36L9U9v6GjFeYIdV495xi45IsyePDE/gJmERyi2t0WcN3OKxz Zn+bp9RX5Y6mmwl3AKesBpEzZYsmmlQrNIkZzKVOhPVxuL0cfMor0P3i5U+9PSyMIx y2k5kN2vycpmQ== Date: Mon, 18 Jan 2021 15:22:19 +0800 From: Shawn Guo To: Russell King Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: fix some cubox-i platforms Message-ID: <20210118072218.GO28365@dragon> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_022227_945835_0ABE8941 X-CRM114-Status: GOOD ( 22.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 10:53:06AM +0000, Russell King wrote: > The PHY address bit 2 is configured by the LED pin. Attaching a LED > to this pin is not sufficient to guarantee this configuration pin is > correctly read. This leads to some platforms having their PHY at > address 0 and others at address 4. > > If there is no phy-handle specified, the FEC driver will scan the PHY > bus for a PHY and use that. Consequently, adding the DT configuration > of the PHY and the phy properties to the FEC driver broke some boards. > > Fix this by removing the phy-handle property, and listing two PHY > entries for both possible PHY addresses, so that the DT configuration > for the PHY can be found by the PHY driver. > > Fixes: 86b08bd5b994 ("ARM: dts: imx6-sr-som: add ethernet PHY configuration") > Reported-by: Christoph Mattheis > Signed-off-by: Russell King > --- > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > index b06577808ff4..1d1f9ec27045 100644 > --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > @@ -53,7 +53,6 @@ > &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; > - phy-handle = <&phy>; > phy-mode = "rgmii-id"; > phy-reset-duration = <2>; > phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > @@ -63,10 +62,18 @@ > #address-cells = <1>; > #size-cells = <0>; > > - phy: ethernet-phy@0 { > + /* > + * The PHY can appear at either address 0 or 4 due to the > + * configuration (LED) pin not being pulled sufficiently. > + */ > + ethernet-phy@0 { > reg = <0>; > qca,clk-out-frequency = <125000000>; > }; > + ethernet-phy@4 { Let's have a newline between nodes. Fixed it up and applied. Shawn > + reg = <4>; > + qca,clk-out-frequency = <125000000>; > + }; > }; > }; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD73C433DB for ; Mon, 18 Jan 2021 07:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9760A223DB for ; Mon, 18 Jan 2021 07:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730151AbhARHXZ (ORCPT ); Mon, 18 Jan 2021 02:23:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:42278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730941AbhARHXH (ORCPT ); Mon, 18 Jan 2021 02:23:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42F33223DB; Mon, 18 Jan 2021 07:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610954545; bh=Dys7rGW1fG7tf0UqdF5FrJQ9Cfnw1iIv2F3vpVjk03k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XL1wBH7lWLSYViezMFlGqkpoeFqzJbmTXx44kQJ62VcXev+z/yXVMbtuzGRovLTuK wQINKshwMsBrtGsNfUtpou1IArNuM09LIkaCX5T/q+fLNBYIk+NL3IwKKowNhoBi3s VhyJWalS711mbFfe11aM7dB9k0woiIK6vMJboK9ea+Q00Nyi6b/EKfyRtXOcMvm2OA 9dNFUGKIxVGgxNuWi36L9U9v6GjFeYIdV495xi45IsyePDE/gJmERyi2t0WcN3OKxz Zn+bp9RX5Y6mmwl3AKesBpEzZYsmmlQrNIkZzKVOhPVxuL0cfMor0P3i5U+9PSyMIx y2k5kN2vycpmQ== Date: Mon, 18 Jan 2021 15:22:19 +0800 From: Shawn Guo To: Russell King Cc: Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: fix some cubox-i platforms Message-ID: <20210118072218.GO28365@dragon> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 14, 2021 at 10:53:06AM +0000, Russell King wrote: > The PHY address bit 2 is configured by the LED pin. Attaching a LED > to this pin is not sufficient to guarantee this configuration pin is > correctly read. This leads to some platforms having their PHY at > address 0 and others at address 4. > > If there is no phy-handle specified, the FEC driver will scan the PHY > bus for a PHY and use that. Consequently, adding the DT configuration > of the PHY and the phy properties to the FEC driver broke some boards. > > Fix this by removing the phy-handle property, and listing two PHY > entries for both possible PHY addresses, so that the DT configuration > for the PHY can be found by the PHY driver. > > Fixes: 86b08bd5b994 ("ARM: dts: imx6-sr-som: add ethernet PHY configuration") > Reported-by: Christoph Mattheis > Signed-off-by: Russell King > --- > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > index b06577808ff4..1d1f9ec27045 100644 > --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > @@ -53,7 +53,6 @@ > &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; > - phy-handle = <&phy>; > phy-mode = "rgmii-id"; > phy-reset-duration = <2>; > phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > @@ -63,10 +62,18 @@ > #address-cells = <1>; > #size-cells = <0>; > > - phy: ethernet-phy@0 { > + /* > + * The PHY can appear at either address 0 or 4 due to the > + * configuration (LED) pin not being pulled sufficiently. > + */ > + ethernet-phy@0 { > reg = <0>; > qca,clk-out-frequency = <125000000>; > }; > + ethernet-phy@4 { Let's have a newline between nodes. Fixed it up and applied. Shawn > + reg = <4>; > + qca,clk-out-frequency = <125000000>; > + }; > }; > }; > > -- > 2.20.1 >