From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:4c03:0:0:0:0:0 with SMTP id t3csp2770372lfq; Mon, 18 Jan 2021 12:11:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzo2GIE08YtTz6gqxNttIjUI0zuxZdzvl8gOl0N8Gzwl04sEJJmvQjVBtTTB4e1dhaK4D8O X-Received: by 2002:a25:7491:: with SMTP id p139mr1087463ybc.346.1611000685115; Mon, 18 Jan 2021 12:11:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611000685; cv=none; d=google.com; s=arc-20160816; b=J2L25wkNP6FVPOM9ciG8qgEJgcI1JIxuy0GotYMR1Q3JDxUSi0D0MFQJkIbFEywhKr OM51R2QYpFAILO+sgXedBjE1FBjEvtY80lYruJjuUjFl5CgSQKSZgfPlzoh9DyifnI5c dkQV63APjL2PtA04XbkeQk8Le0eXFprE5tRaFOkiLe33tHwEb6/OrfjGRT30RKjkzj/g 8eT7fZgPoH4DrVum+We4YMd3c+jo9Zg4gc2bIG6qxZ4BbNIji9cCqDYBsQTFA8pnpByu ujHRhXf7zaL57BvgDym2kZOAcckp2wQ3Cjymssb0fmN1RBfGJe11l2/aD4fN/XvD46J/ YcGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-disposition:user-agent:in-reply-to:mime-version:references :message-id:subject:to:from:date:dkim-signature; bh=WUVVBo6Ajtsp1p1cl9vt8il5Uqeysu/ud/O2QfPozL8=; b=t9jKZCh1zK8MDwxqZk6qRVa76LOQ1S9qsFPjabPB/Zz0lwJvUfeDSg8L6l/MyWRt40 t839JQtxKzp2djYlp57sSf59E8Tw1DIBNq/w5irMn4u4Dqb0HvJIavMUyG4Qxl8vjsi6 oN5Gke9XGYlo7XMhcmCz9ndHSMc11PZBnOK3V0f+MitIeB54lLxQjWooiWzW83AJ2tsd nlDmtzhIfIdVDDHZD2i7henkfQI7lqBzcJKdH/8yR1KP0ODjOCNFX4nVu3UbJBY6bOi9 /HX3G6u7nOpryCea5wC6csfHBfWvEU84fGOw7CfPk7FMASwTpSWG/sX0ptgIxKKNQ1QJ grmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CpkRA0Uo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k66si9136289ybf.34.2021.01.18.12.11.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jan 2021 12:11:25 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CpkRA0Uo; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:49666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1as0-0002g6-GJ for alex.bennee@linaro.org; Mon, 18 Jan 2021 15:11:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1arl-0002fP-6y for qemu-arm@nongnu.org; Mon, 18 Jan 2021 15:11:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1arg-000132-5m for qemu-arm@nongnu.org; Mon, 18 Jan 2021 15:11:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611000661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WUVVBo6Ajtsp1p1cl9vt8il5Uqeysu/ud/O2QfPozL8=; b=CpkRA0UoG2T42432G5Zk3Yc3vDG90e8ku6CiE8eLb/j2C1kmuvR75XnsWRiF/ukugm/jHW 4RqkxITZ+y7s51n9Jl8qwhIXOlh5RfhT/unmOcq8BR6HgPeEYxzDaXPNHTtIZdJXxqX9dX 6fXQFkztwib7drjMgwcssO9X0s2ZbvI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-_5-D_X5wMBS0cETqTD7Ozg-1; Mon, 18 Jan 2021 15:10:58 -0500 X-MC-Unique: _5-D_X5wMBS0cETqTD7Ozg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A459192FDA3; Mon, 18 Jan 2021 20:10:56 +0000 (UTC) Received: from work-vm (ovpn-115-197.ams2.redhat.com [10.36.115.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB2DE1002388; Mon, 18 Jan 2021 20:10:47 +0000 (UTC) Date: Mon, 18 Jan 2021 20:10:45 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [RFC PATCH v2 10/20] hw/usb/hcd-ohci: Mark the device with no migratable fields Message-ID: <20210118201045.GI9899@work-vm> References: <20210117192446.23753-1-f4bug@amsat.org> <20210117192446.23753-11-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20210117192446.23753-11-f4bug@amsat.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.175, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , Juan Quintela , Andrew Jeffery , Mark Cave-Ayland , qemu-devel@nongnu.org, Andrew Baumann , Subbaraya Sundeep , Joel Stanley , Laurent Vivier , qemu-arm@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater , Marcel Apfelbaum , Paolo Bonzini , Artyom Tarasenko , Gerd Hoffmann Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: Zd7e3EmtR2G2 * Philippe Mathieu-Daudé (f4bug@amsat.org) wrote: > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Add a more descriptive comment to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe Mathieu-Daudé OK, Reviewed-by: Dr. David Alan Gilbert although I think it's quite interesting; I think we have a base class which has data to migrate which expects any child classes to migrate it's data; so marking it as not actually having any state is not quite right. > --- > hw/usb/hcd-ohci.h | 2 ++ > hw/usb/hcd-ohci.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h > index 11ac57058d1..fd4842a352f 100644 > --- a/hw/usb/hcd-ohci.h > +++ b/hw/usb/hcd-ohci.h > @@ -101,6 +101,8 @@ struct OHCISysBusState { > /*< public >*/ > > OHCIState ohci; > + > + /* Properties */ > char *masterbus; > uint32_t num_ports; > uint32_t firstport; > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index f8c64c8b95b..302aab30992 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -2007,6 +2007,7 @@ static void ohci_sysbus_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > > dc->realize = ohci_realize_pxa; > + dc->vmsd = vmstate_qdev_no_state_to_migrate; > set_bit(DEVICE_CATEGORY_USB, dc->categories); > dc->desc = "OHCI USB Controller"; > device_class_set_props(dc, ohci_sysbus_properties); > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7271DC433DB for ; Mon, 18 Jan 2021 20:36:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1A0122D2A for ; Mon, 18 Jan 2021 20:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1A0122D2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1bFt-0003mY-3f for qemu-devel@archiver.kernel.org; Mon, 18 Jan 2021 15:36:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1ari-0002em-Pc for qemu-devel@nongnu.org; Mon, 18 Jan 2021 15:11:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1arf-000136-QF for qemu-devel@nongnu.org; Mon, 18 Jan 2021 15:11:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611000662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WUVVBo6Ajtsp1p1cl9vt8il5Uqeysu/ud/O2QfPozL8=; b=cwA//VxcW9Z1oC6OvFd0PKzVjptXYyRuIu2VPOSX6eg2/g9rClFQ+BM9dIpJO924p8ia9A +GzxcE5BDLLI8OXWvhC59Ohh4bN+BhV70G/ypHrUtX6w77FOAutirLNqbe0VlmYhAar7Wa 4bxYJth66T1GDEDygJNNlI6efUdvhcI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-_5-D_X5wMBS0cETqTD7Ozg-1; Mon, 18 Jan 2021 15:10:58 -0500 X-MC-Unique: _5-D_X5wMBS0cETqTD7Ozg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A459192FDA3; Mon, 18 Jan 2021 20:10:56 +0000 (UTC) Received: from work-vm (ovpn-115-197.ams2.redhat.com [10.36.115.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB2DE1002388; Mon, 18 Jan 2021 20:10:47 +0000 (UTC) Date: Mon, 18 Jan 2021 20:10:45 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [RFC PATCH v2 10/20] hw/usb/hcd-ohci: Mark the device with no migratable fields Message-ID: <20210118201045.GI9899@work-vm> References: <20210117192446.23753-1-f4bug@amsat.org> <20210117192446.23753-11-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20210117192446.23753-11-f4bug@amsat.org> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.175, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , Juan Quintela , Andrew Jeffery , Mark Cave-Ayland , qemu-devel@nongnu.org, Andrew Baumann , Subbaraya Sundeep , Joel Stanley , Laurent Vivier , qemu-arm@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater , Paolo Bonzini , Artyom Tarasenko , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daudé (f4bug@amsat.org) wrote: > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Add a more descriptive comment to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe Mathieu-Daudé OK, Reviewed-by: Dr. David Alan Gilbert although I think it's quite interesting; I think we have a base class which has data to migrate which expects any child classes to migrate it's data; so marking it as not actually having any state is not quite right. > --- > hw/usb/hcd-ohci.h | 2 ++ > hw/usb/hcd-ohci.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h > index 11ac57058d1..fd4842a352f 100644 > --- a/hw/usb/hcd-ohci.h > +++ b/hw/usb/hcd-ohci.h > @@ -101,6 +101,8 @@ struct OHCISysBusState { > /*< public >*/ > > OHCIState ohci; > + > + /* Properties */ > char *masterbus; > uint32_t num_ports; > uint32_t firstport; > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index f8c64c8b95b..302aab30992 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -2007,6 +2007,7 @@ static void ohci_sysbus_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > > dc->realize = ohci_realize_pxa; > + dc->vmsd = vmstate_qdev_no_state_to_migrate; > set_bit(DEVICE_CATEGORY_USB, dc->categories); > dc->desc = "OHCI USB Controller"; > device_class_set_props(dc, ohci_sysbus_properties); > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK