From: Rob Herring <robh@kernel.org>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: lp50xx: add setting of default intensity from DT
Date: Mon, 18 Jan 2021 20:19:05 -0600 [thread overview]
Message-ID: <20210119021905.GA759930@robh.at.kernel.org> (raw)
In-Reply-To: <20210118140947.3887-1-schuchmann@schleissheimer.de>
On Mon, 18 Jan 2021 14:09:47 +0000, Sven Schuchmann wrote:
> In order to use a multicolor-led together with a trigger
> the led needs to have an intensity set to see something.
> The trigger changes the brightness of the led but if there
> is no intensity we actually see nothing.
>
> This patch adds the ability to set the default intensity
> of each led so that it is turned on from DT.
>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 6 +++++-
> drivers/leds/leds-lp50xx.c | 4 ++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml: patternProperties:^multi-led@[0-9a-f]$:patternProperties:(^led-[0-9a-f]$|led):properties:default-intensity: 'The intensity the LED get initialised with.' is not of type 'object', 'boolean'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml: ignoring, error in schema: patternProperties: ^multi-led@[0-9a-f]$: patternProperties: (^led-[0-9a-f]$|led): properties: default-intensity
warning: no schema found in file: ./Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
See https://patchwork.ozlabs.org/patch/1428176
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2021-01-19 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 14:09 [PATCH] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-01-19 2:19 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119021905.GA759930@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.