From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, msuchanek@suse.de, lpechacek@suse.com
Subject: Re: [PATCH] selftests/powerpc: Only test lwm/stmw on big endian
Date: Tue, 19 Jan 2021 19:12:21 -0600 [thread overview]
Message-ID: <20210120011221.GG30983@gate.crashing.org> (raw)
In-Reply-To: <20210119041800.3093047-1-mpe@ellerman.id.au>
Hi!
On Tue, Jan 19, 2021 at 03:18:00PM +1100, Michael Ellerman wrote:
> Newer binutils (>= 2.36) refuse to assemble lmw/stmw when building in
> little endian mode. That breaks compilation of our alignment handler
> test:
>
> /tmp/cco4l14N.s: Assembler messages:
> /tmp/cco4l14N.s:1440: Error: `lmw' invalid when little-endian
> /tmp/cco4l14N.s:1814: Error: `stmw' invalid when little-endian
> make[2]: *** [../../lib.mk:139: /output/kselftest/powerpc/alignment/alignment_handler] Error 1
>
> These tests do pass on little endian machines, as the kernel will
> still emulate those instructions even when running little
> endian (which is arguably a kernel bug).
The opposite: in older ISAs it is *required* to. On all very old ISA
versions, and when not on the Server Environment on everything before
ISA 2.07.
Many older implementations did an alignment interrupt, but that was an
implementation detail (they could still be compliant with proper system
software support, e.g. kernel emulation handlers). Nowadays that
interrupt is required, so you can still support it like that.
(The patch is fine of course.)
Segher
next prev parent reply other threads:[~2021-01-20 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 4:18 [PATCH] selftests/powerpc: Only test lwm/stmw on big endian Michael Ellerman
2021-01-19 20:01 ` Libor Pechacek
2021-01-20 1:12 ` Segher Boessenkool [this message]
2021-01-20 4:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120011221.GG30983@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lpechacek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.