From: Lee Jones <lee.jones@linaro.org>
To: Jeff LaBundy <jeff@labundy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] mfd: iqs62x: Do not poll during ATI
Date: Wed, 20 Jan 2021 08:43:46 +0000 [thread overview]
Message-ID: <20210120084346.GR4903@dell> (raw)
In-Reply-To: <1610942228-7275-6-git-send-email-jeff@labundy.com>
On Sun, 17 Jan 2021, Jeff LaBundy wrote:
> After loading firmware, the driver triggers ATI (calibration) with
> the newly loaded register configuration in place. Next, the driver
> polls a register field to ensure ATI completed in a timely fashion
> and that the device is ready to sense.
>
> However, communicating with the device over I2C while ATI is under-
> way may induce noise in the device and cause ATI to fail. As such,
> the vendor recommends not to poll the device during ATI.
>
> To solve this problem, let the device naturally signal to the host
> that ATI is complete by way of an interrupt. A completion prevents
> the sub-devices from being registered until this happens.
>
> The former logic that scaled ATI timeout and filter settling delay
> is not carried forward with the new implementation, as it produces
> overly conservative delays at lower clock rates. Instead, a single
> pair of delays that covers all cases is used.
>
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> ---
> Changes in v2:
> - Removed superfluous newlines throughout all iqs62x_dev_desc structs
>
> drivers/mfd/iqs62x.c | 125 +++++++++++++++++++++++++--------------------
> include/linux/mfd/iqs62x.h | 11 ++--
> 2 files changed, 73 insertions(+), 63 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-01-20 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 3:57 [PATCH v2 0/6] mfd: iqs62x: Minor cosmetic and functional improvements Jeff LaBundy
2021-01-18 3:57 ` [PATCH v2 1/6] mfd: iqs62x: Remove superfluous whitespace above fallthroughs Jeff LaBundy
2021-01-20 8:41 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 2/6] mfd: iqs62x: Remove unused bit mask Jeff LaBundy
2021-01-20 8:42 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 3/6] mfd: iqs62x: Rename regmap_config struct Jeff LaBundy
2021-01-20 8:43 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 4/6] mfd: iqs62x: Increase interrupt handler return delay Jeff LaBundy
2021-01-20 8:43 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 5/6] mfd: iqs62x: Do not poll during ATI Jeff LaBundy
2021-01-20 8:43 ` Lee Jones [this message]
2021-01-18 3:57 ` [PATCH v2 6/6] mfd: iqs62x: Do not change clock frequency " Jeff LaBundy
2021-01-20 8:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120084346.GR4903@dell \
--to=lee.jones@linaro.org \
--cc=jeff@labundy.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.