From: Lukas Straub <lukasstraub2@web.de>
To: leirao <lei.rao@intel.com>
Cc: zhang.zhanghailiang@huawei.com, lizhijian@cn.fujitsu.com,
quintela@redhat.com, jasowang@redhat.com, dgilbert@redhat.com,
qemu-devel@nongnu.org, chen.zhang@intel.com
Subject: Re: [PATCH 01/10] Remove some duplicate trace code.
Date: Wed, 20 Jan 2021 19:43:06 +0100 [thread overview]
Message-ID: <20210120194306.67d87a61@gecko.fritz.box> (raw)
In-Reply-To: <1610505995-144129-2-git-send-email-lei.rao@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On Wed, 13 Jan 2021 10:46:26 +0800
leirao <lei.rao@intel.com> wrote:
> From: "Rao, Lei" <lei.rao@intel.com>
>
> There is the same trace code in the colo_compare_packet_payload.
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
Looks good to me,
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
> ---
> net/colo-compare.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 84db497..9e18baa 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -590,19 +590,6 @@ static int colo_packet_compare_other(Packet *spkt, Packet *ppkt)
> uint16_t offset = ppkt->vnet_hdr_len;
>
> trace_colo_compare_main("compare other");
> - if (trace_event_get_state_backends(TRACE_COLO_COMPARE_IP_INFO)) {
> - char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];
> -
> - strcpy(pri_ip_src, inet_ntoa(ppkt->ip->ip_src));
> - strcpy(pri_ip_dst, inet_ntoa(ppkt->ip->ip_dst));
> - strcpy(sec_ip_src, inet_ntoa(spkt->ip->ip_src));
> - strcpy(sec_ip_dst, inet_ntoa(spkt->ip->ip_dst));
> -
> - trace_colo_compare_ip_info(ppkt->size, pri_ip_src,
> - pri_ip_dst, spkt->size,
> - sec_ip_src, sec_ip_dst);
> - }
> -
> if (ppkt->size != spkt->size) {
> trace_colo_compare_main("Other: payload size of packets are different");
> return -1;
--
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-20 18:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 2:46 [PATCH 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-01-13 2:46 ` [PATCH 01/10] Remove some duplicate trace code leirao
2021-01-20 18:43 ` Lukas Straub [this message]
2021-01-13 2:46 ` [PATCH 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-01-20 19:12 ` Lukas Straub
2021-01-21 1:48 ` Rao, Lei
2021-01-27 18:24 ` Lukas Straub
2021-01-29 2:57 ` Rao, Lei
2021-02-14 11:45 ` Lukas Straub
2021-02-25 9:40 ` Rao, Lei
2021-01-13 2:46 ` [PATCH 03/10] Optimize the function of filter_send leirao
2021-01-20 19:21 ` Lukas Straub
2021-01-21 1:02 ` Rao, Lei
2021-01-13 2:46 ` [PATCH 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-01-20 19:28 ` Lukas Straub
2021-01-13 2:46 ` [PATCH 05/10] Optimize the function of packet_new leirao
2021-01-20 19:45 ` Lukas Straub
2021-01-13 2:46 ` [PATCH 06/10] Add the function of colo_compare_cleanup leirao
2021-01-13 2:46 ` [PATCH 07/10] Disable auto-coverge before entering COLO mode leirao
2021-01-13 11:31 ` Dr. David Alan Gilbert
2021-01-14 3:21 ` Rao, Lei
2021-02-14 10:52 ` Lukas Straub
2021-02-25 9:22 ` Rao, Lei
2021-01-13 2:46 ` [PATCH 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-01-13 2:46 ` [PATCH 09/10] Add the function of colo_bitmap_clear_diry leirao
2021-01-13 2:46 ` [PATCH 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao
2021-02-14 11:50 ` [PATCH 00/10] Fixed some bugs and optimized some codes for COLO Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120194306.67d87a61@gecko.fritz.box \
--to=lukasstraub2@web.de \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lei.rao@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.